Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
63 commits
Select commit Hold shift + click to select a range
e3b1bbd
feat(updater): independent release-verified staging and exit-safe Inn…
masarray Nov 9, 2026
418df8f
feat(updater): install external supervisor next to verified native EXE
masarray Nov 9, 2026
d360408
feat(updater): launch non-audio supervisor and acknowledge GUI startup
masarray Nov 9, 2026
430ed2a
fix(updater): cross-check release checksum/provenance and handle fail…
masarray Nov 9, 2026
0a0cc9d
test(updater): preserve native packaging and no-audio safety contracts
masarray Nov 9, 2026
1f68069
test(updater): execute offline PowerShell policy gate on Windows
masarray Nov 9, 2026
02314be
docs(updater): formalize live-safe release trust, bootstrap, recovery…
masarray Nov 9, 2026
7e22137
fix(updater): avoid PowerShell automatic variable collision and keep …
masarray Nov 9, 2026
c2f9c39
Merge latest ArSon Player main into updater M1 without altering Playe…
masarray Nov 9, 2026
bc14efe
perf(updater): split short-lived release checker from post-close inst…
masarray Nov 9, 2026
cb677f2
perf(updater): short-lived checker and on-exit verified installer; el…
masarray Nov 9, 2026
a85b595
perf(updater): run short-lived checker at startup and apply staged up…
masarray Nov 9, 2026
0daf311
test(updater): enforce short-lived checker and on-exit apply
masarray Nov 9, 2026
88ff4a4
docs(updater): describe no-resident-worker update flow and revocation…
masarray Nov 9, 2026
4ad19ad
fix(updater): correctly acknowledge dashed GUID health probe with pin…
masarray Nov 9, 2026
8c0f459
test(updater): lock GUID format across JUCE and PowerShell health signal
masarray Nov 9, 2026
b6c66c7
fix(updater): fail-closed auto installation, never request mixer shut…
masarray Nov 9, 2026
3400604
fix(updater): add exact-image read-only probe for automatic updates
masarray Nov 9, 2026
8967d77
fix(updater): pass strict automatic setup mode
masarray Nov 9, 2026
78dd40f
fix(updater): cover automatic mode no-close guarantee
masarray Nov 9, 2026
82e4465
fix(updater): exercise active-session preservation in Windows Inno
masarray Nov 9, 2026
7470561
test(updater): validate both live-session rejection and clean auto in…
masarray Nov 9, 2026
a3cc27e
fix(updater): prevent relaunch during timed-out installer; recover fr…
masarray Nov 9, 2026
5321376
fix(updater): skip automatic update installation during Windows shutdown
masarray Nov 9, 2026
a38c667
fix(updater): lock installer timeout, shutdown and resource-priority …
masarray Nov 9, 2026
531093a
test(updater): close legacy fixture using proven exact-path helper af…
masarray Nov 9, 2026
c9cee93
test(updater): extract staged integrity predicate and verify tamperin…
masarray Nov 9, 2026
f7ad3fb
test(updater): require actual staged integrity fixtures
masarray Nov 9, 2026
da06e57
test(updater): run staged EXE hash and size policy test on Windows
masarray Nov 9, 2026
5b79af4
docs(updater): capture noninterrupting auto mode, staged tamper fixtu…
masarray Nov 9, 2026
37d6923
feat(updater): recover interrupted state, verify in-place self-repair…
masarray Nov 9, 2026
7dd9956
fix(updater): revalidate cached installers and quarantine revoked upd…
masarray Nov 9, 2026
0b4a828
feat(updater): bounded one-time delayed retry for transient Inno reje…
masarray Nov 9, 2026
4b08426
test(updater): prove unattended same-version Inno repair restores cor…
masarray Nov 9, 2026
eb5fdcf
feat(updater): install one-click external recovery shortcut with safe…
masarray Nov 9, 2026
01c8006
feat(updater): standalone authenticated recovery for missing/corrupt …
masarray Nov 9, 2026
6f7b7a7
test(updater): assert external recovery contract and no live-session …
masarray Nov 9, 2026
bb578c1
test(updater): repair deleted synthetic EXE with real Windows Inno
masarray Nov 9, 2026
0fc173e
docs(updater): explain Start Menu recovery and security limitations
masarray Nov 9, 2026
60c7a06
fix(updater): standalone Repair always restore authenticated vendor f…
masarray Nov 9, 2026
acd24bb
fix(updater): remove duplicated trailing PowerShell code before recov…
masarray Nov 9, 2026
d6b5c0e
test(updater): reject duplicated PowerShell trailer and missing recov…
masarray Nov 9, 2026
284b5b2
test(updater): normalize checked-out Windows CRLF before PowerShell t…
masarray Nov 9, 2026
fa53fd1
fix(updater): parse-safe SemVer choice for authenticated external rec…
masarray Nov 9, 2026
0763a4a
fix(updater): restore 40-hex source validation lost to unsafe string …
masarray Nov 9, 2026
88dfdf3
fix(updater): require installed EXE SHA for healthy update, repair an…
masarray Nov 9, 2026
9fb0a2a
test(updater): certify exact executable identity before healthy recovery
masarray Nov 9, 2026
5c72b61
test(updater): certify exact executable identity before healthy recovery
masarray Nov 9, 2026
99bab64
test(updater): certify exact executable identity before healthy recovery
masarray Nov 9, 2026
b70a520
test(updater): verify real alpha.4 to alpha.5 upgrade and rollback wi…
masarray Nov 9, 2026
f889ded
ci(updater): opt-in Windows FAT for two published real release instal…
masarray Nov 9, 2026
27b79c1
test(updater): guard opt-in genuine two-release FAT and non-destructi…
masarray Nov 9, 2026
a6e8fd3
docs(updater): document real published-release upgrade and rollback FAT
masarray Nov 9, 2026
c5f58dd
test(ci): account for opt-in genuine-release rollback FAT without inc…
masarray Nov 9, 2026
72ae45d
fix(updater): reauthenticate published rollback source and SHA before…
masarray Nov 9, 2026
c177bc0
test(updater): enforce rollback asset provenance before Inno applies …
masarray Nov 9, 2026
c8e9af6
docs(updater): require published rollback authenticity on every apply
masarray Nov 9, 2026
f367c35
fix(updater): enumerate Windows PowerShell 5.1 releases, retry incomp…
masarray Nov 9, 2026
473fa7c
fix(updater): write healthy GUI marker only on successful WebView sta…
masarray Nov 9, 2026
610d5e4
test(updater): guard PowerShell REST array, WebView failure stage and…
masarray Nov 9, 2026
e6fbde1
docs(updater): close open P1/P2 findings from code review
masarray Nov 9, 2026
e289b34
fix(updater): validate candidate and rollback cache independently in …
masarray Nov 9, 2026
af9bdba
test(updater): guard explicit two-sided SHA validation before install
masarray Nov 9, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/p1-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,15 @@ jobs:
run: |
& ./scripts/build_verify_windows_installer.ps1 -OutputDir dist -InstallerOutput installer-output
if ($LASTEXITCODE -ne 0) { exit $LASTEXITCODE }
# One opt-in exact-SHA FAT: genuine published alpha.4 -> alpha.5 ->
# alpha.4 rollback, always on a disposable GitHub Windows runner.
# Never executed by ordinary PR/push, never on a user's workstation.
- name: Prove two authentic historical Inno releases upgrade and roll back
if: ${{ github.event_name == 'workflow_dispatch' && inputs.package_fat == true }}
shell: pwsh
run: |
& ./scripts/test_two_genuine_inno_releases_windows.ps1
if ($LASTEXITCODE -ne 0) { exit $LASTEXITCODE }
- uses: actions/upload-artifact@v4
if: ${{ github.event_name == 'workflow_dispatch' && inputs.package_fat == true }}
with:
Expand Down
69 changes: 69 additions & 0 deletions docs/ADR_SMART_AUTO_UPDATER_20261109.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
# ArSonMix Windows Smart Auto Update — M1 design and safety contract (2026-11-09)

## Scope and status
Implementation branch: `feature/smart-auto-updater-safe-20261109`. Windows x64 **per-user Inno-installed** ArSonMix only. No portable/Windows service, no Linux/macOS auto-install. This is not stable/hardware-qualified until exact-source Windows MSVC/Inno/real desktop tests pass. **Older installations must first receive one installer containing `ArSonMixAutoUpdate.ps1`; no code can remotely update an installed old binary without a bootstrapping updater.**

## User workflow (no new GUI, no interruption to live mixing)
1. JUCE native launches the installed updater as an independent hidden PowerShell process after constructing the approved mixer GUI. The audio callback never opens a URL, parses JSON, reads files, waits for the network or invokes a child process.
2. The worker holds one named mutex per user, checks no more than once per six hours, and fetches official `api.github.com/repos/masarray/arsonmix/releases` metadata. The installed `BUILD_PROVENANCE.json.sourceCommit` MUST match a currently published, valid older release. No development/portable/unknown source is upgraded.
3. Strict SemVer including alpha/beta/rc ordering prevents downgrade. A stable installation does not automatically opt into prereleases. Only unique, published Windows Inno **EXE** assets with a valid immutable tag, 40-hex commit, expected exact GitHub download URL, GitHub asset digest, `INSTALLER_PROVENANCE.json` and `SHA256SUMS.txt` qualify.
4. Stage both the replacement installer and the currently published rollback installer in per-user LocalAppData; independently verify size, SHA-256, per-release checksums and provenance source commit. Limit download sizes and HTTPS redirect hosts. No network failure may break normal mixer startup or operation. Apply checks the release API once more to reject revoked releases; if offline on normal close, the update is deferred.
5. During a normal shutdown, start a second short-lived supervisor and wait briefly for the original mixer process to **exit naturally**. No updater-driven `WM_CLOSE`, `SetEvent`, force kill or automatic device arm. If a new mixer instance is open, defer instead of interrupting a new session. The new Inno `/ARSONMIXAUTOUPDATE` mode runs a read-only, exact-EXE-path `-ProbeOnly` preflight (including unreadable-process fail-close), checks the running-mixer mutex and exclusive file access, and **never signals shutdown or WM_CLOSE**. Manual installation retains its normal graceful shutdown path.
6. Run the existing per-user Inno installer silently with the explicit fail-closed automatic-update mode. Silent Inno does not autostart GUI; the updater itself starts exactly one application. The new JUCE GUI acknowledges rendering readiness with a random GUID-scoped `GUI_READY` marker, and the worker checks installed source SHA plus a still-alive process. On success clean staged binaries and retain only small metadata/status.
7. A failed version is locally blocked from repeated automatic retries. Silent setup exceeding its bounded process wait is left untouched: **no second installer, relaunch or rollback** may start while the first could still be replacing files. GUI launch exceptions become explicit health failure so the previous verified installer can be considered for rollback. If startup fails and **no new mixer is running**, recover by running the previously verified original installer; restore the previous source identity and relaunch. If the failed new GUI is still alive/hung, fail closed rather than destroying live edits.

## Why installation on normal exit?
Automatic shutdown while a singer performs is not an acceptable live mixer contract. Silence on the meter is not proof that performance is finished. Staging while running and applying only on normal exit guarantees the updater never deliberately interrupts the monitoring path. The checker exits immediately after staging, so no resident PowerShell process occupies memory during an ongoing mix. Normal shutdown starts a second worker to apply only the previously staged update; a user who never closes the app does not receive the update. The update may relaunch the GUI after a user intentionally quits. This is a documented tradeoff, not a promise of zero disruption.

## Integrity and trust boundary
The update trusts HTTPS to the official GitHub API, immutable release source identity and GitHub-provided asset SHA256 digests, corroborated with the release's checksum/provenance assets. This guards against stale Pages catalogs, corrupted downloads, arbitrary third-party URLs and accidental version reversal. It is **not** a replacement for Authenticode publisher signing or a separately signed update manifest; an attacker controlling the repository's release publisher may control all those metadata values. Before stable/default-on auto-updates for general users, require an approved code-signing identity and an authenticated/pinned signing key, plus credential-rotation and revocation procedures. Do not claim that the alpha preview is signed.

## Update lifecycle, operational safety
- Mutex `Local\\ArSonMix.AutoUpdater.v1` serializes the short-lived check/apply workers; existing `SetupMutex` serializes Inno. State is atomically replaced and may record `staged`, `installing`, `health-failed`, `rolled-back` and `idle`. Failure details are in `%LOCALAPPDATA%\\ArSonMix\\Updates\\last-result.txt`.
- Fail closed on unknown installed source, invalid provenance, untrusted URL, missing/duplicate assets, download overrun/short read/SHA mismatch, ZIP-only release, offline service, current app still active or installer lock. The worker uses a below-normal process priority; Windows sign-out/shutdown does not start a fresh installation. Private `.smix`, Studio data and user VSTs are never deleted by the updater.
- This worker downloads Inno EXE directly, not a ZIP: ZIP is for the public browser download and is irrelevant to the installer orchestration path.
- Mark healthy only after a real native GUI-ready event, not merely a successful silent installer return. A device/ASIO acoustic test remains separate from this updater health marker.
- Rollback remains best effort if Windows/antivirus blocks both old and new installers. A previously published rollback installer may predate `/ARSONMIXAUTOUPDATE`; the supervisor still checks no running ArSonMix before invoking it, but exact cross-version desktop rollback race tests remain mandatory prior to stable release. A running, non-responsive GUI is left intact instead of force-killed. Never promise mathematically impossible “no crash”.
- Updater is disabled on portable packages (script absent or `portable_mode.txt`). Unsupported operating systems are never offered Windows installers.

## Acceptance tests / release gates
- Cheap `tests/windows_installer_contract_test.mjs` ensures packaging, safe process isolation, and no forced termination. Windows `scripts/test_inno_graceful_update_windows.ps1` exercises `-PolicySelfTest` (SemVer, untrusted URL, duplicate release artifact, tampered/short/missing 2MiB staged EXE), graceful/legacy/hung upgrade fixtures, **automatic-mode refusal while the mixer is running without WM_CLOSE**, and **automatic-mode installation after normal exit**.
- Exact-head Windows MSVC compile + all relevant CTest, native startup readiness marker, real Inno update/uninstall, source identity and private Studio retention; test intermittent networks, wrong hashes, smaller/larger response, same version, downgrade, repeated launches, hung app and rollback from startup crash on Windows (not all covered by existing fixture).
- No automatic stable release until code signing/pinned publisher identity and a real end-to-end M2 rollback/health FAT with two **genuine** ArSonMix installers. Existing synthetic WinForms/Inno smoke cannot certify real ASIO audio or startup health under actual WebView2 hardware.

## Non-goals
No second GUI, updater UI banner/card, silent audio-device remap, DSP changes, Windows service, forced termination, system-wide install, scheduled task, repeated background CI or cross-platform pretend-updater.

## M2 self-repair and interrupted update recovery
- A published Windows installation with verifiable exeSha256 and guiExeBytes is repaired only when its executable mismatches those expected bytes. The independently hashed current-release installer is staged and reapplied after normal exit. This is a non-destructive repair of packaged program files, not a broad uninstall or deletion of private Studio/.smix, custom VST3 or unknown directories.
- An interrupted install on next startup is reconciled to previous-retained, candidate-unverified or unknown-installation using installed source SHA. The failed release is blocked from endless retries; unknown source fails closed. These states do not certify audio or WebView health.
- Corrupt updater-owned state is quarantined without touching user data. Network failure retries no more than every 20 minutes; successfully fetched release lists are cached six hours. Complete staged transactions are retained across app reopens until the normal-exit update process.
- Cleanup removes only named vendor installer/checksum/provenance files. No recursive stage deletion. Failure of a same-version repair blocks repeated attempts; it does not uninstall or erase a session.
- A mixer executable that cannot start cannot repair itself: independent, publisher-signed bootstrap/recovery remains a required future release gate.

## Bounded automatic error recovery
- A completed Inno installer that exits nonzero but leaves the old source intact gets one more attempt on the next normal app exit, after a 30-minute cooldown. The counter persists in updater metadata; two failures block that candidate. An installer timeout, partial version replacement, failed GUI health, or revoked release does not qualify for this retry.
- Only the old installed app can be relaunched after a non-destructive installer rejection. The updater never uninstalls or resets Studio/.smix to work around device, driver or VST issues.

## Same-version Inno repair FAT
- The Windows Inno fixture creates an isolated artificial installation, intentionally truncates only its synthetic ArSonMix.exe, reruns Inno in unattended auto-update mode, and requires the original SHA-256 executable hash and private Studio sentinel to survive. This proves vendor-program-file repair mechanics; a real JUCE/WebView + ASIO failure scenario still needs a two-version desktop test.

## M3 standalone recovery when the main application cannot launch
- The installed Start Menu includes Repair ArSonMix. This independent action validates the source commit against a published official GitHub Release, verifies the installer source/digest/checksums and installs vendor program files in place, without deleting any private .smix, Studio or user VST. The repaired app then launches and acknowledges GUI readiness.
- Automatic updates still reject an absent EXE. Only an explicitly invoked recovery uses the two no-close flags ARSONMIXAUTOUPDATE and ARSONMIXRECOVERY. An exact-image process probe and file lock checks refuse interruption of a running mixer.
- An abandoned worker mutex may be reclaimed when the prior process crashes. Unknown installed source or absent provenance must fail closed and direct the user to the official installer. No audio callback work, OS service or scheduled task.
- Windows Inno FAT creates a synthetic missing EXE, verifies ordinary auto-update refuses it, then tests explicit recovery restoring identical SHA while retaining private session sentinels. Code-signing and actual JUCE/ASIO end-to-end recovery remain separate release requirements.

## Exact-image install, repair and rollback health
After install/repair/rollback, success requires the installed sourceCommit, exeSha256 and guiExeBytes to agree with on-disk ArSonMix.exe bytes. GUI_READY without matching image identity is insufficient. Deterministic Windows fixture tests reject unchanged source metadata with a tampered binary. Two real published releases exist, but interactive WebView and physical ASIO audio remain separate gates.

## Genuine two-release installer qualification
- Opt-in Windows FAT now downloads two **already-published authentic** installer assets (v0.5.0-alpha.4 / v0.5.0-alpha.5), confirms official GitHub digest, source-commit provenance and SHA256SUMS, installs alpha.4 into a disposable runner directory, upgrades to alpha.5 and rolls back to alpha.4, validating installed PE SHA and private .smix plus install-local user sentinel after every step. It is gated to explicit package_fat dispatch on temporary GitHub Windows runners; ordinary PR/branch work never downloads historical packages. This verifies historical Inno compatibility, not live WebView2-ready startup or physical ASIO sound, which remain separately qualified.

## Rollback asset identity safety
The post-close supervisor rechecks the **previous** published release as well as the **candidate** via GitHub. The staged rollback filename, SHA256, size, tag and original source commit must all agree with current published release metadata before any installer starts. If the published rollback artifact is missing, altered or withdrawn, the update is deferred with the current mixer intact.

## Codex review P1 fixes — release parsing and startup health
- Windows PowerShell 5.1 `Invoke-RestMethod` returns JSON arrays as an array-valued pipeline object; wrapping its result in `@(...)` nests the releases. All three REST fetch sites now assign directly so stable/pre-release discovery, standalone recovery and revocation checks iterate individual releases.
- WebView2 timeout triggers stage 3 only to dismiss the splash and show an error. The GUID-scoped GUI_READY marker now requires **stage == 2**, not the stage>=2 dismissal branch, eliminating success claims for a failed browser.
- An incomplete installer/checksum/provenance download sets `staging-retry` with empty lastCheckUtc before network transfer, preserving the 20-minute retry rather than applying the six-hour successful-check throttle.
73 changes: 73 additions & 0 deletions installer/ArSonMix.iss
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,17 @@ RestartApplications=no
; The shutdown helper is EMBEDDED TEMPORARILY in Setup, never installed.
; It handles installed legacy builds that do not implement the new event.
Source: "ArSonMixUpdateShutdown.ps1"; Flags: dontcopy
; The updater runs outside JUCE, never in the realtime audio callback.
Source: "ArSonMixAutoUpdate.ps1"; DestDir: "{app}"; Flags: ignoreversion
Source: "{#SourceRoot}\verified-gui.exe"; DestDir: "{app}"; DestName: "ArSonMix.exe"; Flags: ignoreversion
Source: "{#SourceRoot}\BUILD_PROVENANCE.json"; DestDir: "{app}"; Flags: ignoreversion
Source: "{#SourceRoot}\README.md"; DestDir: "{app}"; Flags: ignoreversion
Source: "{#SourceRoot}\FactoryFX\*"; DestDir: "{app}\FactoryFX"; Flags: ignoreversion recursesubdirs createallsubdirs skipifsourcedoesntexist
[Icons]
Name: "{autoprograms}\ArSonMix"; Filename: "{app}\ArSonMix.exe"; WorkingDir: "{app}"
; User-facing fallback when the main EXE cannot even open. The helper
; authenticates the published current release and repairs in place.
Name: "{autoprograms}\Repair ArSonMix"; Filename: "{sys}\WindowsPowerShell\v1.0\powershell.exe"; Parameters: "-NoLogo -NoProfile -NonInteractive -ExecutionPolicy Bypass -WindowStyle Hidden -File ""{app}\ArSonMixAutoUpdate.ps1"" -RecoveryMode"; WorkingDir: "{app}"
; Do not create a second copy of an already running mixer. Restart Manager
; preflight closes the prior verified app before [Files]; [Run] launches exactly
; one new executable only after a successful interactive install/update.
Expand Down Expand Up @@ -94,6 +99,34 @@ begin
CloseWinHandle(H);
end;

{ An automatic update must never close a new live-mixing session.
Manual/interactive setup retains the existing graceful-close workflow. }
function IsArSonMixAutoUpdate: Boolean;
var
I: Integer;
begin
Result := False;
for I := 1 to ParamCount do
if CompareText(ParamStr(I), '/ARSONMIXAUTOUPDATE') = 0 then
begin
Result := True;
Exit;
end;
end;

function IsArSonMixRecovery: Boolean;
var
I: Integer;
begin
Result := False;
for I := 1 to ParamCount do
if CompareText(ParamStr(I), '/ARSONMIXRECOVERY') = 0 then
begin
Result := True;
Exit;
end;
end;

function PrepareToInstall(var NeedsRestart: Boolean): String;
var
Target, HelperPath, PowerShellExe, Params: string;
Expand All @@ -102,6 +135,46 @@ var
begin
Result := '';
Target := ExpandConstant('{app}\ArSonMix.exe');
if IsArSonMixAutoUpdate then
begin
{ Never send InstallShutdown, CloseMainWindow or WM_CLOSE in auto mode.
Exact-path ProbeOnly + locked-PE preflight is strictly fail-closed. }
if not FileExists(Target) and not IsArSonMixRecovery then
begin
Result := 'Automatic update requires an existing ArSonMix installation.';
Exit;
end;
{ The recovery flag is allowed only with automatic (no-close) mode.
An absent EXE is permitted, but the same exact-image running-process
probe and exclusive-image checks are still mandatory. }
if CheckForMutexes('Local\ArSonMix.MixerRunning.v1') then
begin
Result := 'ArSonMix is running; automatic update deferred to a later normal exit.';
Exit;
end;
ExtractTemporaryFile('ArSonMixUpdateShutdown.ps1');
HelperPath := ExpandConstant('{tmp}\ArSonMixUpdateShutdown.ps1');
PowerShellExe := ExpandConstant('{sys}\WindowsPowerShell\v1.0\powershell.exe');
Params := '-NoProfile -NonInteractive -ExecutionPolicy Bypass -File ' +
AddQuotes(HelperPath) + ' -TargetPath ' + AddQuotes(Target) +
' -ProbeOnly';
ExitCode := -1;
if not Exec(PowerShellExe, Params, '', SW_HIDE,
ewWaitUntilTerminated, ExitCode) then
begin
Result := 'Unable to verify that no ArSonMix session is active. No files replaced.';
Exit;
end;
if ExitCode <> 0 then
begin
Log('Automatic update refused: active/unknown process, probe exit=' + IntToStr(ExitCode));
Result := 'ArSonMix session is active or cannot be verified. Automatic update deferred; no files replaced.';
Exit;
end;
if not InstalledExeReplaceable(Target) then
Result := 'ArSonMix.exe is occupied; automatic update deferred without closing a live session.';
Exit;
end;
if not FileExists(Target) then
Exit; { first install: there is no existing exe to close }

Expand Down
Loading
Loading