Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ui-smoke.yml
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,8 @@ jobs:
run: python tests/pages_fx_rail_v53_smoke.py
- name: Verify V54 context-aware WIRE and independent FX chain/slot bypass
run: python tests/pages_v54_wire_fx_context_smoke.py
- name: Verify V55 accepted WIRE paint and fader depth
run: python tests/pages_v55_context_wire_fader_smoke.py
- name: Verify original metallic asset and standalone synchronization
run: python tests/fader_asset_test.py
- name: Validate recessed Button 180 + embedded Inter font contract
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# V55 — WIRE socket paint, fader cap depth and native FX handoff

**Reference only; not native PCM.** Baseline `main@1e5a835f6af1125a451c8a9a77cb5556ce0a3152`. V51/V52 meter/fader geometry, V53 FX rack, V54 FX bypass state semantics remain authoritative.

## Implemented GUI
- `data-wire-paint=idle|connected` is projected from **visible accepted** `wireEdges`. This is a rendering state, not an audio route. `data-wire-connected` remains true for a committed but hidden/off-bank wire; only a visible physical wire illuminates its endpoint. No legacy SEND or selected-channel state can pretend a committed wire. Hover/drag/magnetic snap are explicitly transient.
- CH1/CH2 empty receiving IN stays graphite. Default CH→MAIN remains a real graph edge, while physical WIRE dot paint follows only visible tray cables. Focus-hidden routes retain connected semantics with a graphite ring AND graphite dot; replug/focus/Undo refresh the paint without additional per-frame rendering.
- Silver/rose PNG fader cap retains existing dimensions/travel; larger three-layer **static CSS** shadow, no filter, canvas or animation.
- V54 already implements header `fxOn` for whole-channel FX chain, and each `slotBypass[index]` for only its insert. Turning the header OFF must preserve all slot bypass flags and stable `fxInsertIds`. Never introduce duplicate bypass state owners.

## Engine/native GUI connection points
Existing authority: `contracts/console-puzzle-v8.json`, `AGENTS.md`, ENGINE #266, native GUI #271, FAT #270. Use schemaVersion=6 messages `arMixConsoleIntent` -> `arMixConsoleAck` -> `arMixConsoleSnapshot`. Required intent: `requestId`, `deviceEpoch`, `baseGraphRevision`, `baseRosterRevision`, `operation`, `targetChannelId`, `payload`. Only matching same-epoch/revision accepted snapshot paints LIVE; pending/error must not change accepted chain or wire.

| GUI control | Stable target | Proposed installed-operation requirement |
| --- | --- | --- |
| Channel FX header | ChannelId | Whole chain bypass; preserve per-insert bypass, editor, plugin lease and PDC |
| Individual FX power | ChannelId + stable insertId | Toggle **only** that insert, preserve sibling state and chain flag |
| FX drag grip | ChannelId + insertId + target index | Same-channel prepared reorder; reject copy of VST3 by name |
| WIRE node | ChannelId + edgeId | Only accepted `graph.edges[]` may show committed jack; focus/visibility is a projection |
| Fader | ChannelId | Existing bounded realtime gain operation, no graph rebuild |

**Capability gating:** propose names `SET_FX_CHAIN_BYPASS` / `SET_FX_INSERT_BYPASS` only for discussion with the native owners; do NOT advertise these as installed `supportedOps` or send unsupported intents. Native state must be prepared off callback and accepted atomically; callback never allocates, locks, touches UI or loads/unloads VST3. Reference GUI currently fails closed in native mode (`deferNativeFxIntent`) until native owners install the actual operation+ACK+accepted snapshot.

## Gates
Run `python tests/pages_v55_context_wire_fader_smoke.py`, previous V54 FX chain/slot+native fail-closed smoke, full Chromium exact-head CI and visual screenshot review. Preserve V51 meter SHA/geometry; no hardware FAT claim. Wire canonical MAIN implementation is separately owned by Packet A runbook.
## Packet A MAIN compatibility
A fresh channel owns one accepted default CH→MAIN edge, which must never be erased merely to darken its OUT socket. `data-wire-connected=true` can coexist with `data-wire-paint=idle` when the accepted MAIN edge is represented only by the dedicated short MAIN-colored fragments, outside the ordinary CH→CH SVG cable list. CH1/CH2 IN stays graphite with no incoming CH→CH edge. FX intentions must be gated by installed `supportedOps`, never speculatively sent. No second DSP engine or audio callback.
2 changes: 1 addition & 1 deletion site/preview-v2/assets/mixer-fader-assembly.css
Original file line number Diff line number Diff line change
Expand Up @@ -413,6 +413,6 @@
Three STATIC small-area shadows, original silver/rose PNG and no GPU filter,
timers, new DOM nodes or geometry changes. */
.console-body .strip .fader-travel .cap{
box-shadow:0 3px 4px -1px #000e,1px 8px 9px -3px #000c,0 13px 12px -7px #0009!important;
box-shadow:0 4px 6px -1px #000f,2px 10px 13px -3px #000e,0 17px 17px -7px #000b!important;
filter:none!important;
}
20 changes: 20 additions & 0 deletions site/preview-v2/assets/mixer-wire-dots.css
Original file line number Diff line number Diff line change
Expand Up @@ -916,6 +916,26 @@
box-shadow:inset 0 1px 2px #061017!important;opacity:1!important;
}

/* V55: physically painted WIRE endpoints require a displayed accepted edge.
data-wire-connected remains independent graph truth for hidden/off-bank
inspection. Hover, magnet and deliberate patch intent remain transient. */
.console-body.wire-routing-v15 .strip .wire-tray .wire-node-out[data-wire-paint="idle"]:not(.is-source):not(.is-drag-origin):not(.is-near):not(:hover):not(:focus-visible) .wire-pin,
.console-body.wire-routing-v15 .strip .wire-tray .wire-node-in[data-wire-paint="idle"]:not(.is-snap-target):not(.is-replug-origin):not(:hover):not(:focus-visible) .wire-arrow{
background:#4b535b!important;border-color:#657681!important;
box-shadow:inset 0 1px 2px #061017!important;opacity:1!important;
}
.console-body.wire-routing-v15 .strip .wire-tray .wire-node-out[data-wire-paint="connected"]:not(:hover) .wire-pin{
background:var(--wire-edge-color)!important;opacity:var(--wire-edge-opacity,1)!important;
}

/* The receiving bezel itself must agree with its inner dot. A stored edge
hidden by WIRE focus is still connected in graph state but visually dark. */
.console-body.wire-routing-v15 .strip .wire-tray
.wire-node-in[data-wire-paint="idle"]:not(:hover):not(.is-snap-target):not(.is-replug-origin){
border-color:#394a55!important;background:#1b2b35!important;
box-shadow:inset 0 1px 2px #07141c!important;
}

/* WIRE A2: MAIN-color cable stubs. Source and pinned MAIN consume the SAME
data-wire-main-edge identity. Scoped to the existing WIRE CSS owner.
No new layout box, no cross-bank SVG, no hit area or compositor animation. */
Expand Down
11 changes: 7 additions & 4 deletions site/preview-v2/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -267,11 +267,11 @@
<link rel="stylesheet" href="assets/mixer-fx-rack.css?v=fx-owner-v8-m3-inserts-v54-independent-bypass">
<link rel="stylesheet" href="assets/mixer-plugin-browser.css?v=css-plugin-owner-v27-cascade-pruned">
<link rel="stylesheet" href="assets/mixer-pan-controls.css?v=css-owner-v27-pan-pruned">
<link rel="stylesheet" href="assets/mixer-fader-assembly.css?v=css-owner-v27-fader-pruned-v52-recess-v54-raised-shadow">
<link rel="stylesheet" href="assets/mixer-fader-assembly.css?v=css-owner-v27-fader-pruned-v52-recess-v55-depth">
<link rel="stylesheet" href="assets/mixer-meter-display.css?v=css-owner-v27-meter-pruned">
<link rel="stylesheet" href="assets/mixer-utility-controls.css?v=css-owner-v27-utility-pruned">
<link rel="stylesheet" href="assets/inter-embedded.css?v=inter-utility-v7">
<link rel="stylesheet" href="assets/mixer-wire-dots.css?v=v54-graph-socket-context">
<link rel="stylesheet" href="assets/mixer-wire-dots.css?v=v55-accepted-wire-paint">
<link rel="stylesheet" href="assets/mixer-wire-out-align-v48.css?v=out-center-v48">

<link rel="stylesheet" href="assets/mixer-contextual-buttons.css?v=contextual-micro-handoff-v1">
Expand Down Expand Up @@ -762,12 +762,12 @@
hasAnyArrival?'Select one incoming route to inspect':
legacy?'Existing SEND slot · managed in legacy routing':
'Choose OUT then click IN, or drag an OUT jack here';
const from='<button type="button" class="wire-node-out'+(isSource?' is-source':'')+
const from='<button type="button" data-wire-paint="idle" class="wire-node-out'+(isSource?' is-source':'')+
'" data-action="wireSource"'+(isMain?' disabled':'')+
' title="SEND OUT · drag this solid jack to another channel IN" aria-label="Send OUT from '+
escapeHtml(t.name)+'" aria-pressed="'+isSource+
'"><span class="wire-pin" aria-hidden="true"></span><small>OUT</small></button>';
const to='<button type="button" class="wire-socket wire-node-in'+(isSource&&!hasAnyArrival?' is-source':'')+
const to='<button type="button" data-wire-paint="idle" class="wire-socket wire-node-in'+
(linked?' is-linked':'')+'" data-action="wireRoute" aria-pressed="'+sourceLinked+
'" aria-label="Receive IN on '+escapeHtml(t.name)+' · '+label+
'" title="'+escapeHtml(label+' · '+modeLabel+' · GUI DEMO')+'" '+
Expand Down Expand Up @@ -1777,6 +1777,9 @@
else node.removeAttribute('data-wire-arrival');
}
const edge=visible.get(key);
// Visual paint follows the visible committed WIRE path, not a legacy
// SEND or an off-bank hidden connection. Keep graph state separate.
node.dataset.wirePaint=edge?'connected':'idle';
if(!edge){
node.removeAttribute('data-wire-visible');
node.style.removeProperty('--wire-edge-color');
Expand Down
4 changes: 2 additions & 2 deletions tests/pages_v52_fader_recess_smoke.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def audit_checkpoint():
assert "filter:none!important" in css
assert ".console-body .strip .fader-workspace" in css
assert "#263944" in css
assert "1px 8px 9px -3px" in css and "0 13px 12px -7px" in css
assert "0 4px 6px -1px #000f" in css and "2px 10px 13px -3px #000e" in css and "0 17px 17px -7px #000b" in css, "V55 stronger three-layer cap depth must retain original static PNG and zero GPU filters"
assert "linear-gradient(90deg," in css

def inspect(page,width,height,density):
Expand Down Expand Up @@ -72,7 +72,7 @@ def inspect(page,width,height,density):
assert abs(float(v["slotWidth"].replace("px",""))-5)<.6,(width,density,"dark slot drift",v)
assert "rgb(1, 4, 7)" in v["slotBackground"],(
width,density,"center aperture not near-black",v)
assert v["thumbShadow"]!="none" and "9px" in v["thumbShadow"] and "13px" in v["thumbShadow"],(
assert v["thumbShadow"]!="none" and "10px 13px -3px" in v["thumbShadow"] and "17px 17px -7px" in v["thumbShadow"],(
width,density,"visible low-cost lower thumb shadow missing",v)
assert v["thumbFilter"]=="none",(width,density,"GPU filter forbidden",v)
assert v["thumbTransition"]=="0s",(width,density,"animated shadow forbidden",v)
Expand Down
54 changes: 54 additions & 0 deletions tests/pages_v55_context_wire_fader_smoke.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
#!/usr/bin/env python3
"""V55 context-aware physical WIRE dot paint and lightweight thumb shadow."""
from pathlib import Path
from playwright.sync_api import sync_playwright
PAGE=Path(__file__).resolve().parents[1]/"site/preview-v2/index.html"
def node(page,ch,direction):
sel=".wire-node-out" if direction=="out" else ".wire-node-in"
dot=".wire-pin" if direction=="out" else ".wire-arrow"
return page.locator(f'#tracks .strip[data-id="{ch}"] {sel}').evaluate("""(el,dot)=>({
paint:el.dataset.wirePaint,connected:el.getAttribute('data-wire-connected'),
visible:el.getAttribute('data-wire-visible'),
color:getComputedStyle(el.querySelector(dot)).backgroundColor})""",dot)
def main():
with sync_playwright() as pw:
browser=pw.chromium.launch(headless=True)
for w,h in ((1366,768),(1680,900),(1920,1080)):
for density in ("comfort","standard","compact"):
page=browser.new_page(viewport={"width":w,"height":h})
page.goto(PAGE.as_uri())
page.locator("#densitySelect").select_option(density)
for ch in (1,2):
for direction in ("in","out"):
v=node(page,ch,direction)
assert v["paint"]=="idle" and v["visible"] is None,(w,density,ch,direction,v)
if direction=="in": assert v["connected"] is None,(w,density,"phantom receiving wire",ch,v)
else: assert v["connected"]=="true",(w,density,"default MAIN edge missing",ch,v)
assert v["color"]=="rgb(75, 83, 91)",(w,density,ch,direction,v)
cap=page.locator('#tracks .strip[data-id="1"] .fader-travel .cap').first
shadow=cap.evaluate("(el)=>getComputedStyle(el).boxShadow")
assert "17px" in shadow and shadow!="none",(w,density,shadow)
assert cap.evaluate("(el)=>getComputedStyle(el).filter")=="none"
if density=="comfort":
if "collapsed-send" in (page.locator(".console-body").get_attribute("class") or ""):
page.locator('.section-rail [data-section="send"]').click()
page.locator('#tracks .strip[data-id="5"] .wire-node-out').click()
page.locator('#tracks .strip[data-id="3"] .wire-node-in').click()
a=node(page,5,"out");b=node(page,3,"in")
assert a["connected"]=="true" and a["paint"]=="connected",(w,a)
assert b["connected"]=="true" and b["paint"]=="connected",(w,b)
assert node(page,1,"out")["connected"]=="true" and node(page,1,"out")["paint"]=="idle"
page.locator('#tracks .strip[data-id="2"] .strip-identity-top').click()
hidden=node(page,3,"in")
assert hidden["connected"]=="true" and hidden["paint"]=="idle",(w,density,hidden)
assert hidden["color"]=="rgb(75, 83, 91)",(w,density,hidden)
page.locator('#tracks .strip[data-id="3"] .strip-identity-top').click()
assert node(page,3,"in")["paint"]=="connected"
page.locator("#wireNavigatorToggle").click()
page.locator("#wireWsUndo").click()
assert node(page,5,"out")["connected"]=="true" and node(page,5,"out")["paint"]=="idle"
assert node(page,3,"in")["paint"]=="idle"
page.close()
browser.close()
print("PASS V55: dark idle nodes, accepted WIRE paint, undo and static fader shadow 3x3")
if __name__=="__main__":main()
2 changes: 1 addition & 1 deletion tests/pages_wire_dot_v42_smoke.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
from playwright.sync_api import sync_playwright
PAGE=Path(__file__).resolve().parents[1]/"site/preview-v2/index.html"
WIRE_STYLE=PAGE.with_name("assets")/"mixer-wire-dots.css"
assert 'assets/mixer-wire-dots.css?v=v54-graph-socket-context' in PAGE.read_text(encoding="utf-8")
assert 'assets/mixer-wire-dots.css?v=v55-accepted-wire-paint' in PAGE.read_text(encoding="utf-8")
assert 'wire-node-out .wire-pin' in WIRE_STYLE.read_text(encoding="utf-8")
def check(ok,msg): assert ok,msg
def styles(loc):
Expand Down
2 changes: 1 addition & 1 deletion tests/pages_wire_incoming_v43_smoke.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def main():
shared=dst/"preview/assets/mixer-wire-dots.css"
assert public.read_bytes()==CANONICAL.read_bytes(),"Public iframe still uses stale GUI"
assert shared.read_bytes()==WIRE_CSS.read_bytes(),"Public iframe did not publish the effective WIRE CSS"
assert 'assets/mixer-wire-dots.css?v=v54-graph-socket-context' in public.read_text("utf-8")
assert 'assets/mixer-wire-dots.css?v=v55-accepted-wire-paint' in public.read_text("utf-8")
with sync_playwright() as pw:
browser=pw.chromium.launch(headless=True)
for width in (1366,1680):
Expand Down
2 changes: 1 addition & 1 deletion tests/pages_wire_v44_finish_smoke.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def main():
public=dst/"preview/mixer.html"
assert public.read_bytes()==SRC.read_bytes(),"published /preview/ differs from canonical GUI"
assert (dst/"preview/assets/mixer-wire-dots.css").read_bytes()==CSS.read_bytes(),"published WIRE style missing"
assert 'assets/mixer-wire-dots.css?v=v54-graph-socket-context' in public.read_text("utf-8")
assert 'assets/mixer-wire-dots.css?v=v55-accepted-wire-paint' in public.read_text("utf-8")
with sync_playwright() as pw:
browser=pw.chromium.launch(headless=True)
for width in (1366,1680):
Expand Down
7 changes: 5 additions & 2 deletions tests/pages_wire_v45_socket_layout_smoke.py
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ def main():
public=dist/"preview/mixer.html"
assert public.read_bytes()==HTML.read_bytes(),"Pages did not publish canonical V45 console"
assert (dist/"preview/assets/mixer-wire-dots.css").read_bytes()==STYLE.read_bytes(),"Pages lost WIRE CSS"
assert "assets/mixer-wire-dots.css?v=v54-graph-socket-context" in public.read_text("utf-8")
assert "assets/mixer-wire-dots.css?v=v55-accepted-wire-paint" in public.read_text("utf-8")
with sync_playwright() as pw:
browser=pw.chromium.launch(headless=True)
for width in (1366,1680,1920):
Expand Down Expand Up @@ -102,7 +102,10 @@ def main():
assert p.locator('#wireLayer path.wire-outgoing-line[data-from="5"][data-to="3"]').count()==0
hidden=channel_ring(dest)
assert hidden["arrival"]=="true",(width,"committed route lost arrival when filtered",hidden)
assert hidden["border"]==connected["border"] and hidden["background"]==connected["background"],(width,"committed route incorrectly looks unplugged",hidden)
assert hidden["border"]=="rgb(57, 74, 85)" and hidden["background"]=="rgb(27, 43, 53)",(width,"hidden WIRE jack must be graphite while semantic arrival persists",hidden)
p.locator('#tracks .strip[data-id="3"] .strip-identity-top').click()
restored=channel_ring(dest)
assert restored["arrival"]=="true" and restored["border"]==connected["border"] and restored["background"]==connected["background"],(width,"visible accepted cable must relight destination",restored)
# Compact is a spatial fallback, not a different hit-test or route state.
if width==1366:
p.locator('#densitySelect').select_option(label="Compact")
Expand Down
9 changes: 6 additions & 3 deletions tests/pages_wire_v46_precision_smoke.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ def main():
public=dist/"preview/mixer.html"
assert public.read_bytes()==HTML.read_bytes(),"published /preview/ HTML is stale"
assert (dist/"preview/assets/mixer-wire-dots.css").read_bytes()==CSS.read_bytes(),"public WIRE CSS differs"
assert "assets/mixer-wire-dots.css?v=v54-graph-socket-context" in public.read_text("utf-8")
assert "assets/mixer-wire-dots.css?v=v55-accepted-wire-paint" in public.read_text("utf-8")
assert (dist/"preview/assets/mixer-wire-out-align-v48.css").read_bytes()==(ROOT/"site/preview-v2/assets/mixer-wire-out-align-v48.css").read_bytes(), "V48 alignment stylesheet missing from /preview/"
assert "assets/mixer-wire-out-align-v48.css?v=out-center-v48" in public.read_text("utf-8")

Expand Down Expand Up @@ -137,8 +137,11 @@ def main():
# enabled route: socket remains connected while graph is unchanged.
page.locator('#tracks .strip[data-id="2"] .strip-identity-top').click()
idle=incoming_colors(dest)
assert idle["connected"] and idle["ring"]!="rgb(57, 74, 85)",(width,"committed socket was falsely unlit by focus",idle)
assert idle["center"]==idle["ring"],(width,"committed receiving dot must track the ring",idle)
assert idle["connected"],(width,"focus must not remove accepted graph edge",idle)
assert idle["ring"]=="rgb(57, 74, 85)" and idle["center"]=="rgb(75, 83, 91)",(width,"hidden cable must leave both ring and center graphite",idle)
page.locator('#tracks .strip[data-id="3"] .strip-identity-top').click()
lit=incoming_colors(dest)
assert lit["connected"] and lit["center"]==lit["ring"] and lit["center"]!="rgb(75, 83, 91)",(width,"focus return must restore accepted visible endpoint",lit)
if width==1366:
page.locator('#densitySelect').select_option(label="Compact")
exact(center(dest_pin),center(dest),width,"compact socket no longer concentric",.32)
Expand Down
Loading