Skip to content

P0 First Sound: visible native START AUDIO, real post-fader PCM proof and direct-monitor isolation - #257

Merged
masarray merged 8 commits into
mainfrom
fix/p0-mixer-physical-output-truth-start-audio-20261031
Oct 31, 2026
Merged

masarray merged 8 commits into
mainfrom
fix/p0-mixer-physical-output-truth-start-audio-20261031

Conversation

@masarray

Copy link
Copy Markdown
Owner

P0 physical first sound — do not confuse capture, native route ACK, and an audible mixer

Field evidence (5 user screenshots): Windows Audio 48 kHz / 480; MAONO capture and patch CH07 stereo 1/2 is native LIVE ACK but both AUDIO SETUP and SIGNAL CHECK explicitly read OUTPUT SAFE-MUTED. The user hears audio anyway. A muted native hardware MAIN cannot have produced that sound. Possible independent MAONO direct monitoring, Windows Listen/playback, or another output route must be tested; never fake that PCM crossed the mixer just because capture is present.

Concrete fix

  • AUDIO SETUP always-visible path now has four independent roles: RAW CAPTURE, NATIVE ROUTE, post-FADER mixer PCM, hardware MAIN. Post-fader evidence comes only from native dryRoutingLab.channelPeaks scoped to actual patched channels (not raw input or browser demo VUs); MAIN stage uses native peak and ARM gate.
  • The START AUDIO / MUTE OUTPUT button is now at the top alongside real path diagnostics, not hidden below the scrollable DEVICE/DRIVER content. Both the top button and original lower button call the same existing __arMixStartLiveAudio, native route APPLY→ACK→ARM. Both share one startAudioBlocked() guard for pending draft, disconnected/stale physical I/O, endpoint switch and native availability. Emergency MUTE is always allowed.
  • When output is mute, explain that heard sound is NOT evidence of ArSonMix hardware output and guide MAONO direct monitoring / Windows parallel playback isolation. After ARM, instruct operator to mute CH07 or MASTER to prove audibility really follows mixer.
  • Synchronize source-owned web/mixer-io.js and CSS into standalone 858 KB HTML; native/preview parity maintained. Compact CSS, no blur or animations, zero new audio callbacks/workers.
  • Extend UI contract to assert gate, native route token, PCM provenance and no JS DSP.

Acceptance

  • python scripts/build_ui_css.py --check, Chromium UI contract/smoke, existing Windows native CI at exact PR SHA.
  • Physical FAT: explicitly select MAIN L/R to MAONO headphone endpoint and verify the current native device readback (draft endpoint dropdown alone does not change a device). START AUDIO after routing ACK at low headphone level, then CH07 fader to -inf, CH07 MUTE, MASTER MUTE: the monitored sound MUST follow mixer. If not, isolate interface direct monitoring/Windows Listen/alternate route and collect native report.
  • This fixes misleading UI / inaccessible safe ARM action, not automatically a hardware bypass outside the host. No assertion that crackle or hardware routing is fixed without a field test.

Adjacent engine PRs #251 and #256 remain independent.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-31T16:40:30.933159Z 77f2513 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 77f2513c50

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread web/monitor.js
Comment on lines +1843 to +1844
const mixer=!routed?"MIXER · NOT READY":!d.monitor?"MIXER · WAIT ARM":
mixed?"POST-FADER PCM":"POST-FADER SILENT";

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve mixer PCM evidence when only secondary output is armed

When OUTPUT1 is armed while physical output is muted (secondaryOutputArmed=true, monitor=false), this reports MIXER · WAIT ARM even when native channel peaks prove post-fader PCM. LiveOutputRouteGate::evaluate() explicitly permits rendering in this configuration, and LiveAudioEngine.h publishes that PCM to the secondary endpoint before clearing physical outputs. The new diagnostic therefore hides valid mixer evidence and directs an already-playing operator to arm another output unnecessarily. Base the mixer indicator on native PCM/render eligibility independently of physical ARM, and account for the secondary destination in the accompanying guidance.

AGENTS.md reference: AGENTS.md:L30-L30

Useful? React with 👍 / 👎.

@masarray
masarray merged commit 0ed375f into main Oct 31, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant