Skip to content

M3 Studio Console contract: atomic new Bus for selected channels + primary OUT / FX Sends + PRD ARD Handoff v3 - #242

Merged
masarray merged 12 commits into
mainfrom
feat/m3-studio-console-session-contract-20261031
Oct 31, 2026
Merged

masarray merged 12 commits into
mainfrom
feat/m3-studio-console-session-contract-20261031

Conversation

@masarray

@masarray masarray commented Oct 31, 2026 •

Copy link
Copy Markdown
Owner

Meaningful milestone: source + deterministic audio test + canonical product docs

From current main 22e4fdf2843654da0ce526ed67729eedb44d96b7, after M2B #235 and DEVICE4.

Actual C++ (control-thread, not live yet)

  • DynamicChannelRoster::createBusForSelected creates a new stable ChannelId for GROUP (replaces selected sources' exclusive primary OUT with new Bus→MAIN) or FX RETURN (retains primary OUT and adds POST parallel SEND). One validated transaction, rollback if invalid/budget, duplicate selection rejection and stale revision protection. A Bus does not borrow CH10 or physical pin.
  • ChannelEdit::Kind::setPrimaryOutput accepts a target (or NONE), preserving other SENDs; ChannelSendRef.primaryOutput distinguishes destination ownership from parallel sends without making a second renderer. This control API remains compatible with the offline DynamicPreparedMixerBlock.
  • verifyStudioConsoleBusBatchPcm(): genuinely processes two independent Mic PCM buffers through a new Group (different FX callback), and a new FX Return in the same one dynamic prepared graph, proves OUT NONE/SEND ONLY, and stale/duplicate/missing rollback, no audio graph change on rejection.

Durable canonical requirements

Hard boundaries / Next milestone

This PR does not wire new channels into live JUCE, offer clickable +CHANNEL/ADD BUS in Windows, create a second DSP engine, fix CH1 vendor lease, claim Master native VST3 or certify low-latency hardware. M3-live must follow audited LegacyLiveGraphMigration and epoch/revision+MUTE native graph publication, preserve DEVICE4 and #241 capture diagnostics. M4 builds actual right-click multi-select, displayed per-strip IN/OUT/SEND and Bus source popover only after native graph ACK; M5 #15 physical FAT.
Review gates: exact-head Windows MSVC/C++ CTest + verified ZIP, Chromium UI; no more tiny CI-triggering commits except verified fixes. Mark ready / merge only if exact HEAD succeeds.

FINAL M3C safety reconciliation on candidate 39bf682

  • CONTROL-thread selected-channel admission now builds one unordered_map<ChannelId, index> first (O(N+S), not a scan of all N channels for each source).
  • LegacyShow/PCM migration marks old direct-to-MAIN as primaryOutput for both physical CH and AUX return; a later Studio Bus transaction removes that old primary edge (no dangerous doubled dry signal). Explicit monitor/AUX sends remain parallel.
  • Added regression in legacy golden PCM test that migrates an old CH to a new Group and ensures MAIN exclusive primary is removed. Existing sample-by-sample old-vs-new PCM remains intact.
  • CI owner: exact PR head 39bf682afee075b807951bd6862e153026892ff3, Windows native #41204492501. Old branch CI jobs superseded by this final head. No live GUI promise.

@masarray
masarray marked this pull request as ready for review October 31, 2026 14:10
@masarray
masarray merged commit d638fa5 into main Oct 31, 2026
1 check passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-31T14:11:28.046405Z 39bf682 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant