Repository navigation
M3 Studio Console contract: atomic new Bus for selected channels + primary OUT / FX Sends + PRD ARD Handoff v3 - #242
Merged
masarray merged 12 commits intoOct 31, 2026
Conversation
…d primary OUT vs SEND model
…CM, OUT NONE and atomic rollback
…61030.md with authoritative Studio Console v3
…with authoritative Studio Console v3
…1030.md with authoritative Studio Console v3
masarray
marked this pull request as ready for review
October 31, 2026 14:10
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Meaningful milestone: source + deterministic audio test + canonical product docs
From current main
22e4fdf2843654da0ce526ed67729eedb44d96b7, after M2B #235 and DEVICE4.Actual C++ (control-thread, not live yet)
DynamicChannelRoster::createBusForSelectedcreates a new stable ChannelId for GROUP (replaces selected sources' exclusive primary OUT with new Bus→MAIN) or FX RETURN (retains primary OUT and adds POST parallel SEND). One validated transaction, rollback if invalid/budget, duplicate selection rejection and stale revision protection. A Bus does not borrow CH10 or physical pin.ChannelEdit::Kind::setPrimaryOutputaccepts a target (or NONE), preserving other SENDs;ChannelSendRef.primaryOutputdistinguishes destination ownership from parallel sends without making a second renderer. This control API remains compatible with the offlineDynamicPreparedMixerBlock.verifyStudioConsoleBusBatchPcm(): genuinely processes two independent Mic PCM buffers through a new Group (different FX callback), and a new FX Return in the same one dynamic prepared graph, proves OUT NONE/SEND ONLY, and stale/duplicate/missing rollback, no audio graph change on rejection.Durable canonical requirements
Hard boundaries / Next milestone
This PR does not wire new channels into live JUCE, offer clickable +CHANNEL/ADD BUS in Windows, create a second DSP engine, fix CH1 vendor lease, claim Master native VST3 or certify low-latency hardware. M3-live must follow audited
LegacyLiveGraphMigrationand epoch/revision+MUTE native graph publication, preserve DEVICE4 and #241 capture diagnostics. M4 builds actual right-click multi-select, displayed per-strip IN/OUT/SEND and Bus source popover only after native graph ACK; M5 #15 physical FAT.Review gates: exact-head Windows MSVC/C++ CTest + verified ZIP, Chromium UI; no more tiny CI-triggering commits except verified fixes. Mark ready / merge only if exact HEAD succeeds.
FINAL M3C safety reconciliation on candidate 39bf682
unordered_map<ChannelId, index>first (O(N+S), not a scan of all N channels for each source).39bf682afee075b807951bd6862e153026892ff3, Windows native #41204492501. Old branch CI jobs superseded by this final head. No live GUI promise.