Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
4530410
fix(ui): restore mirror-symmetric fader thumb and polish slider UX
masarray Oct 24, 2026
91296db
ci(ui): run Chromium fader geometry and FX workflow smoke tests
masarray Oct 24, 2026
8a3f10e
assets(ui): add supplied rugged silver fader thumb PNG
masarray Oct 24, 2026
fdc8f7e
fix(ui): use original rugged silver PNG thumb, preserve center detent…
masarray Oct 24, 2026
4dc4069
assets: add original metallic red green and silver console switch caps
masarray Oct 25, 2026
c56d23c
feat(ui): original extruded metallic console switches with correct mu…
masarray Oct 25, 2026
06464ea
feat(pages): landing site and automatically deployed live GUI preview…
masarray Oct 25, 2026
3cbf493
test(ui): correct literal image URL regex in PNG parity guard
masarray Oct 25, 2026
48d613e
fix(ui): give master DIM a live tactile switch state in UI prototype
masarray Oct 25, 2026
a9c8005
ci(pages): centralize publisher on main and remove blocked branch dep…
masarray Oct 25, 2026
319ed22
assets(ui): add supplied 18x40 PAN thumb and five 88x36 machined-meta…
masarray Oct 25, 2026
9f24a5b
feat(ui): implement horizontal PAN control and realistic master/navig…
masarray Oct 25, 2026
9471903
test(ui): PAN slider interaction regressions, branding and metallic a…
masarray Oct 25, 2026
2a7ff2d
test(ui): ignore browser-inserted inline text whitespace in ArSonMix …
masarray Oct 25, 2026
a09e0c2
fix(pages): load mixer by deployed SHA on first view to avoid stale c…
masarray Oct 25, 2026
b3523a5
assets: preserve nine original small, long and large mixer button PNGs
masarray Oct 25, 2026
0cb6211
fix(ui): replace global button override with contextual hardware fami…
masarray Oct 25, 2026
b183287
test(ui): validate nine contextual button families and eliminate obso…
masarray Oct 25, 2026
20e8fb4
test(ui): lock per-zone hardware skins, compact geometry, viewport sc…
masarray Oct 25, 2026
5a68fdc
feat(mixer): center-origin PAN illumination, hardware MUTE label, tac…
masarray Oct 25, 2026
d818863
test(gui): PAN light bar, persistent FX power sync, hardware MUTE lab…
masarray Oct 25, 2026
f3cef7a
test(ui): sample tactile hover after transition completes, not on fir…
masarray Oct 25, 2026
e169565
polish(pan): strengthen centered green LED ribbon and subtle nonzero-…
masarray Oct 25, 2026
912fa9c
feat(ui): center-snapped clean PAN, concise FX labels, saved channel …
masarray Oct 25, 2026
9c95aaf
assets(master): add original 31x90 red metallic master fader thumb
masarray Oct 25, 2026
a180540
feat(master): master FX chain, original red fader, stereo peak/clip m…
masarray Oct 25, 2026
2b50322
test(gui): update softer hover targets and verify channel editor, mas…
masarray Oct 25, 2026
f113dda
polish(mixer): active strip focus from top to bottom, retain 25px FX …
masarray Oct 25, 2026
4a7df66
test(gui): inspect Chromium master fader cap visibility and geometry
masarray Oct 25, 2026
6d674a3
fix(master): restore byte-exact supplied FADER-RED2.png and verified …
masarray Oct 25, 2026
3f559bc
polish(master): align red master slider to channel band and test PNG …
masarray Oct 25, 2026
6241f9a
test(gui): verify master/input fader alignment in both Easy and Pro view
masarray Oct 25, 2026
21d4d18
ci(gui): attach Pro View full-frame visual QA to smoke artifacts
masarray Oct 25, 2026
f0f297a
docs(ui): explain channel editor, calibrated-vs-demo metering, master…
masarray Oct 25, 2026
ea2851c
polish(master): match compact FX add-slot icon and caption styling
masarray Oct 25, 2026
e258384
feat(gui): integrate stereo master as thirteenth aligned mixer strip …
masarray Oct 25, 2026
7d48920
test(gui): verify thirteen aligned strips, master PAN, no duplicate c…
masarray Oct 25, 2026
da7fd01
fix(master-pan): preserve master channel identifier during pointer an…
masarray Oct 25, 2026
3a2a9e0
fix(gui): align master fader in EASY and PRO grids and place output m…
masarray Oct 25, 2026
048d021
fix(master): match EASY-mode channel min-content control height exactly
masarray Oct 25, 2026
12f83bf
fix(gui): correct three-pixel PRO-mode master fader alignment
masarray Oct 25, 2026
6caff98
polish(master): replace inert route button with aligned stereo label,…
masarray Oct 25, 2026
05301bb
test(master): enforce one clip action and static output label instead…
masarray Oct 25, 2026
ec88db0
feat(mixer): 6 visible FX slots, compact PAN labels, no-jump fader dr…
masarray Oct 25, 2026
f6fc287
test(mixer): verify six rack slots, L/C/R readouts, master selection,…
masarray Oct 25, 2026
d1a5c00
fix(gui): close fader pointerdown branch after removing unsafe absolu…
masarray Oct 25, 2026
16d0367
fix(layout): compact master PAN and output metering into aligned 94px…
masarray Oct 25, 2026
3814e00
polish(gui): readable dual LUFS-I/dBTP master meter and organized lef…
masarray Oct 25, 2026
343692f
test(gui): verify legible streaming LUFS/dBTP and left-rail snapshot/…
masarray Oct 25, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 46 additions & 0 deletions .github/workflows/ui-smoke.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
name: UI smoke (Chromium)

on:
pull_request:
workflow_dispatch:

permissions:
contents: read

jobs:
frontend:
name: Standalone UI and geometry
runs-on: ubuntu-latest
timeout-minutes: 20
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: "3.12"
- name: Validate JavaScript syntax
run: node --check web/app.js
- name: Install Chromium testing dependencies
run: |
python -m pip install --upgrade pip
python -m pip install playwright
python -m playwright install --with-deps chromium
- name: Verify original metallic asset and standalone synchronization
run: python tests/fader_asset_test.py
- name: Check switch PNG assets and offline HTML sync
run: python tests/button_asset_test.py
- name: Check PAN and button PNG assets
run: python tests/pan_button_asset_test.py
- name: Run mixer UI smoke tests
run: python tests/ui_smoke.py
- name: Attach visual regression screenshot
if: always()
uses: actions/upload-artifact@v4
with:
name: ar-mix-fader-smoke
path: |
fader-ui-smoke.png
mixer-design-review.png
mixer-design-review-1440.png
mixer-master-clip-review.png
mixer-pro-view-review.png
if-no-files-found: ignore
963 changes: 909 additions & 54 deletions AR-MIX-Live-FX-Host-Standalone-v0.3.html

Large diffs are not rendered by default.

45 changes: 45 additions & 0 deletions docs/GITHUB_PAGES_PREVIEW.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
# GitHub Pages GUI preview — production workflow

**Live and deployed** (GitHub Actions run [40147158731](https://github.com/masarray/arsonmix/actions/runs/40147158731)):

- Landing: https://masarray.github.io/arsonmix/
- Interactive mixer review: https://masarray.github.io/arsonmix/preview/
- Full-screen standalone mixer: https://masarray.github.io/arsonmix/preview/mixer.html
- Current served GUI revision: https://masarray.github.io/arsonmix/preview/build.json

## Architecture: safe GUI mirror without merging PR

**The publishing workflow lives in the default branch:** `.github/workflows/pages-publish.yml` in `main`.

The workflow **checks out `fix/fader-thumb-symmetry-polish`** to build the site, so GitHub Pages environment controls are satisfied without merging unapproved UI code into `main`.

Whenever UI smoke CI passes for the preview branch, `workflow_run` on `main` automatically triggers production Pages deployment. You may also use **Actions → Publish ArSonMix GUI (main dispatcher) → Run workflow** for manual republishing, running the workflow on **main**.

The prior branch-local `.github/workflows/pages-preview.yml` was removed because the `github-pages` environment blocked deployment from a non-default-branch workflow (build/upload succeeded but the deployment job could not start). Do not reintroduce a competing branch publisher.

## Build parity

`scripts/build_pages.py` copies:
- `site/index.html` → site landing;
- `site/preview/index.html` → review shell;
- `AR-MIX-Live-FX-Host-Standalone-v0.3.html` → `preview/mixer.html`;
- `preview/build.json` → deployed GUI git SHA + source branch.

The preview shell checks `build.json` every 60 seconds and reloads automatically if a new build is available **and the user is idle**. Otherwise, it displays a reload notice. Click **Reload GUI** to force a refresh; **Full Screen** opens the mixer independently.

## Local validation

```bash
python tests/button_asset_test.py
python tests/fader_asset_test.py
python scripts/build_pages.py --out dist-pages
python -m http.server 8000 --directory dist-pages
```

Then open `http://localhost:8000/` and `http://localhost:8000/preview/`.

The browser version is a **GUI prototype** with simulated meters; it does not capture/process real audio. Real engine work is separate.

## Future promotion

After final GUI visual approval and merge to `main`, update the checkout ref and trigger branch settings in `.github/workflows/pages-publish.yml` to publish from `main` instead. This is intentionally not done until GUI changes are approved.
54 changes: 54 additions & 0 deletions docs/PAN_AND_BUTTON_UX.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
# ArSonMix – Horizontal PAN and unified tactile controls

## Design and engineering change (2026-10-25)
- 12 channel PAN knobs replaced with short horizontal rails. Supplied `PAN-SLIDER.png` (18×40 px) is used unchanged, black recessed rail and center mark rendered below it. Existing channel `pan` session property (−100 to 100) and `send('pan', ...)` protocol are unchanged.
- PAN pointer-dragging from the thumb is relative and never jumps on press. Clicking an empty part of the track moves to the requested position. Double click resets to center without opening the channel editor. Keyboard: left/right 1%, shift 10%, Page ±10%, Home C, End R100; wheel 2%.
- Five user-supplied 88×36 machined-metal PNGs are checked into `web/assets/buttons/` unchanged. Matching data URIs are embedded in CSS for offline one-file WebView2 and browser Pages parity. OFF is the neutral baseline; blue=selected navigation/action; turquoise=selected section/output; pink=streaming/talkback/presets; red=record output. Existing channel MUTE/SOLO/HPF physical buttons retain earlier 54×37 artwork.
- Covered: top navigation (MIX, FX RACK, SIGNAL FLOW, SETUP), left/right segment tabs (CHANNELS, FX CHAINS, MASTER, MONITORS, TALKBACK), output selection (Main L/R etc.), scene/snapshot controls, preset controls, FX inserts, plugin categories and selected miscellaneous actions.
- Product name now **ArSonMix** in mixer header/footer, browser title, landing page and preview shell. Internal engineering project code and historical repository filenames are preserved.
- `tests/pan_button_asset_test.py` verifies original PNG dimensions/bytes and offline CSS/JS parity; `tests/ui_smoke.py` verifies PAN pointer/keyboard/center behavior and button backgrounds. Do not merge if Chromium smoke fails.
- The preview is visual UI only; no live device signal routing or audio processing is implied.

## 2026-10-25 — Context-aware physical-button refinement

**Root cause:** two appended CSS blocks applied 54x37 and 88x36 PNGs to unrelated elements using a broad `:is()` selector, stretching the hardware artwork and inflating the FX rack and small toggle controls.

**Fix:** delete those blanket overrides, restore original slim recessed FX inserts and compact icon controls, retain 18x40 PAN slider and existing 31x90 metal faders. New families are applied **per functional region**, and the original button images are checked in under `web/assets/buttons/`:

| GUI region | Correct art | State |
| --- | --- | --- |
| Dense channel strip MUTE/SOLO/HPF/phase/A-B | SO-S-*.png (49x37) | silver off, red mute, yellow solo, green HPF, blue phase/routing |
| Top navigation + left/right tabs + output destinations | SO-M-BTN-*.png (88x36) | neutral off, blue current view, turquoise selected section/output, red selected record, pink selected streaming |
| Sidebar quick sound presets | SO-L-BTN-*.png (192x36) | dark off, turquoise active |
| Talkback large action | SO-B-BTN-*.png (88x56) | dark off, blue selected |
| FX insert rack | Existing original recessed CSS | No button art; maintain compact signal-chain presentation |
| Tool icons and plugin category controls | Existing original UI | No global material overlay |
| Master identity plate | Existing dedicated plaque styling | Not a button |

All skins are data-URI embedded from **byte-identical original PNG assets**, so standalone WebView2 and GitHub Pages share one rendering path. No JavaScript audio routing changes.

**QA:** `tests/button_asset_test.py` checks all nine new families, image sizes/byte integrity and absence of the obsolete global override. `tests/ui_smoke.py` now verifies that four families remain different, FX slots and tool icons do not accidentally inherit large button images, strip switches do not overflow, and review screenshots are captured at 1680x920 and 1440x820. The visual regression artifacts are attached to successful CI runs.

## 2026-10-25 — Soundcraft reference / Studio One style insert-power refinement

- **PAN**: added center-origin illuminated green/cyan ribbon between center tick and metallic PAN thumb, positive and negative pan; zero is empty, fully pan is fully illuminated. Existing pan range, no-jump drag and keyboard behavior remain.
- **Master MUTE**: fixed physical printed label `MUTE` regardless of state; red artwork + pressed state mean muted. ARIA pressed persists.
- **FX insert**: occupied rows now have separate **FX name/edit target** and **⏻ power target**. Button never opens browser, and opening name never changes bypass. Gray power = bypassed, luminous aqua = on. No power for empty slot. Existing chain bypass mechanism is the single state; it syncs main strips and full FX Rack, sends existing `chainBypass` bridge event, and immediately persists the UI/session state. This is a demo: audio DSP bypass still requires the native host to consume this event.
- **Persistence**: initial restored session now also restores `bypassed`, `fxParams`, and `masterMute`.
- **Tactile feedback**: increased hover brightness/contrast for hardware controls; darker active press. The 31×90 original fader image, exact translation/geometry, and hit zone remain unchanged.
- **Geometry & regression guard**: Chromium checks pan bar left/right/center, 60 compact 25px rack slots, two independent FX targets, synchronized bypass, unchanged MUTE caption and visible hover feedback.
- **Audit priorities**: use color only for meaningful state, keep signal-chain names legible at 1440px, isolate native DSP functions from preview simulation, and prevent per-strip overflow rather than scaling all buttons globally.

## October 25, 2026 — Studio One-inspired channel/master metering and channel identity

- PAN: removed neon glow from metallic thumb and green direction ribbon. Pointer interaction snaps to the center when the requested value is within ±6 units; keyboard retains fine one-unit increments. PAN is still -100..+100 and double-click centers.
- Fader/button hover: reduced previous exaggerated contrast and brightness, keeping recognizably physical pressed states.
- Insert rack: removed occupied slot `◉` graphic entirely; empty slots have one `+` glyph and caption `ADD FX` (no repeated plus).
- Channel identity: clicking the bottom colored identity plate opens a compact console-themed editor: channel name (26 characters maximum), twelve icon choices, twelve semantic strip colors. Identity is saved in UI session and snapshots and restored on reload. Values are escaped/whitelisted; cancelling discards changes.
- Focused channel: border follows selected or interacted-with strip from channel header to bottom plate without changing fader geometry.
- Input meters: industrial tick marks, red peak hold line (1.6 s), 8px raised hardware-style clip candy LED with latched red state and per-channel click-to-clear.
- Master strip: own 5-slot UI FX chain (4 visible in Easy), dedicated enable/bypass buttons, dual L/R meters each with individual clip and peak, all-clip reset, exact original FADER-RED2.png (31×90), and output telemetry. Master fader's start is vertically aligned to input faders in both Easy/Pro UI modes.
- Engineering integrity: source red master PNG git blob SHA `2369e1b9002522600948909246918e57880da1ed` is checked in. A previous one-character base64 corruption caused the image to be invisible; tests now verify byte-exact embedding and `Image.decode()` of 31×90 in Chromium.
- The preview's `LUFS-I`, `dBTP`, and `PEAK` displays are visibly marked `SIM`/`DEMO · NOT CALIBRATED`. They are **not** real BS.1770 LUFS or oversampled true-peak measurements; those must be sourced from DSP/native audio metering before the product claims compliance.
- Browser FX power (including master) is a GUI state/bridge event only; real VST3 bypass requires the native host to consume and apply the changes safely at audio-buffer boundaries.
- QA: 12 input strips, 13 faders total, dual master meters, 14 clip LEDs, original master PNG decode, channel rename/icon/color persistence, FX bypass, no layout overflow at 1680×920 and 1440×820, plus aligned Easy/Pro fader-start geometry.
12 changes: 12 additions & 0 deletions docs/TACTILE_BUTTONS.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# Physical console button artwork

Original assets:
- `web/assets/buttons/SO-M-SLV.png`: inactive/neutral silver
- `web/assets/buttons/SO-M-RED.png`: MUTE active and MASTER MUTE active
- `web/assets/buttons/SO-M-GRE.png`: SOLO active, HPF/Ø enabled and A/B routing enabled

The image contains the bevel and edge shadow; CSS provides live label text, keyboard focus, pointer hover, pressed position and reduced-motion support. All assets are 54×37 RGBA. They are embedded in `web/styles.css` as byte-identical data URLs so the one-file HTML trial and the JUCE/WebView2 binary need no network or external asset dependencies.

The supplied `OFF-ON.png` / `OFF-OFF.png` images have the text OFF baked into the image and **are not used for controls whose ON state needs to be legible**, to avoid misleading users. They can be treated as style references.

Default dark-silver = up; stateful red/green = depressed by 1px; pointer press depresses 3px. Do not simulate depth with chunky cards or CSS-only candy gradients.
17 changes: 17 additions & 0 deletions docs/UI_AUDIT_AND_QA_v0.3.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,20 @@
**Not yet verified:** Windows 125/150% display scaling; native WebView2 shell compilation; real VST3 scan; FX plugin state persistence; real audio capture/output; buffer underrun / callback budgets / device RTL; production memory leak analysis. Treat these as explicit release gates rather than claimed capabilities.

- Responsive QA: at 1366×768, 1920×1080, 2560×1440, measured 12 strips, **zero fader head geometry clips** and **zero JavaScript page errors**. Screenshots were inspected.

## 2026-10-25: Mirror-symmetric fader polish

- Root cause: original 45px head used a fixed 19px centerline. An overriding 39px height and biased shadow left the cap unbalanced, while an obsolete travel calculation remained.
- Repair: single 29×42px metallic head, matching 5px top/bottom corners and centered black stripe; the lower grip is a true Y-mirror of the upper grip. Same CSS for channel and master.
- Keep the cross-browser 25px safe-travel clamp. Add subtle hover and keyboard focus highlights; remove contradictory height/position declarations.
- UX: vertical ARIA sliders, live master value, 0.5dB arrow steps, 5dB Page steps, Home (-60dB) and End (+10dB).
- Automated Playwright smoke includes cap dimension, pseudo-layer symmetry, boundary clipping at initial positions, keyboard endpoints and existing FX workflows. Only the standalone component has been visually rendered in Linux Chromium during this patch; run the complete smoke suite before release.

## 2026-10-25 — Image-backed rugged silver fader (supersedes flat CSS v0.3)

- **Canonical reference:** `web/assets/fader-silver2.png` (user-supplied Gambar 3, 31×90 RGBA, SHA-256 `0f45fe5aebc8db7b65c4163ffad083cbe3965d59cde7056add94812ac067a899`).
- The original PNG preserves curved machined-metal edge shading, fine ridges and soft downcast shadow. The embedded CSS data URI uses exactly the same PNG so **standalone HTML, normal browser CSS and JUCE WebView2 never depend on external file loading**; the canonical PNG remains replaceable.
- On-image black horizontal center mark is **pixel y=35**, CSS `translateY(-35px)` pins that mark to the fader dB coordinate. The body ends near y=65; the transparent falloff continues below without changing the controlled value. Keep the visual clipping assertions limited to the actual metal body (not its cast shadow).
- Pointer-down on an existing cap now retains the current gain; drag is relative to the starting value. Track click still jumps as before. Keyboard and ARIA controls retained.
- QA: `python tests/fader_asset_test.py` checks byte-exact PNG, CSS and offline trial synchronization. Chromium `tests/ui_smoke.py` covers asset decode, all 13 cap dimensions, body clipping, no-jump drag, keyboard endpoints, plugin rack operations and screenshot artifact.
- **Known:** Original user asset is only 31px wide. It is deliberately shown at approximately original pixel dimensions, not artificially upscaled. Replacing the original source with a high-DPI recreation may be considered later if 150%/200% scaling reveals softness.
22 changes: 22 additions & 0 deletions scripts/build_pages.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
"""Build public Pages landing and interactive console from canonical standalone HTML."""
from pathlib import Path
import argparse,os,json,shutil,subprocess
ROOT=Path(__file__).resolve().parents[1]
p=argparse.ArgumentParser()
p.add_argument('--out',default='dist-pages')
p.add_argument('--sha',default=os.environ.get('GITHUB_SHA','local'))
p.add_argument('--branch',default=os.environ.get('GITHUB_REF_NAME','local'))
args=p.parse_args()
dst=Path(args.out).resolve()
if dst==ROOT or dst==ROOT/'site': raise SystemExit('unsafe output path')
dst.mkdir(parents=True,exist_ok=True)
shutil.copytree(ROOT/'site',dst,dirs_exist_ok=True)
source=ROOT/'AR-MIX-Live-FX-Host-Standalone-v0.3.html'
html=source.read_text(encoding='utf-8')
assert '<style>' in html and '<script>' in html and 'data-fader' in html
(dst/'preview').mkdir(exist_ok=True)
(dst/'preview'/'mixer.html').write_text(html,encoding='utf-8')
(dst/'preview'/'build.json').write_text(json.dumps({'sha':args.sha,'branch':args.branch,'source':source.name},indent=2),encoding='utf-8')
(dst/'.nojekyll').touch()
assert (dst/'index.html').exists() and (dst/'preview'/'index.html').exists()
print('Built GitHub Pages:',dst,'preview source:',source,'revision:',args.sha)
Empty file added site/.nojekyll
Empty file.
Loading
Loading