Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/p1-windows.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Windows Native VST3 Host
on:
push:
branches: [ main, feature/p1-first-sound-windows, feature/p2-native-vst-catalog-fx-rack, feature/p2-daw-workflow-progress, fix/p2-native-output-monitor-diagnostics, fix/p2-realtime-glitch-telemetry-latest-gui, fix/p2-truthful-meter-pan-fx-toggle, feature/p2-native-state-presets, fix/p2-fabfilter-add-workflow ]
branches: [ main, feature/p1-first-sound-windows, feature/p2-native-vst-catalog-fx-rack, feature/p2-daw-workflow-progress, fix/p2-native-output-monitor-diagnostics, fix/p2-realtime-glitch-telemetry-latest-gui, fix/p2-truthful-meter-pan-fx-toggle, feature/p2-native-state-presets, fix/p2-fabfilter-add-workflow, feature/p25-live-preset-graph-swap ]
pull_request:
workflow_dispatch:

Expand Down Expand Up @@ -36,6 +36,7 @@ jobs:
node --test tests/native_ui_contract_test.mjs
node --test tests/native_preset_contract_test.mjs
node --test tests/fx_add_contract_test.mjs
node --test tests/live_graph_contract_test.mjs
- name: Configure Windows x64
shell: pwsh
run: >
Expand All @@ -55,13 +56,13 @@ jobs:
Where-Object { $_.Name -like "*AR*Mix*" -and $_.FullName -match 'Release' } |
Select-Object -First 1
if (-not $exe) { throw "ARMixConsole EXE not found" }
Copy-Item $exe.FullName "dist/ArSonMix-P2-FX-Compatibility.exe"
Copy-Item $exe.FullName "dist/ArSonMix-P2.5-Live-Recall.exe"
Copy-Item README.md "dist/README.md"
"P2 experimental: audio routes automatically; use headphones at low level. Only Channel 1 is native. Other strips are inactive previews." |
Out-File -FilePath dist/FIRST_SOUND_README.txt -Encoding utf8
- uses: actions/upload-artifact@v4
with:
name: ArSonMix-P2-FX-Compatibility-Windows-x64
name: ArSonMix-P2.5-Live-Recall-Windows-x64
path: dist/
if-no-files-found: error
retention-days: 14
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ juce_add_gui_app(ARMixConsole
juce_add_binary_data(ARMixAssets SOURCES
web/index.html web/styles.css web/app.js web/bridge.js web/monitor.js)

target_sources(ARMixConsole PRIVATE src/Main.cpp src/LiveAudioEngine.h src/PluginCatalog.h src/DiagnosticsRecorder.h src/StereoPan.h src/NativePresetArchive.h src/VstBusLayout.h)
target_sources(ARMixConsole PRIVATE src/Main.cpp src/LiveAudioEngine.h src/PluginCatalog.h src/DiagnosticsRecorder.h src/StereoPan.h src/NativePresetArchive.h src/VstBusLayout.h src/LiveGraphHandoff.h)
target_compile_definitions(ARMixConsole PRIVATE
JUCE_WEB_BROWSER=1
JUCE_USE_WIN_WEBVIEW2=1
Expand Down
6 changes: 6 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -80,3 +80,9 @@ Use MIX → Channel 1 ADD FX to select a real indexed VST3; PLUGINS opens Plugin
- Each VST3 insert in the MIX view has a small ⏻ toggle with clear ON/OFF state. Bypass updates the atomic realtime control without rebuilding the plugin graph or leaving the MIX screen.
- Diagnostic health JSON no longer truncates every record at 511 characters; the bounded queue slot is now 4096 bytes, with a truncation counter.
- Windows CI validates the native UI contract and real DSP pan coefficient tests. Hardware verification remains necessary.

## P2.5.1 — Live preset prepared graph

- Pre-stage plugin binary state before live recall, publish graph at audio callback boundary, retire old graph only after callback acknowledges; de-click buffer fades.
- Does not require MUTE OUTPUT for recall; SAVE still muted-only. Old ADD/REMOVE/REORDER remains callback-detach and should not be used during performance.
- See [P2.5 live recall notes](docs/P25_LIVE_GRAPH_HANDOFF.md). This is not a full seamless dual-DSP crossfade.
32 changes: 32 additions & 0 deletions docs/P25_LIVE_GRAPH_HANDOFF.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
# P2.5.1 — Live Preset Graph Handoff (ARD P2 safe-recall foundation)

## Product goal
Previous P2.4 recall required MUTE OUTPUT and called JUCE removeAudioCallback/addAudioCallback around graph changes. This interrupted the hardware path.

## Implemented
- The existing Add FX FabFilter/RX compatibility and P2.4 .armix ZIP format remain unchanged.
- Preset recall validates every archive entry, recreates all VST3 processor instances, restores each vendor binary state, and prepares DSP outside the realtime callback while the old graph continues to process audio.
- A bounded **one-slot publication** object exposes an immutable prepared Graph pointer at a buffer boundary. RT thread does no plugin creation, graph copying, mutex locking, dynamic allocation, or third-party destruction during handoff.
- In the last old callback the output gain ramps downward over one buffer; new graph is activated at callback boundary. In the first new callback output ramps upward. No double-DSP old/new crossfade occurs: avoids worst-case CPU doubling with expensive RX/FabFilter processors.
- Audio callback publishes the retired pointer. JUCE message timer takes acknowledgment and destroys old plugin instances only after old callback is finished, then announces successful recall to UI and updates Channel 1/FX Rack controls.
- Snapshot fader/PAN/mute/master settings and VST3 latency are updated at graph transition. Hardware input/output device is untouched.
- New stress test executes 12,000 cross-thread graph handoffs and validates no early reclamation, no second pending graph and expected fade endpoints.
- Counters `completedGraphSwaps` and `graphSwitchPending` are added to status and 1-Hz diagnostics.

## Precisely what is NOT complete
- This is **buffer-boundary declick switching** with a roughly two-buffer gain dip, not genuinely seamless dual-run or delay-compensated crossfade. Effect tails do not persist through graph replacement.
- Add/Remove/Reorder FX still detach the callback and can cause a brief glitch; graph structural edits need separate migration.
- Plugin preparation and ZIP reading remain synchronous on the message thread, so UI may freeze temporarily although audio callback remains independent. Next phase must stage on background worker, coordinate JUCE plugin threading requirements and deal with plugin state APIs that require message-thread affinity.
- Simultaneous audio device change while a graph is pending should be avoided until device-lifecycle cancellation is implemented.
- Plugin compatibility and xrun telemetry must be verified with real FabFilter, iZotope RX and ASIO hardware before declaring live-ready.

## Windows physical acceptance
1. Load FabFilter (e.g., Pro-Q) and iZotope RX, confirm both work; save as `Chain A` (P2.4 save still requires output muted). Repeat with a second preset `Chain B` containing a different sound.
2. Unmute output and play continuous signal. Open MY SOUNDS and RECALL LIVE alternating presets while listening on headphones.
3. Check graph count increases in SIGNAL CHECK diagnostic status; ensure the audio device never restarts, current and new plugin editors open correctly, and saved vendor states restore.
4. Compare interrupted signal length and xrun timing with old P2.4 and review AUDIO_HEALTH after 2 minutes. Avoid device changes during recall.
5. On any stuck load or stream loss, share `audio-diagnostics.log` and stop using the experimental release for a real broadcast.

## Release gates
- Windows x64 MSVC, JS contract, CTest stress all green.
- Physical 30+ minute soak and plugin-specific AB listening (FabFilter, RX, ArSonKuPik) still required. Draft PR only.
Loading
Loading