Skip to content

[GUI P1][FX/RAIL] FX header as unified processor chassis, grip-before-delete, safe reorder and coherent section navigation rail #361

Closed

Description

@masarray

Reconciled 2026-11-08 — GUI/implementation scope completed. GUI FX rack/rail milestone has merged source-level replacements: approved rack interaction composer, native pointer move/remove + lease/readback tests, and restored contextual plugin controls (merged #439 and #458 among later main changes). Maintain any real hardware/VST3 lifetime regressions under #192/#412 and current native test acceptance, not this historical GUI-only issue.

Current main at audit: c57720ea25585c861af89802e1365ffef7d03d17. No statement of physical hardware FAT.


GUI UX — FX INSERT RACK + LEFT SECTION RAIL REFINEMENT (2026-11-04)

Parent execution / single progress authority: #351. Native FX safety / stable insert identity: #95 (closed architectural reference), #266, #271, #270, #15. Existing Chrome ownership: #37, latest merged #355 / #358 / #359. DO NOT duplicate V49 #352 or fader V52 #360.

Scope and verified baseline

Source inspected on main@2f01022370c589205d738366242d2d2aeb77b10d, current GUI reference site/preview-v2/index.html, owner CSS site/preview-v2/assets/mixer-fx-rack.css and existing section/Chrome owner(s). This audit is NOT implemented/visually passed. Source architecture is verified; current rendered screenshot requires fresh PR-head Playwright screenshots.

  1. sectionFx(t) renders <div class="section fx-section"><div class="subhead">... then <div class="fxslot-list">. Existing .subhead chrome uses #112530; rows use #182c37 / hover #294453; rack background uses var(--v13-insert); no cohesive physical header/body frame. Visually, FX plate and inserted processors read like disjoint neighboring strips, not a rack module.
  2. In occupied row, DOM order is power → plugin picker → REMOVE button → <span class="grip" aria-hidden="true">. Owner explicitly requires grip immediately BEFORE REMOVE.
  3. draggable=(name!=="None") is on the entire row, not just the handle, and dragstart blindly matches .fxslot-row; clicking/dragging near plugin label/power/remove can initiate unintended reorder. Handle is non-focusable and hidden from accessibility tree. Native-safe stable identity/rollback not demonstrated by reference UI.
  4. Cross-channel drop logic uses t.fx[to]=source.fx[from] and t.slotBypass[to]=source.slotBypass[from]; it does NOT carry vendor VST3 instance state / parameter blob / lease / latency / stable insertId. Do not represent this mock operation as native-safe FX copy.
  5. Left .section-rail is a mixture of legacy cells, rail-cell[data-section] and later specificity/important overrides; at least identity, route, FX, send, PAN, M/S/C, fader have visually heterogeneous surfaces. Several controls stretch to match section height, requiring fixed icon center instead of stretching art/padding. New hardware BTN material is already consolidated into existing owner; reuse it rather than adding late override tails.

Global design research (functional patterns, not visual copying)

Product decision / visual contract

A. True self-contained FX rack module (one cohesive geometry owner)

  • .fx-section is the containing physical inset chassis. Header .fx-section > .subhead must look like an attached raised/brushed graphite plate immediately above dark recessed .fxslot-list: same left/right boundaries, continuous edge/seam, consistent optical x-axis, no detached-card treatment, minimal radius (0–2px), restrained 1px upper hairline + bottom lip, no large drop shadows/neon/blur. Do not duplicate the global chassis rule or create new stylesheet.
  • Header left: small fx symbol + FX N label aligned with insert text lane. Header right: existing master FX bypass button, visually and semantically integrated. Separate HEADER from BODY using lightness/height/edge not font bloat; avoid flooding panel with color. All tracks including pinned Master share one rack template.
  • Body: rows read top-to-bottom processing order; subtle inset well and 1px row dividers, active vs bypassed vs empty visually distinct and legible; clear + Add FX affordance; high contrast for actual plugin name; no gain/fader shifts. Preserve existing actual row/count and fader travel at 1366×768.
  • Shared column alignment: power placeholder (for empty), name, grip, REMOVE. grip consistently occupies slot immediately to the LEFT of delete, never after. Cross-channel comparison shows aligned buttons.

B. Precise FX reorder (not dangerous row-wide drag)

  • Dedicated semantic grip control instead of span aria-hidden; only grip starts drag; native plugin-open, bypass, remove, and empty row are never draggable. Drag grip occupies compact visual width (~14–18px) but allows adequate effective hit area without overlap; cursor grab/grabbing, focus-visible, keyboard alternative (e.g. Alt+ArrowUp/Down or per-handle accessible action), and accurate aria label Move insert N.
  • Preview: ghost + thin insertion-line target, never a large illuminated whole row. Cancel on ESC/pointercancel/invalid drop without mutations. No real host/VST load during pointermove; one commit after valid drop. Preserve plugin identity, bypass, params, editor, PDC and local state on same-channel reorder; no duplication. For reference model, choose stable insertId binding or explicitly fence mock/native semantics. Disable cross-channel copy if no full-state transaction exists, rather than silently copy name and bypass only.
  • When native bridge is used: moveInsert(channelId,insertId,targetIndex,expectedGraphRevision,requestId,deviceEpoch) prepared outside audio callback, with accepted ACK before committing visual LIVE order; reject stale revisions and rollback. Never move native instance on audio thread, never create a second callback.

C. Unified left vertical rail hardware style

  • One continuous navigation spine visually attached to channel grid; same graphite/brushed tokens and edge lighting as console, not isolated square blocks. Section segmentation at exact neighboring strip row boundaries. Reserve icon in a small centered stable aperture (not scaled with variable-height section); consistent icon weight ~14–16px and visual color.
  • Expanded section: restrained 2px accent edge + subtle active light; collapsed: darker graphite + unlit edge; hover, focus-visible and disabled semantic palette; no persistent full-bright block fills. Identity CH and fader fixed labels stay informational, route/fx/wire buttons remain operable. Avoid excessive saturated blue, rotating large labels, bulky cards.
  • Must not change row heights/collapse ownership; all sidebar aria-expanded values and keyboard focus are accurate, click section toggles correctly. Left seam should align with sections of all strips, including pinned Master.

Execution sequencing (one meaningful GUI milestone)

  1. Freeze latest main and active styling authority / inspect GUI V52 — refined recessed fader well, consistent gain ruler surface and visible low-cost thumb shadow #360 owner for fader collision; FX owner only and existing rail/chrome owner per file. Avoid V49 shared inline JS changes until reconciled; use a new, narrowly scoped branch if needed.
  2. Change sectionFx markup order, dedicated grip ownership + safe drag/keyboard handling. Add a clear native/mock boundary. Test drag reorder/cancel/Undo, source-target, bypass/power, delete, add, cross-track guard, keyboard.
  3. Tune FX header ↔ rack unified surfaces in mixer-fx-rack.css (and only the established rail/Chrome owner) with shared tokens; measure boundaries and snapshot on 1366×768, 1378×911, 1680×900, 1920×1080 × Comfort/Standard/Compact; regular channel, stereo and pinned Master; expanded/collapsed. No new CSS owner cascade layers/abundant !important.
  4. Run exact-head focused tests, then existing full Chromium UI, Firefox visual interaction if supported and release Pages generated-asset parity. Review actual screenshots. Merge only when current baseline preserved and CI GREEN; no native/audio release claims.

Acceptance checklist

  • For each used FX row, grip.right <= remove.left; grip to the left of fx-remove, no collisions at min width/density, +Add FX still aligned.
  • Dragging on FX name/power/delete does NOT start reorder; only grip does; keyboard alternative; no accidental plugin delete or edit.
  • Same-channel reorder modifies chain exactly once, retains plugin instance state in the real host (reference demo visibly marked); invalid/released outside fully cancels. Cross-channel full-state transfer either proven or refused.
  • Header visually reads as top plate of one inset FX module; shared continuous x edges, controls vertically aligned, rack rows recessed below without bulky cards; FX count/power legible.
  • Rail is one continuous matched metal control spine, no icon stretch, icon alignment + hover/active/focus and collapsed state clearly distinguishable; doesn't shift signal strips, fader, meter, wire socket or scroll areas.
  • No regressions in FX add/open/remove/bypass, section collapse, fader/LED -60/0 calibration, V51 approved meter color & peaks, snapshots or native ACK controls.
  • Screenshots, DOM geometry, test command, CI run ID and exact PR head recorded before closing.

Release context: GUI reference visual pass ≠ native PCM/FAT; #266 + #271 + #270 + #15 still independently gate a physically testable VST3 mixer.

Activity

  1. masarray commented on Nov 3, 2026

    @masarray
    OwnerAuthor

    Agent coding card — FX Rack & Rail (#361)

    Active parent plan is at the TOP of #351 (supersedes historical status). Source audited on main@2f01022; re-fetch latest main and PR status before editing.

    Owner files: site/preview-v2/index.html (sectionFx(t), delegated drag handlers), existing site/preview-v2/assets/mixer-fx-rack.css (one physical header/body owner), current Chrome/section-rail style owner (one writer, respect V25). Do not touch V51 approved meter, or mixer-fader-assembly.css while draft #360 is in flight.

    Milestone FX UX: Change occupied-row control order to POWER → plugin label → semantic DRAG GRIP → REMOVE. The grip must be immediately LEFT of remove in every density. Only grip may start dragging; whole-row draggable is a source-confirmed bug. Keyboard reorder alternative, Escape/invalid drop rollback, thin insertion marker, no reorder from plugin picker/power/remove. Never cross-channel copy only plugin name + bypass and claim real VST3 state; fence mock path until stable insertId/ACK and full plugin state/PDC exists.
    Milestone physical chassis: Make .fx-section > .subhead read as the top plate physically attached to the dark recessed .fxslot-list, matching left/right bounds, thin seam, subtle machine edge, restrained surface contrast; no bulky card, no new CSS file, no high-specificity override tail. Section-rail is a single continuous navigation spine with centered 14–16px icons, restrained 2px selected accent, neutral collapsed/disabled states and accessible focus, aligned exactly to strip sections.
    Proof: render 1366×768, 1378×911, 1680×900, 1920×1080 across Comfort/Standard/Compact, normal channel + pinned Master; functional: grip.left of delete, keyboard, drag/drop/cancel, +Add FX, power/bypass/remove, rail collapse/expand, all meter/fader/WIRE preservation. Run focused tests then one full exact-head Chromium/Pages CI; screenshots and actual DOM geometry mandatory. Evidence: PR/commit SHA, CI run URLs, screenshots and accepted-state contract. PR remains draft/red until green and conflict-free.

    Do not claim native audio from a GUI reference screenshot; separate #266/#271/#270/#15 FAT remains mandatory.

  2. masarray commented on Nov 3, 2026

    @masarray
    OwnerAuthor

    Implemented FX/RAIL V53 — stacked on P0 WIRE, pending exact-head CI (2026-11-04)

    Draft PR #364, HEAD 64655212fa8143a685a5ac62330e3a986d92a1ba, targets draft P0 #363, not a stale main. Chromium CI #41739700143 currently running.

    Implemented in real repository source:

    • FX insert DOM: only dedicated 18px focusable grip, immediately left of REMOVE, can initiate drag; row/power/name/remove do not start drag.

    • Keyboard Alt+ArrowUp/Down and Ctrl+Z single-step reorder/undo. Stable demo instance ID and coupled effect-name/bypass reorder; invalid/cross-channel drop rejected without implicit plugin-state copying.

    • Native WebView2 path cannot mutate FX order until proper native intent/ACK/accepted-snapshot contract exists. No fake PCM/VST state certification.

    • Physical FX raised header and recessed insert well within existing mixer-fx-rack.css ownership; unified restrained rail within existing Chrome/V19 owner, no extra stylesheet or bulky cards.

    • New Playwright tests/pages_fx_rail_v53_smoke.py covers 1366×768 / 1378×911 / 1680×900 / 1920×1080 × Comfort/Standard/Compact, pinned Master, drag+keyboard+undo, ARIA/keyboard and CSS geometry, with PNG artifact capture.

    • Actual code + meaningful git commit + safely stacked PR

    • Exact-head CI PASS, screenshot/visual review and cross-bank/current main reconciliation

    • Merge only after P0 merge, then retarget PR GUI P1 V53: safe FX grip reorder, recessed rack plate and unified rail (#361) #364 to main; do not modify or absorb PR GUI V52 — refined recessed fader well, consistent gain ruler surface and visible low-cost thumb shadow #360 fader ownership.

  3. masarray commented on Nov 4, 2026

    @masarray
    OwnerAuthor

    V53 implemented in fresh main-based draft PR #367 at commit e5776df. Five-file FX/rail + Playwright CI scope; historical #364 is now patch provenance, not to merge independently. Acceptance remains blocked on #367 exact-head Chromium + screenshot/interaction review and newest main conflict check. Preserve V51/V52 and native safety. See #351 checkpoint.

  4. masarray commented on Nov 4, 2026

    @masarray
    OwnerAuthor

    V53 now published to public preview. Merged PR #367 at main c02f88cacab71d26f482a0e66443c4c54a9aff5f (FX grip immediately LEFT of REMOVE; dedicated grip drag, Alt+Up/Down, Ctrl+Z, cross-channel guard, attached FX plate/well and unified rail). Exact PR CI #41755311105 SUCCESS; merged-main Chromium+Firefox CI #41756525550 SUCCESS; GitHub Pages build/deploy #41757497158 SUCCESS. Live /preview/build.json SHA and latest main both c02f88c; /preview/ HTML serves V53 CSS cache keys. Original #364 closed as superseded. Not hardware FAT; keep issue open only if manual screenshot signoff or native acceptance criteria remain mandatory. Full execution details in #351.

  5. masarray commented on Nov 4, 2026

    @masarray
    OwnerAuthor

    V55 related GUI fixes are now merged/published through PR #373 at main@6a133e3: context-aware graphite disconnected WIRE nodes, larger static cap shadow, independent FX chain/insert bypass confirmed; engine handoff documented and sent to #266/#271. PR CI #41784070588 SUCCESS; main CI #41785322741 SUCCESS; Pages #41786195753 SUCCESS; live build.json SHA matches. See #351 latest checkpoint. Native FX actual ACK/hardware FAT not claimed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions