Repository navigation
M6: proportional hardware faders, collision-free knobs and premium typography - #9
Merged
Merged
Conversation
…y compact GUI typography
…r depth at compact width
masarray
marked this pull request as ready for review
October 31, 2026 22:56
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final M6 quality gate — verified 1 Nov 2026
8ffddc174c3a159cd6c86e1b0e8196cd63ae1e45. Windows + Linux SUCCESS on Actions #41248625467, including Windows Release VST3, Standalone and GUI smoke and Linux engine-safety.0dc2a131398da19cb61c3e3c0da36aac4f706702880c49bc6e248da436006a6b. All three internal SHA256 entries PASS for VST3 binary, moduleinfo.json and Standalone exe. CI BUILD-INFO points to GitHub merge-test SHA1930890ecff20b94d60065fa2b8060a84e53a816.main: 3 commits ahead, 0 behind; six scoped files changed (layout/render contract, tests, docs). Zero DSP/audio callback/driver/parameter changes in M6.Screenshot-led finishing pass
The first Windows CI (#41223308943) passed on Windows and Linux, and its actual 612×500 screenshot confirmed all title/label/knob changes. It also exposed that the strict 340:57 track artwork appears optically thin in a short 85px Dynamics slot. Commit
2c48e131therefore adds an independently painted 23px-deep metallic housing BEHIND the undistorted track + thumb. The image ratios remain exact and their movement unchanged. New smoke checkFADER_HOUSING_DEPTH_78probes the actual JUCE raster, not a hardcoded layout assumption. One final combined CI follows; previous Windows artifact is superseded.M6 — Proportional hardware controls and premium compact typography
Addresses the real 612×500 screenshots: flattened short faders, overlapping/too-close knob captions, inconsistent typography and all-caps Mini/File.
Production changes
FaderGeometrycalculation scales both by the same factor; no nine-slice horizontal squeezing, no fixed 18×37 thumb independent of plate. The red LED is drawn inside the scaled rail, underneath the thumb. Paint-only arithmetic; PNGs are predecoded.Validation gates
plugin_state_editorand Linux engine safety.Engineering notes: docs/M6-GUI-REFINEMENT.md. Reference design hierarchy: FabFilter Pro-C 3, with independent, non-infringing assets.