Skip to content

M6: proportional hardware faders, collision-free knobs and premium typography - #9

Merged
masarray merged 3 commits into
mainfrom
milestone/m6-proportional-controls-typography
Oct 31, 2026
Merged

masarray merged 3 commits into
mainfrom
milestone/m6-proportional-controls-typography

Conversation

@masarray

@masarray masarray commented Oct 31, 2026 •

Copy link
Copy Markdown
Owner

Final M6 quality gate — verified 1 Nov 2026

  • Exact head: 8ffddc174c3a159cd6c86e1b0e8196cd63ae1e45. Windows + Linux SUCCESS on Actions #41248625467, including Windows Release VST3, Standalone and GUI smoke and Linux engine-safety.
  • ReadyToTest artifact #13061225143 downloaded and CRC-checked. Artifact ZIP SHA256 0dc2a131398da19cb61c3e3c0da36aac4f706702880c49bc6e248da436006a6b. All three internal SHA256 entries PASS for VST3 binary, moduleinfo.json and Standalone exe. CI BUILD-INFO points to GitHub merge-test SHA 1930890ecff20b94d60065fa2b8060a84e53a816.
  • Reviewed real CI screenshot images for Full 612×500, minimum 580×480, Sidechain and compact. The metal thumb ridge is visible, slider artwork preserves native aspect ratio, all seven captions and knobs have clear gaps, and Mini/File use title case. No obvious control collisions. The visual design retains original asset identity rather than copying FabFilter graphics.
  • Comparison to main: 3 commits ahead, 0 behind; six scoped files changed (layout/render contract, tests, docs). Zero DSP/audio callback/driver/parameter changes in M6.
  • Physical audio-device / VST3-host approval remains pending. A passing CI is not proof of crackle-free PS22 audio, GPU percentage improvement, or sonic parity with Pro-C. Merge means stable engineering GUI test baseline.

Screenshot-led finishing pass

The first Windows CI (#41223308943) passed on Windows and Linux, and its actual 612×500 screenshot confirmed all title/label/knob changes. It also exposed that the strict 340:57 track artwork appears optically thin in a short 85px Dynamics slot. Commit 2c48e131 therefore adds an independently painted 23px-deep metallic housing BEHIND the undistorted track + thumb. The image ratios remain exact and their movement unchanged. New smoke check FADER_HOUSING_DEPTH_78 probes the actual JUCE raster, not a hardcoded layout assumption. One final combined CI follows; previous Windows artifact is superseded.

M6 — Proportional hardware controls and premium compact typography

Addresses the real 612×500 screenshots: flattened short faders, overlapping/too-close knob captions, inconsistent typography and all-caps Mini/File.

Production changes

  • True, full-image fader scaling: the existing track is 340×57 and thumb is 58×124. One FaderGeometry calculation scales both by the same factor; no nine-slice horizontal squeezing, no fixed 18×37 thumb independent of plate. The red LED is drawn inside the scaled rail, underneath the thumb. Paint-only arithmetic; PNGs are predecoded.
  • Knob/caption breathing room: seven main knob controls lower by 6px, height 58px, labels 10.4pt and actual 9px gap. Bottom fader captions separate from fader boxes, common baseline for Dynamics + Sidechain.
  • Typography: 11pt buttons and combos, 10.4pt captions, 9.5pt header micro-overlines, readable native silver wordmark instead of dark low-contrast photographic text. "Mini"/"Full"/"File"/"Dynamics"/"Sidechain" in title case; A/B unchanged.
  • Zero regression to functionality: Full editor 612×500, min 580×480, MINI 320; editable transfer curve, meters, preset library with 46 factory sounds, ASIO and DSP preserved. No sample path, worker, memory management or parameter modifications.

Validation gates

  • Windows VST3+Standalone + plugin_state_editor and Linux engine safety.
  • New CI assertions: both image aspect ratios within 0.001 across 70–150px widths, track/thumb within bounds, LED/thumb movement render, seven main knob-label gaps, six bottom fader label gaps, button titles, old window/header/tab/screenshot/ASIO contracts.
  • Review the captured FULL/default/minimum/SIDECHAIN/MINI JUCE screenshots before merging. Do not claim physical GPU or audio crackle improvements; this is a visual/UX fix.

Engineering notes: docs/M6-GUI-REFINEMENT.md. Reference design hierarchy: FabFilter Pro-C 3, with independent, non-infringing assets.

@masarray
masarray marked this pull request as ready for review October 31, 2026 22:56
@masarray
masarray merged commit 8878167 into main Oct 31, 2026
2 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-31T22:57:56.563118Z 8ffddc1 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant