Repository navigation
M5: 46 audible calibrated presets and compact 612px premium compressor GUI - #8
Conversation
… audio-safe recall
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 776745c661
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| for(std::size_t i=0;i<bank.size();++i) | ||
| if(favorites[i])data+=juce::String(bank[i].id)+"\n"; | ||
| file.replaceWithText(data); |
There was a problem hiding this comment.
Preserve favorite changes made by other plugin instances
When two plugin editors are open, each loads favorites only during construction and subsequently replaces the same application-wide file with its private snapshot. For example, opening editors A and B, starring one preset in A, and then starring another in B silently removes A's favorite from disk; unstarring can similarly resurrect favorites removed elsewhere. Apply each toggle against the latest shared state, or synchronize favorites across instances, while keeping persistence on the message thread.
AGENTS.md reference: AGENTS.md:L27-L27
Useful? React with 👍 / 👎.
…rve active preset title
…pact hardware layout
…icit smoke success
M5 reconciliation audit — 31 Oct 2026 (evidence-based)Branch gate: PR #8 is still OPEN and NOT MERGED. Main is M4 (704x520 FULL, 660x490 min, 330 MINI) and has only 6 factory presets in Source verified on M5: Prior CI failure: run #51 (41219048907) built VST3+Standalone and passed Linux engine-safety and Windows engine_contract, but Windows Bug fix reconciliation: commit Acceptance gates (must not collapse into a single "done" claim)
Reference: PR #8 and CI runs #50/#51/#53. Avoid repeating already merged M2–M4 work or creating unnecessary CI runs. |
M5 Reconciled — 46 audible factory presets + narrower premium GUI
This PR consolidates the user's two requested improvements on top of the existing 46-preset searchable/favorites browser; it also retains the recent fix that preserves the displayed preset name when opening/dismissing the browser.
Preset sound: stronger first-use impact, controlled gain
Much narrower, still premium UI
CI and actual-device gates
Source SHA
7073098ba120b988e8b2c24ce477d14bc3ff99aa; check exact SHA Windows Release VST3+Standalone, plugin_smoke UI/preset bank and Linux engine-safety. Do not merge without both jobs passing. Then publish Windows artifact with default/minimum/SIDECHAIN/MINI/browser screenshots and SHA256. Hardware listening/headroom, PS22 stability and long-run sessions remain separate user acceptance gates.FabFilter Pro-C 3 publicly explains wet makeup/auto-gain as compensation and warns its auto-gain is an educated estimate, not measured loudness. Reference: https://www.fabfilter.com/help/pro-c/using/timecontrols . All ArSonComp presets remain original; none of FabFilter's .ffp data, assets or proprietary compression DSP are reused.