Repository navigation
M3 GUI performance: isolate opaque LCD canvas and keep audio path independent - #5
Merged
Merged
Conversation
masarray
marked this pull request as ready for review
October 31, 2026 14:49
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI verification / Windows physical-test package — 2026-10-31
fd30b978971c8b18c566fdc3f906333890e187f8, Actions #41211198153: Windows and Linux SUCCESS, including VST3, Standalone, JUCE editor smoke (FULL/minimum/SIDECHAIN/MINI), existing audio/sidechain tests and sanitizer engine-safety.8cc330eab5d5ae52104682308cde50d1a4a2648a311087c9315b6eed2316e52c.4a09eb3c3a6956f42a40687c141a4030ca5d99a4.ArSonComp-preview.png780×640 andArSonComp-preview-compact.png780×330 visually reviewed. LCD graph, meter/transfer traces, footer readout and MINI layout render correctly.Purpose
User reports GUI GPU usage (~2.7%), 0.4% CPU and 46.4 MB working set on a standalone Windows snapshot, with concern that graphic workload competes with audio. These are instantaneous figures, not evidence of audio dropouts or leaks.
Implementation
DSP, processBlock, VST3 parameter IDs, audio latency, buffers and workers unchanged. No release claim until Windows/Linux CI and physical device tests. Official JUCE ADC 2025 drawing guidance: https://conference.audio.dev/session/2025/understanding-juce-drawing/
Gates