Skip to content

M3 GUI performance: isolate opaque LCD canvas and keep audio path independent - #5

Merged
masarray merged 1 commit into
mainfrom
perf/gui-isolated-lcd
Oct 31, 2026
Merged

masarray merged 1 commit into
mainfrom
perf/gui-isolated-lcd

Conversation

@masarray

@masarray masarray commented Oct 31, 2026 •

Copy link
Copy Markdown
Owner

CI verification / Windows physical-test package — 2026-10-31

  • Code fd30b978971c8b18c566fdc3f906333890e187f8, Actions #41211198153: Windows and Linux SUCCESS, including VST3, Standalone, JUCE editor smoke (FULL/minimum/SIDECHAIN/MINI), existing audio/sidechain tests and sanitizer engine-safety.
  • Windows x64 artifact #13045749913 (expires 2026-11-14 UTC); archive SHA256 8cc330eab5d5ae52104682308cde50d1a4a2648a311087c9315b6eed2316e52c.
  • Package independently inspected: ZIP CRC PASS; the three published SHA256 entries for VST3 binary, VST3 moduleinfo, Standalone EXE all PASS. BUILD-INFO points to Actions merge-test SHA 4a09eb3c3a6956f42a40687c141a4030ca5d99a4.
  • Actual Windows ArSonComp-preview.png 780×640 and ArSonComp-preview-compact.png 780×330 visually reviewed. LCD graph, meter/transfer traces, footer readout and MINI layout render correctly.
  • Physical evaluation pending: using same audio device/driver, compare GUI shown vs minimized, 48 kHz, 128/64/32 buffers where stable; record Task Manager sustained CPU/GPU, DAW xruns, moving knobs/Threshold and long-term working set. Neither a zero-GPU nor zero-stutter claim is made by this CI.

Purpose

User reports GUI GPU usage (~2.7%), 0.4% CPU and 46.4 MB working set on a standalone Windows snapshot, with concern that graphic workload competes with audio. These are instantaneous figures, not evidence of audio dropouts or leaks.

Implementation

  • Live graph/IN-GR-OUT display moved to a dedicated opaque leaf GraphCanvas. Only its region receives telemetry invalidations. Parent chassis/header/knob-row painting is static and no longer invoked by each meter timer.
  • MINI renders its 47px meter glass only, from the cached chassis.
  • Keep graph mouse event forwarding to parent for Threshold marker host automation and cursor; retain existing meter queue, smoothing and 30Hz active visualization.
  • No idle repaint when nothing arrived, history isn't aging and meter visual decay is insignificant.
  • Align constructor resize limits to 740×585 min and 780×640 default.
  • Extend plugin smoke to assert GraphCanvas bounds/opaqeness in full, MINI and restored FULL; new engineering note in docs/GUI-PERFORMANCE.md.

DSP, processBlock, VST3 parameter IDs, audio latency, buffers and workers unchanged. No release claim until Windows/Linux CI and physical device tests. Official JUCE ADC 2025 drawing guidance: https://conference.audio.dev/session/2025/understanding-juce-drawing/

Gates

  • Windows VST3/Standalone compilation, UI screenshot and smoke tests, Linux engine-safety.
  • Test actual Windows interface with plugin UI open/closed at 128/64/32 frames; track xruns and long-term private bytes.
  • Production release and no-dropout claims remain out of scope.

@masarray
masarray marked this pull request as ready for review October 31, 2026 14:49
@masarray
masarray merged commit af9d60a into main Oct 31, 2026
2 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-31T14:50:04.184879Z fd30b97 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant