Repository navigation
M2: Optimize real-time compressor DSP, sparse ramps and no-GR fast path with deadline stress tests - #3
Merged
Conversation
…DSP improvement plan
…and multi-instance regressions
masarray
marked this pull request as ready for review
October 31, 2026 14:13
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
M2 — Real-Time CPU Work Reduction / Ready-To-Test Windows
Engineering milestone passed on 2026-10-31. This is a testable VST3/Standalone baseline, NOT a confirmed fix for user-reported physical dropouts, memory leaks, or FabFilter sonic parity.
Changes merged in this milestone
log10and static gain computation, with a float guard. During threshold/knee automation the original exact path remains.exp(0)when reduction is exactly zero. Originalexpremains for actual compression; no unsafe approximate LUT.Verified CI and actual artifact
2e696c5559ac9701d8ce305b8fe20bc190c3f2cf.4cd27a16b2fbc4ce3a8d8f99ba5a277bf50e5c1ehas parents exactly506c35e8and2e696c55, so the delivered build indeed contains this PR.6279fea7fbe79b1b07c89e2a13779902a8ab69a8069aab71c932b7db30f9a45c, archive CRC PASS, VST3 binary/module metadata/Standalone exe all match SHA256SUMS, actual full 780×640 screenshot visually examined.Measured CI benchmark (one pair of separate Windows hosted runner runs; NOT repeatable hardware proof)
27 exact scenario-pairs across Clean/Peak, Smooth/RMS/SC, and RMS automation × 32/64/128 frames × 1/8/24 instances:
Mandatory physical validation / follow-up
User can immediately test Standalone / VST3 on actual Windows device. Compare previous (CI #41205740765) versus this build in the same DAW/driver and same hardware. Test 48 kHz, 128 then 64 then 32 samples, 1/8/16 instances; run 30–60 minutes while recording host xrun/dropout counters, driver, DPC spikes, GUI closed/open, bypass, mono/stereo sidechain, preset/automation save-reload and audible fast attack/release artifacts. Without this, never claim zero dropouts or no memory leaks.
Run pluginval and a second independent VST3 host, sustained multi-instance/editor lifecycle leak diagnostics and loudness-matched Pro-C 3-style listening/meter comparisons before a production release.
See RT reliability plan. Merge into main records an engineering testing baseline only; no production tag or release.