Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,12 @@ jobs:
run: |
$ErrorActionPreference = 'Stop'
$dest = 'artifacts/ArSonComp-Windows-Test'
New-Item -ItemType Directory -Force "$dest/Plugin", "$dest/Standalone", "$dest/Screenshots" | Out-Null
New-Item -ItemType Directory -Force "$dest/Plugin", "$dest/Standalone", "$dest/Screenshots", "$dest/QA" | Out-Null
Copy-Item -Recurse 'build/ArSonComp_artefacts/Release/VST3/ArSonComp.vst3' "$dest/Plugin/"
Copy-Item 'build/ArSonComp_artefacts/Release/Standalone/ArSonComp.exe' "$dest/Standalone/"
Copy-Item 'docs/WINDOWS-QUICKSTART.md' "$dest/START-HERE.md"
Copy-Item 'tools/Collect-ArSonComp-Hardware.ps1' "$dest/QA/"
Copy-Item 'docs/M7-PHYSICAL-READINESS.md' "$dest/QA/"
Copy-Item 'artifacts/benchmark.txt' "$dest/benchmark.txt"
Copy-Item 'artifacts/realtime-stress.txt' "$dest/realtime-stress.txt"
Copy-Item 'build/ArSonComp-preview*.png' "$dest/Screenshots/"
Expand Down
5 changes: 5 additions & 0 deletions AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,8 @@
- Catalog browser supports real categories/search/tags/description/favorites without consuming additional permanent GUI space.
- Loading a factory program never changes External SC, Listen or Bypass; factory values are sanitized against the canonical parameter table.
- UI favorites persistence is strictly on the message thread, never in DSP. Test every program for finite output, safe bounds and host parameter recall, plus browser screenshot.

## M7 physical readiness
- Keep the user-approved separate transparent horizontal silver ruler and round thumb; avoid fake light waves or diagonal specular backgrounds. Cache matte brushed grain only on resize.
- Retain visual/native slider hit separation, caption clearances, host automation and LCD meter isolation.
- A shipped Windows test artifact needs the actual screenshot set, QA inventory helper and an explicit physical-test checklist; no CI result proves PS22 xruns or commercial sonic parity.
35 changes: 35 additions & 0 deletions docs/M7-PHYSICAL-READINESS.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
# M7 — Premium flat brushed metal + hardware field-test gate

## Integrated changes
- Full editor 612×580, minimum 580×540, MINI remains unchanged.
- Approved photographic horizontal ruler track and circular silver thumb retained.
- Thumb visually reduced from 30px to 23.8px at its normal 34px control height
(about **21% smaller**), while keeping the same draggable JUCE Slider bounds.
- Caption and slider component both lowered by 3px with their 5px separation.
- Old diagonal/spotlight chassis replaced by matte #4B4E50 graphite and
reproducible horizontal micro-scratches, cached on resize only.
- Fast message-thread paint, bounded meter updates, zero DSP changes.

## Industry reference, not copying
- FabFilter Pro-C 3: large metering with compact controls.
https://www.fabfilter.com/help/pro-c/using/displays
- TDR Kotelnikov GE: logical sections, readable metering.
https://docs.tokyodawn.ru/kotelnikov-ge-manual/
- Steinberg VST3 API: isolate realtime audio from GUI allocations and I/O.
https://steinbergmedia.github.io/vst3_dev_portal/pages/Technical%2BDocumentation/API%2BDocumentation/Index.html

## Evidence and physical acceptance
Windows VST3+Standalone + plugin CTest + four real JUCE snapshots; Linux
sanitizer engine-safety. Source smoke tests include horizontally directional
flat chassis, 20–25px photo thumb, caption clearance, MINI and sidechain.

Package QA/Collect-ArSonComp-Hardware.ps1 with an up-to-date START-HERE.md.
A successful CI **does not** prove Maono PS22 stability. The actual gate is
two VST3 hosts, ASIO/WASAPI driver and 128/64/32 buffers, A/B/C/D crackle
isolation, host XRUN counts, project restore, 60-minute session, and
loudness-matched listening. Test helper only collects metadata and writes a
manual form; it does not silently claim measurements.

## CI budget
One integrated PR and one Windows+Linux CI. Retry only a failed job after
targeted fixes. No lookahead, oversampling or DSP architecture changes.
170 changes: 82 additions & 88 deletions docs/WINDOWS-QUICKSTART.md

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion plugin/FaderGeometry.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ struct FaderGeometry {
const float trackWidth=juce::jmax(1.0f,
std::min(width-4.0f,(height-3.0f)*trackAspect));
const float trackHeight=trackWidth/trackAspect;
const float thumbSize=juce::jlimit(22.0f,33.0f,height-4.0f);
// Smaller VISUAL thumb while keeping the 34px interactive Slider bounds.
const float thumbSize=juce::jlimit(20.0f,25.0f,height*0.70f);
const float railX=(width-trackWidth)*0.5f;
const float cy=height*0.5f;
FaderGeometry g;
Expand Down
4 changes: 2 additions & 2 deletions plugin/HeaderLayout.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@ struct EditorMetrics {
static constexpr float buttonFont=11.0f;
static constexpr float controlCaptionFont=10.4f;
static constexpr int knobCaptionOffset=2, knobTopOffset=26, knobHeight=66;
static constexpr int faderCaptionOffset=25, faderTopOffset=44, faderHeight=34;
static constexpr int faderCaptionOffset=28, faderTopOffset=47, faderHeight=34;
static constexpr juce::uint32 captionRgb=0xffd9e0e3;
static constexpr juce::uint32 controlCaptionRgb=0xffe4e9ec;
static constexpr juce::uint32 headerBackgroundRgb=0xff292d30;
static constexpr juce::uint32 metalBackgroundRgb=0xff454a4d;
static constexpr juce::uint32 metalBackgroundRgb=0xff4b4e50;
};

struct HeaderLayout {
Expand Down
51 changes: 30 additions & 21 deletions plugin/SurfacePaint.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,28 +7,37 @@ namespace arson::ui {
// Resizable brushed gunmetal chassis, painted ONCE into Editor::metalSurface
// when the plugin dimensions change. No noise, blur, bitmap IO or shader in
// timerCallback / audio callback. Deterministic scan lines avoid RNG state.
inline void paintBrushedChassis(juce::Graphics& g, int width, int height) {
const float w=static_cast<float>(width),h=static_cast<float>(height);
const juce::Colour light{0xff65696b}, dark{0xff383c40};
g.setGradientFill(juce::ColourGradient(light,0.0f,0.0f,
dark,w,h,false));
g.fillRect(0.0f,0.0f,w,h);
g.setGradientFill(juce::ColourGradient(
juce::Colours::white.withAlpha(0.09f),w*0.16f,0.0f,
juce::Colours::black.withAlpha(0.08f),w*0.88f,0.0f,false));
g.fillRect(0.0f,0.0f,w,h);
// Fine horizontally brushed metal grain. Baked into a single image.
for(int y=0;y<height;y+=2) {
const std::uint32_t k=static_cast<std::uint32_t>(y)*2654435761u+1013904223u;
const float a=0.026f+static_cast<float>((k>>25)&15u)/1400.0f;
g.setColour((k&1u)?juce::Colours::white.withAlpha(a):
juce::Colours::black.withAlpha(a*1.45f));
g.drawHorizontalLine(y,0.0f,w);
// Realistic flat brushed gunmetal. Grain is HORIZONTAL and deliberately
// flat: no radial/diagonal sheen, no waves and no separate photo overlay.
// This runs once at Editor::resized(), not in the meter timer or audio callback.
inline void paintBrushedChassis(juce::Graphics& g,int width,int height) {
g.fillAll(juce::Colour{0xff4b4e50});
for(int y=0;y<height;++y) {
// Pure deterministic row-coherent micro-striations, no RNG state.
std::uint32_t k=static_cast<std::uint32_t>(y)+0x9e3779b9u;
k^=k>>16; k*=0x7feb352du;
k^=k>>15; k*=0x846ca68bu; k^=k>>16;
const float a=0.025f+static_cast<float>((k>>25)&31u)*0.00065f;
g.setColour((k&1u) ? juce::Colours::white.withAlpha(a) :
juce::Colours::black.withAlpha(a*1.10f));
g.drawHorizontalLine(y,0.0f,static_cast<float>(width));
// Short directionally brushed scratches without large-scale banding.
if(y%3==0) {
for(int cell=0;cell<(width+63)/64;++cell) {
const std::uint32_t t=k^(static_cast<std::uint32_t>(cell+1)*2246822519u);
const int x=cell*64+static_cast<int>((t>>22)&15u);
const int right=std::min(width,x+15+static_cast<int>((t>>16)&31u));
if(right<=x)continue;
g.setColour((t&1u) ? juce::Colours::white.withAlpha(0.028f) :
juce::Colours::black.withAlpha(0.035f));
g.drawHorizontalLine(y,static_cast<float>(x),static_cast<float>(right));
}
}
}
g.setColour(juce::Colours::white.withAlpha(0.085f));
g.drawHorizontalLine(1,0.0f,w);
g.setColour(juce::Colours::black.withAlpha(0.32f));
g.drawHorizontalLine(height-2,0.0f,w);
g.setColour(juce::Colours::white.withAlpha(0.08f));
g.drawHorizontalLine(0,0.0f,static_cast<float>(width));
g.setColour(juce::Colours::black.withAlpha(0.25f));
g.drawHorizontalLine(height-1,0.0f,static_cast<float>(width));
}

inline void paintInsetGlass(juce::Graphics& g,juce::Rectangle<float> bounds) {
Expand Down
36 changes: 33 additions & 3 deletions tests/PluginSmoke.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,28 @@ static int runSmoke(int argc,char** argv) {
if(std::abs(audio.getSample(0,0)-0.123f)>1.0e-6f ||
std::abs(audio.getSample(0,31)-0.123f)>1.0e-6f)return failHost(46);
}
// M7: the real cached chassis must have a visible fine horizontal
// brush grain WITHOUT large-scale left-to-right spotlight gradients.
{
constexpr int w=192,h=96;
juce::Image surface(juce::Image::RGB,w,h,true);
{
juce::Graphics paint(surface);
arson::ui::paintBrushedChassis(paint,w,h);
}
float rows=0.0f,across=0.0f;
for(int y=8;y<88;++y) {
const float v=surface.getPixelAt(90,y).getBrightness();
rows+=std::abs(v-surface.getPixelAt(90,y+1).getBrightness());
across+=std::abs(v-surface.getPixelAt(16,y).getBrightness());
}
const float tone=surface.getPixelAt(90,42).getBrightness();
if(rows<0.8f || across>2.5f || tone<0.24f || tone>0.41f) {
std::cerr<<"BRUSHED_MATERIAL_89 grain="<<rows
<<" horizontal="<<across<<" tone="<<tone<<std::endl;
return 89;
}
}
// Approved M6.3 PNG resources are embedded and independently decoded.
// Never replace the textured ruler or circular thumb with drawn shapes.
{
Expand Down Expand Up @@ -239,7 +261,9 @@ static int runSmoke(int argc,char** argv) {
shape.track.getX()<0.0f || shape.track.getRight()>width ||
shape.thumb.getX()<0.0f || shape.thumb.getRight()>width ||
shape.thumb.getY()<0.0f || shape.thumb.getBottom()>height ||
shape.left>=shape.right) {
shape.left>=shape.right ||
shape.thumb.getWidth()<20.0f ||
shape.thumb.getWidth()>25.01f) {
std::cerr<<"PHOTO_GEOMETRY_73 w="<<width<<"\n";
return 73;
}
Expand Down Expand Up @@ -645,7 +669,10 @@ static int runSmoke(int argc,char** argv) {
const auto* fader=editor->findChildWithID("param."+juce::String(name));
if(!caption||!fader||fader->getY()-caption->getBottom()<4||
fader->getHeight()!=arson::ui::EditorMetrics::faderHeight||
fader->getBottom()>editor->getHeight()-5)return 76;
fader->getBottom()>editor->getHeight()-5 ||
caption->getY() !=
editor->getHeight()-arson::ui::EditorMetrics::bottomControlsReserve+
arson::ui::EditorMetrics::faderCaptionOffset)return 76;
}
// File controls are deliberately not mounted in the visible header.
// Both independent tab views must have unclipped, non-overlapping
Expand Down Expand Up @@ -692,7 +719,10 @@ static int runSmoke(int argc,char** argv) {
const auto* caption=editor->findChildWithID("caption."+juce::String(name));
const auto* fader=editor->findChildWithID("param."+juce::String(name));
if(!caption||!fader||fader->getY()-caption->getBottom()<4||
fader->getHeight()!=arson::ui::EditorMetrics::faderHeight)return 77;
fader->getHeight()!=arson::ui::EditorMetrics::faderHeight ||
caption->getY() !=
editor->getHeight()-arson::ui::EditorMetrics::bottomControlsReserve+
arson::ui::EditorMetrics::faderCaptionOffset)return 77;
}
if(!hp->isVisible()||!lp->isVisible()||!detector->isVisible()||
!external->isVisible()||!listen->isVisible()||
Expand Down
61 changes: 61 additions & 0 deletions tools/Collect-ArSonComp-Hardware.ps1
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
# ArSonComp M7 read-only Windows audio hardware inventory and manual QA form.
# Does not modify devices, measure audio callback timing, or declare xrun success.
[CmdletBinding()]
param([string]$ReportDirectory = (Join-Path $PSScriptRoot "Reports"))
$ErrorActionPreference = "Stop"
New-Item -ItemType Directory -Force -Path $ReportDirectory | Out-Null
$stamp = (Get-Date).ToUniversalTime().ToString("yyyyMMdd-HHmmss")
$prefix = Join-Path $ReportDirectory ("ArSonComp-" + $stamp)
$osInfo = $null
$audioInfo = @()
try {
$osInfo = Get-CimInstance Win32_OperatingSystem |
Select-Object Caption, Version, BuildNumber, OSArchitecture
} catch { Write-Warning ("OS query: " + $_.Exception.Message) }
try {
$audioInfo = @(Get-CimInstance Win32_SoundDevice |
Select-Object Name, Manufacturer, DriverVersion, Status)
} catch { Write-Warning ("Audio devices: " + $_.Exception.Message) }
$inventory = [ordered]@{
generated_utc = (Get-Date).ToUniversalTime().ToString("o")
purpose = "Device metadata only. Not a latency or xrun measurement."
windows = $osInfo
audio_devices = $audioInfo
}
$inventory | ConvertTo-Json -Depth 6 |
Set-Content -Path ($prefix + "-devices.json") -Encoding UTF8
$report = @"
# ArSonComp M7 physical test — manual record
Date: $(Get-Date -Format 'yyyy-MM-dd HH:mm:ss zzz')
Build SHA (BUILD-INFO.txt):
Host and version / Standalone or VST3:
Windows / CPU:
Audio interface (Maono PS22 if used):
Driver and version (ASIO/WASAPI):
Sample rate (start 48000 Hz):
Audio input/output channels:
Buffer tested (128 / 64 / 32 samples):
Mode / preset / threshold / makeup / ratio:
Host plugin reported latency:
Actual hardware round-trip latency, if measured:
Actual host xrun count and callback spikes:
A Device direct monitoring crackles?:
B Host without plugin crackles?:
C Host-bypassed plugin crackles?:
D Plugin active crackles?:
Audio recordings for A/B/C/D:
1-instance xrun count:
8-instance xrun count:
60-minute session xrun count:
Editor open/close while playing:
Private bytes before/after:
Host project saved/restored and automation tested?:
Mono / stereo / external sidechain tested?:
GUI minimum/default/MINI and control visibility:
Result: PASS / FAIL / NOT TESTED
Reproduction notes:
"@
$report | Set-Content -Path ($prefix + "-manual-checklist.md") -Encoding UTF8
Write-Host "Saved device inventory:" ($prefix + "-devices.json")
Write-Host "Manual QA form:" ($prefix + "-manual-checklist.md")
Write-Host "No xrun or hardware latency measurement was performed automatically."
Loading