Skip to content

M6.3: approved flat brushed-metal PNG track + circular silver slider thumb - #12

Merged
masarray merged 1 commit into
mainfrom
feat/m63-photo-slider-track-thumb
Nov 1, 2026
Merged

masarray merged 1 commit into
mainfrom
feat/m63-photo-slider-track-thumb

Conversation

@masarray

@masarray masarray commented Nov 1, 2026

Copy link
Copy Markdown
Owner

User-approved change

Replace the rejected vector horizontal faders with the actual approved flat horizontal brushed-metal track PNG and circular satin-silver PNG thumb. They are cropped/resized from the provided approved artwork, embedded into both VST3 and Standalone. Source images are stationary track (480×66) and independent 96×96 silver circular thumb.

Integration

  • Decoded once on JUCE editor initialization, never in the real-time DSP callback.
  • Consistent aspect ratio and bounds for Range, Hold, Mix, Link, HP and LP controls.
  • Updated production LookAndFeel and CMake BinaryData; removed previous drawn coral fill/graphite thumb implementation.
  • Added smoke tests for resource presence, transparency, proportional geometry, stationary rail and moving thumb.
  • Preserve taller LCD Full 612×580, MINI, Sidechain, presets and host ASIO.

Quality gate

Windows VST3+Standalone compile, plugin CTest, screenshot review and Linux sanitizer engine-safety. No DSP or routing changes. Source: docs/M63-BRUSHED-METAL-SLIDERS.md.

@masarray
masarray marked this pull request as ready for review November 1, 2026 02:33
@masarray
masarray merged commit 051cf3e into main Nov 1, 2026
2 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-01T02:35:01.514696Z eacac17 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant