G2.6: require observed quality/timestamp evidence for production acceptance - #99
Merged
Merged
Conversation
masarray
marked this pull request as ready for review
August 24, 2026 11:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Harden the PR #98 shadow-to-production bridge so optional shadow configuration can never accidentally grant the production quality gate when no real paired quality/timestamp evidence was observed.
New strict policy
Adds
MmsDynamicReportShadowProductionAcceptancePolicy.BuildStrict(...).It requires a successful typed shadow, then delegates all existing shadow gates to PR #98 and additionally refuses
QualityRegressionPassedunless physical evidence contains:This is deliberately fail-closed. It does not mutate a profile and does not call
MarkProductionEligible.Why this follow-up exists
PR #98 correctly allows quality/timestamp evidence to be optional at the generic evaluator level for staged diagnostics. The generic bridge therefore reflects parity for the configured shadow. A production consumer needs the stronger invariant that absence of evidence must not become a passing production quality regression. This PR adds that explicit production-facing boundary without weakening or changing diagnostic shadow behavior.
Tests
AllPassedwhen every other gate passes;QualityRegressionPassed=falsewhen q/t evidence is absent;Keep draft until exact-head CI is green.