G2.6: consume ProductionEligible profile for automatic dynamic reporting - #97
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a2b2265af5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (!capability.MayAttemptDynamicReports) | ||
| { | ||
| return ProductionDynamicAuthorization.Denied( | ||
| "The current MMS association does not satisfy the dynamic-report capability gate."); |
There was a problem hiding this comment.
When another free RCB makes capability.MayAttemptDynamicReports true but the profile-proven RCB itself lacks required current evidence such as TrgOps, this association-wide check authorizes production planning anyway. The restricted generic planner then accepts the proven RCB because IsDynamicUsable does not enforce the per-RCB capability evaluator's field checks, so it can emit an active write plan for an RCB whose current capability classification rejected dynamic mutation. Require capability.FindReportControl(report.RcbReference)?.IsDynamicWriteAttemptCandidate == true before authorizing it.
AGENTS.md reference: AGENTS.md:L153-L155
Useful? React with 👍 / 👎.
| var automaticOptions = AutomaticMonitoringOptions(options, production); | ||
| var plan = MmsHybridReportAcquisitionPlanner.Build( | ||
| catalog, | ||
| requestedSignals, | ||
| restrictedInventory, | ||
| restrictedAvailability, | ||
| liveDirectory, | ||
| planningDirectory, | ||
| automaticOptions); |
There was a problem hiding this comment.
For every authorized dynamic segment, this delegates to BuildFreshDynamicPlan, which unconditionally creates AR_HYB_01 rather than using the DataSet reference stored in the activation and InformationReport proofs. Consequently a profile proving LD0/LLN0.AR_G2Q authorizes creation and binding of a different named-variable list, with a different encoded request size and identity that the qualification evidence never exercised; the post-plan invariant checks only RCB and members and therefore does not catch this. Pass the proven DataSet identity into planning or reject any emitted segment whose DataSet reference differs.
AGENTS.md reference: AGENTS.md:L156-L156
Useful? React with 👍 / 👎.
| var plan = MmsHybridReportAcquisitionPlanner.Build( | ||
| catalog, | ||
| requestedSignals, | ||
| restrictedInventory, | ||
| restrictedAvailability, | ||
| liveDirectory, | ||
| planningDirectory, | ||
| automaticOptions); |
There was a problem hiding this comment.
A valid profile may record members in any DataSet order, but the generic planner invoked here sorts resolved signals by domain and SignalKey before constructing DynamicPoints. If the proven report order is non-lexical—for example [Ind2, Ind1]—requesting both produces [Ind1, Ind2]; the new ordered-subset invariant then rejects the otherwise qualified plan and rebuilds it as polling-only. Construct the dynamic points in production.MemberReferences order rather than relying on the generic planner's ordering.
AGENTS.md reference: AGENTS.md:L144-L144
Useful? React with 👍 / 👎.
1 participant
Goal
Close the P6.2-B production-consumer gap without weakening the existing dynamic-report quarantine.
Behavior
CanUseForProductionPlanning(...)to accept an identity-compatibleProductionEligibleprofileCompatibility
The existing
MmsCapabilityAwareHybridReportAcquisitionPlanner.Build(...)signature remains source-compatible; the production context is an optional final argument.Tests
Adds G2.6 regressions for:
No live field claim is made by this PR. Next step after CI is wiring this typed context into ARSAS and then running the deterministic A3/shadow field qualification.