Refresh six map table header goldens against integrated main - #670
Closed
gafferongames wants to merge 1 commit into
Closed
Refresh six map table header goldens against integrated main#670gafferongames wants to merge 1 commit into
gafferongames wants to merge 1 commit into
Conversation
Co-Authored-By: GPT-6
rowan-claude
marked this pull request as ready for review
September 7, 2026 10:21
Collaborator
|
Closed as superseded, with thanks for isolating it: #668 landed first and regenerated the same six map table headers against the unit's new vocabulary (the constants moved again with its three units), so main's block zero-cost gate is green at 123 sources byte-identical. This branch's six files were pinned against the compiler before #668 and differ from main's now; merging them would make main stale again. Nothing else in the diff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generated-code check on current main fails for six map table headers added with the expanded map-value corpus. This also blocks unrelated PRs, including #669: CI run 34109282889 reports CellsTable.h, ChunksTable.h, DocsTable.h, RunsTable.h, SlotsTable.h and SpansTable.h as moved.
Refresh only those six snapshots with the compiler from main dcdd5cd. The generated differences carry the existing retained-payload handling for union/enum references, plus the existing message-form UTF-8 validation and code-point clamp for string keys in Cells and Docs. No emitter, schema, workflow or runtime code changes.
Validation: reproduced
make tables-block-zero-costfailing on exactly these six files before the refresh; after it, the gate passes and reports all 117 table sources byte-identical to their pins. Reviewed the generated diff and passedgit diff --check.This is separate from #669's certification queue policy. Land this correction and carry current main into that PR before expecting its generated check to pass.