Skip to content

Re-arm SocketAddress.Size before every ReceiveFrom (fixes the red net8.0 leg) #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rowan-claude merged 1 commit into from
Aug 7, 2026
Merged

Re-arm SocketAddress.Size before every ReceiveFrom (fixes the red net8.0 leg) #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/Netcode.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1896,6 +1896,14 @@ public void SendPacket(in Address to, ReadOnlySpan<byte> packetData)
/// <summary>Non-blocking receive. Returns 0 when no packet is available.</summary>
public int ReceivePacket(ref Address from, Span<byte> packetData)
{
// ReceiveFrom requires Size >= the family maximum before every call, and
// .NET 8 overwrites Size BEFORE checking the recvfrom result — so an empty
// poll (EWOULDBLOCK, the common case on a non-blocking socket) zeroes it
// and the next call throws ArgumentOutOfRangeException ("SocketAddress is
// too small"). .NET 9 moved that assignment after the error check. Re-arm
// the size each call; it is a field store, nothing allocates.
_receiveAddress.Size = SocketAddress.GetMaximumAddressSize(_socket.AddressFamily);

int result;
try
{
Expand Down