Skip to content

test(evals): cover open Optional issue scenarios#75

Draft
martinfrancois wants to merge 3 commits into
mainfrom
issue-sweep/eval-coverage-2026-07-03
Draft

test(evals): cover open Optional issue scenarios#75
martinfrancois wants to merge 3 commits into
mainfrom
issue-sweep/eval-coverage-2026-07-03

Conversation

@martinfrancois

@martinfrancois martinfrancois commented Jul 3, 2026

Copy link
Copy Markdown
Owner

Summary

Adds reference-suite coverage for the currently open actionable Java Optionals issues:

  • Optional presence selecting an enum value
  • equivalent-match findAny choices
  • Optional domain selection and lazy fallback
  • Optional upsert side-effect boundary
  • side-effecting present/empty branches with ifPresentOrElse
  • lifecycle helper boundaries that bind Optional values before domain validation

Also updates scripts/run_eval_suite.sh to work with the current Tessl eval CLI, avoid default Sonnet pinning, force fresh hosted solutions, and pass --skill java-optionals for with-context readiness evidence.

A follow-up CI commit migrates the optionals skill-review workflow and local contributor references from the legacy tessl skill review command to tessl review run --workspace martinfrancois, matching the command that passes locally and the streams repo workflow.

Dependency Dashboard remains untouched because it is Renovate-managed.

Closes #74
Closes #72
Closes #71
Closes #70
Closes #69
Closes #67

Validation

Local:

  • python3 scripts/validate_skill.py skills/java-optionals
  • python3 scripts/validate_eval_criteria.py evals evals-reference evals-regression
    • passes with pre-existing main-suite runtime-reference overlap warnings for scenarios 04, 10, 11, and 50
  • python3 -m py_compile scripts/*.py
  • bash -n scripts/*.sh
  • python3 scripts/validate_json_files.py
  • python3 scripts/validate_openai_agent_yaml.py
  • git diff --check
  • tessl plugin lint .
  • bash scripts/check_publish_dry_run.sh .
  • tessl plugin publish --dry-run --bump patch .

Hosted review:

  • 019f25dc-8c94-75d9-af80-e920b56ce6a8 - 100% quality review using tessl review run --workspace martinfrancois --threshold 100 skills/java-optionals/SKILL.md

Hosted eval evidence, with-context 100 after the last relevant scenario change:

  • 019f25be-5cb1-764f-ad3c-0ce7443d7e6c - scenarios 52, 53
  • 019f25c6-c40e-726d-8713-b3580fceb1b0 - scenario 54
  • 019f25ca-c7dd-727e-8d79-3d23d94889fd - scenarios 51, 55
  • 019f25d5-4a55-721b-9464-d4aa5a86d9a3 - scenario 56

CI:

  • Validate skill and plugin: passing
  • Commitlint: passing
  • CodeQL: passing
  • Tessl skill review: failing with 401 Unauthorized from GitHub Actions despite the same tessl review run --workspace martinfrancois command passing locally. This appears to require rotating or fixing the repository TESSL_TOKEN secret; the secret value is not readable from the workflow or local checkout.

publish --dry-run . without a version bump fails as expected because martinfrancois/java-optionals@1.0.0 already exists. No real Tessl publish was run.

Detect whether the installed Tessl CLI uses --variant or --skip-baseline, run the default solver unless an agent is explicitly passed, and force hosted evals to exercise java-optionals with fresh solutions.
Add reference scenarios for the open Optional behavior issues around enum selection, equivalent-match terminals, domain selection, upsert side-effect boundaries, side-effecting branches, and lifecycle helper boundaries.
Migrate the optionals skill-review workflow and local contributor references from the legacy tessl skill review command to tessl review run with the martinfrancois workspace.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment