fix: exclude structurally quarantined events from incremental projection#135
Merged
erskingardner merged 1 commit intoJun 29, 2026
Merged
Conversation
The incremental projection path added in #133 (project_file_events) filtered only on parse_status=VALID, missing the structural_quarantine_exclusion() that the full-rebuild path applies. A structurally quarantined v2 upload (multiple engine_ids/account_refs) therefore leaked projection rows — DeliveryArtifact and friends — for the group, even though its events must be dropped wholesale. Apply the same exclusion on the ingest hot path so quarantined uploads project nothing, matching rebuild_locked_group_projections. Fixes the master CI failure in test_rebuild_skips_structurally_quarantined_v2_files. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Ready to review this PR? Stage has broken it down into 1 individual chapter for you:
Chapters generated by Stage for commit 7243f4e on Jun 29, 2026 12:56pm UTC. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughAdds ChangesIncremental projection filter update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Master CI is red on
test_rebuild_skips_structurally_quarantined_v2_files:The first failing run was #133 ("project uploaded audit events incrementally"), which switched the ingest hot path from a full
rebuild_group_projections(clear + re-project) to the new incrementalproject_file_events.Cause
The full-rebuild path (
rebuild_locked_group_projections) filters its events withstructural_quarantine_exclusion(), which drops every event belonging to a structurally quarantined upload (multipleengine_ids /account_refs — the whole file's attribution is untrustworthy). The new incremental path filtered only onparse_status=VALID, so a quarantined upload's events were still projected, leakingDeliveryArtifact(and other projection rows) for the group.Fix
Add
structural_quarantine_exclusion()to theproject_file_eventsevent query so the incremental path drops quarantined uploads wholesale, exactly as the full rebuild does.Verification
test_rebuild_skips_structurally_quarantined_v2_filesnow passes.just checkgreen (194 tests, ruff, format, migrations check).🤖 Generated with Claude Code
Summary by CodeRabbit