Repository navigation
fix(storage): allow currency and unicode symbols in file path sanitization - #120
Open
markusbrand wants to merge 1 commit into
Open
markusbrand wants to merge 1 commit into
markusbrand wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where file and folder path segment sanitization rejected filenames containing the ASCII dollar sign (
$) and Unicode currency or symbol characters (€,£,¥,©,™,°, etc.) or Office temporary lockfiles (~$Document.docx).When users uploaded or synced these files, the server returned
400 Bad Request: Unsafe path segment, causing persistent sync failures and warning states on desktop clients.Changes
backend/app/files/storage.py):_SAFE_SEGMENT_ASCIIregex to include$._is_safe_path_charto allow$and Unicode categoryS(symbols, including currencySc, mathSm, modifierSk, and other symbolsSo).backend/tests/test_storage.py):resolve_user_pathaccepts$,€,£,¥,~$Doc.docx,©,™, and°.fix-storage-symbol-path-sanitizationchange specification artifacts.Verification
PYTHONPATH=backend .venv/bin/python -m pytest backend -q(110 passed)../scripts/run-qa.sh(all components passed: client-tauri, web, backend, docs).