Repository navigation
fix(export): render HTML tables and preserve vertical alignment - #752
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raw HTML tables were escaped by the shared preview renderer, so HTML and PDF exports printed HTML source instead of a table. Render block HTML through the editor's existing sanitizer and preserve
vertical-alignso merged cells honor authored alignment in the editor, preview, and export.Regression tests cover merged rows and columns, HTML blocks inside quotes and lists, image path resolution, unsafe HTML filtering, document updates, and editor recreation. Fenced HTML remains code. No new dependencies or changes to authored Markdown are required.
Closes #750
Validation
pnpm --filter @markra/editor test -- src/raw-html-sanitize.test.ts src/codemirror/html-table-widget.test.ts src/codemirror/raw-html-preview.test.ts— 58 tests passed.pnpm --filter @markra/app test -- src/components/MarkdownExportDocument.test.tsx src/components/MarkdownPreviewDocument.test.tsx src/lib/document-export.test.ts— 24 tests passed.pnpm --filter @markra/app typecheck:testandpnpm --filter @markra/editor typecheck:test— passed.pnpm build— all workspace builds passed, including desktop and web bundles and the desktop vendor chunk check.Windows native export was not run on this macOS host; the shared export renderer and Chromium PDF output were verified.