Repository navigation
feat(export): show completion notices with file location actions - #745
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exported documents previously had no completion feedback, and HTML/PDF save failures were silently ignored. Desktop exports now show a bottom-right notice with the actual saved filename and a Show in folder action. The notice lasts 10 seconds and can be dismissed.
Applies to HTML, PDF, Markdown bundles, DOCX, EPUB, and LaTeX. Cancelled saves remain silent; failures are reported, including folder-opening failures. Pandoc setup guidance is preserved. Browser download/print results do not trigger a local-file success notice because they do not confirm a saved file. Includes translations for all 11 supported languages.
Closes #744.
Validation
corepack pnpm --filter @markra/app exec vitest run src/App.test.tsx src/lib/app-toast.test.ts src/lib/document-export.test.ts src/components/MarkdownExportDocument.test.tsx -t 'export|Export|Pandoc|appToast'— 52 passed.corepack pnpm --filter @markra/shared exec vitest run src/i18n/index.test.ts --environment jsdom --globals— 5 passed.corepack pnpm --filter @markra/app build— passed.corepack pnpm --filter @markra/app typecheck:test— passed.corepack pnpm --filter @markra/desktop build— passed, including vendor chunk verification.git diff --check— passed.Native desktop click-through QA was not run. The existing notification component and native file-manager command are reused; no native export implementation changed.