fix: treat skipped CI jobs as failure, not pending#43
Open
markpolyak wants to merge 2 commits intomainfrom
Open
fix: treat skipped CI jobs as failure, not pending#43markpolyak wants to merge 2 commits intomainfrom
markpolyak wants to merge 2 commits intomainfrom
Conversation
GitHub Actions conclusion "skipped" is a terminal state (job did not run due to a branch/event condition), not an in-progress one. Previously it fell into the else-branch and set has_pending=True, causing the grader to return "CI-проверки ещё выполняются ⏳" instead of a failure result. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Проблема
При проверке работы, где один из CI-джобов имел статус
skipped, система возвращала «CI-проверки ещё выполняются ⏳» вместо сообщения о провале тестов.Причина: в
evaluate_ci_resultsветкаelseобрабатывала любой статус, не являющийсяsuccessилиfailure, как pending — включаяskipped. В результатеhas_pending = True, и grader возвращал PENDING вместо failure.Исправление
skippedв GitHub Actions — терминальный статус (джоб не запустился из-за условияif:). По смыслу совпадает сfailure: тест не прошёл успешно.grading/ci_checker.py: объединены"failure"и"skipped"в одну ветку → ❌tests/test_ci_checker.py: добавлены 3 теста дляskipped-сценариевТесты
🤖 Generated with Claude Code