Add timeout and connection error handling to GitHubClient#42
Open
markpolyak wants to merge 1 commit intomainfrom
Open
Add timeout and connection error handling to GitHubClient#42markpolyak wants to merge 1 commit intomainfrom
markpolyak wants to merge 1 commit intomainfrom
Conversation
Add DEFAULT_TIMEOUT=30s to all GitHub API requests to prevent indefinite hangs on network issues. Wrap get_job_logs in try/except RequestException so transient network errors return None instead of propagating a 500 to the user. Add tests for get_job_logs: success, HTTP 404, and ConnectionError cases. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
DEFAULT_TIMEOUTconstant (30s) to GitHubClientrequests.get()calls in API methodsget_job_logs()to gracefully handleRequestExceptionget_job_logs()covering success, HTTP errors, and connection errorsWhy
Improves reliability by preventing indefinite hangs on network issues and providing graceful degradation instead of raising exceptions.