PDP-1273 Added read method for Command#644
Open
rjrudin wants to merge 1 commit into
Open
Conversation
For internal use.
rjrudin
force-pushed
the
feature/command-read
branch
from
eba375f to
0045f9b
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new read capability to the CLI command abstraction so internal callers can obtain a Spark Dataset<Row> from a command without executing a write/count/preview flow.
Changes:
- Added a default
Command.read(SparkSession)method that throwsUnsupportedOperationExceptionby default. - Implemented
read(SparkSession)inAbstractCommandby delegating to the existing dataset-loading pipeline (readDataset).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| flux-cli/src/main/java/com/marklogic/flux/impl/Command.java | Introduces new read method on the command interface (default unsupported). |
| flux-cli/src/main/java/com/marklogic/flux/impl/AbstractCommand.java | Provides a concrete read implementation for commands that already load a dataset. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| */ | ||
| void execute(SparkSession session); | ||
|
|
||
| default Dataset<Row> read(SparkSession session) throws Exception { |
Comment on lines
+53
to
+54
| public Dataset<Row> read(SparkSession session) throws Exception { | ||
| return readDataset(session); |
BillFarber
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For internal use.