MLE-29542 Added default implementations for new API methods#643
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds default implementations for newly introduced API methods to prevent breaking existing implementers, primarily around S3 anonymous access and a basic connection string helper.
Changes:
- Added default
s3AnonymousAccess()implementations that throwUnsupportedOperationExceptionfor backward compatibility. - Added a default
connectionStringBasic(String)implementation delegating toconnectionString(String). - Applied the same defaulting pattern across multiple option interfaces.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| flux-cli/src/main/java/com/marklogic/flux/api/WriteFilesOptions.java | Adds default s3AnonymousAccess() that throws by default. |
| flux-cli/src/main/java/com/marklogic/flux/api/ReadFilesOptions.java | Adds default s3AnonymousAccess() that throws by default. |
| flux-cli/src/main/java/com/marklogic/flux/api/GenericFilesExporter.java | Adds default s3AnonymousAccess() to nested write-options interface. |
| flux-cli/src/main/java/com/marklogic/flux/api/Executor.java | Adds default connectionStringBasic() delegating to connectionString(). |
| flux-cli/src/main/java/com/marklogic/flux/api/CustomImporter.java | Adds default s3AnonymousAccess() to nested read-options interface. |
| flux-cli/src/main/java/com/marklogic/flux/api/CustomExportWriteOptions.java | Adds default s3AnonymousAccess() that throws by default. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+26
to
+29
| default T s3AnonymousAccess() { | ||
| // Default implementation for backwards compatibility. | ||
| throw new UnsupportedOperationException("S3 anonymous access is not supported in this implementation"); | ||
| } |
| T s3AnonymousAccess(); | ||
| default T s3AnonymousAccess() { | ||
| // Default implementation for backwards compatibility. | ||
| throw new UnsupportedOperationException("S3 anonymous access is not supported in this implementation"); |
Comment on lines
+29
to
+32
| default CustomExportWriteOptions s3AnonymousAccess() { | ||
| // Default implementation for backwards compatibility. | ||
| throw new UnsupportedOperationException("S3 anonymous access is not supported in this implementation"); | ||
| } |
Comment on lines
+52
to
+55
| default T connectionStringBasic(String connectionString) { | ||
| // Default implementation for backwards compatibility. | ||
| return connectionString(connectionString); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.