Skip to content

fix(feed): add ping_interval/ping_timeout to prevent zombie WebSocket #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AkhilSharma1 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(feed): add ping_interval/ping_timeout to prevent zombie WebSocket #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions openalgo/feed.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,16 @@ def on_close(ws, close_status_code, close_reason):
on_close=on_close
)

# Start WebSocket connection in a separate thread
self.ws_thread = threading.Thread(target=self.ws.run_forever)
# Start WebSocket connection in a separate thread.
# ping_interval sends a WebSocket ping every 20s so the OS-level TCP
# connection cannot become a silent "zombie" (broker stops streaming
# ticks but the socket appears OPEN with no error). ping_timeout
# closes and triggers on_close if the pong is not received within
# 10s, allowing the caller to detect and reconnect.
self.ws_thread = threading.Thread(
target=self.ws.run_forever,
kwargs={"ping_interval": 20, "ping_timeout": 10},
)
self.ws_thread.daemon = True
self.ws_thread.start()

Expand Down