Repository navigation
fix(deflist): map complete term source lines - #26
Open
awais-ur-rehman wants to merge 1 commit into
Open
awais-ur-rehman wants to merge 1 commit into
awais-ur-rehman wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Definition terms currently report
map: [line, line]for bothdt_openand its inline token. That describes an empty source range: code that associates a source line with its preview token usingstart <= line && line < endcannot match a term. Useline + 1as the exclusive end, matching a one-line paragraph's map.Tests check the term and inline ranges for a single term, multiple terms, a term inside a blockquote and a term after a paragraph. A paragraph comparison verifies the exclusive-end convention. Rendered output is unchanged and the existing fixture/build tests continue to pass.
Testing
Validation on Node.js 24.19.0:
npm test(ESLint, Rollup builds and complete node:test suite), plusgit diff --check. All five source-map regressions failed before the fix. No browser integration was run locally.Assisted by OpenAI Codex for diagnosis, implementation and test execution.
Breaking Changes
None.
Manual verification: Parse a one-line definition term: dt_open and its inline token should both map to [line, line + 1], consistent with a one-line paragraph.