Open
Conversation
Updated the readme to reference the github action correctly
Author
|
I just noted that an input field for |
|
Hey! I was also affected by this and it took me lot of time to understand that the example was not accurate. Can we merge this PR so that nobody else is affected? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello i updated the Readme to refer to the action correctly. you also have version v5 and not v1 anymore, alternatively you can refer to a brain such as @main but that is not best practice.
There is another part i dont know how to really document as i just started playing with this action today. but the
firstHeadingPageTitleoption should be commented somewhere for this action as its super useful for people. I found it by looking around documentation for other stuff inside this project. I would recommend that you add a short explanation to the project for it.