Conversation
"Send query telemetry" governs the table, column and filter values that a query event carries. The main switch keeps working on its own, so a user can report usage without reporting content.
The studio_telemetry table takes no new columns, so every new field goes in props. The server drops a props object above its cap instead of cutting it, so fitProps degrades the object in steps first.
Eleven of eighteen routes sent only a page view. The node, browser, builder and workbench events fill that gap, and every query event now carries the table, the columns and the filters that ran.
The event name list is closed on both sides, and the table takes no new columns. Both facts cost a silent data loss when missed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
d2a2c70 Document the telemetry rules in AGENTS.md
cc10011 Report query shape and feature use at call sites
4f47c63 Carry query shape and client context in events
0b4c454 Add Telemetry settings group and query opt-out