Fix sidebar active state, map popup and feedback - #127
Merged
Merged
Conversation
The Queries and Workspace menus link to a child page, so the header only matched that one child. They now pass a section root to match on. The map popup prepended the clicked row to the similar-row results, which already contain it. Feedback opens the web form instead of the in-app modal.
marisbv
approved these changes
Sep 16, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues were identified.
Pull request overview
This PR fixes sidebar highlighting, removes duplicate map popup rows, and opens feedback in an external form.
Changes:
- Add section-root matching for sidebar menus.
- Prevent duplicate rows in map popups.
- Replace the in-app feedback modal with external navigation.
File summaries
| File | Description |
|---|---|
src/lib/feedback.ts |
Builds and opens feedback URLs. |
src/lib/components/sidebar/SidebarCollapsibleMenu.svelte |
Supports section-root active matching. |
src/lib/components/sidebar/AppSidebar.svelte |
Configures menu roots and feedback navigation. |
src/lib/components/modals/FeedbackModal.svelte |
Removes the obsolete modal. |
src/lib/components/MapPopupContent.svelte |
Avoids duplicate popup rows. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Queries and Workspace menus link to a child page, so the header only matched that one child. They now pass a section root to match on.
The map popup prepended the clicked row to the similar-row results, which already contain it.
Feedback opens the web form instead of the in-app modal.