Conversation
Serialize chat deletion with the existing save queue, keep attachments and pending saves after a failed deletion, and report failure to the user. Stop graph animation callbacks after settling, pause hidden documents, and repaint explicitly for theme and interaction changes. Validate shared supertag schemas once per note-list result. Add regression tests and document the macOS review, measured work-count checks, deferred architectural changes, and native validation gates. No schema migration, native identity, editor format, or release changes.
|
Hi! I'm the It looks like you correctly set up a CI job that uses the autofix.ci GitHub Action, but the autofix.ci GitHub App has not been installed for this repository. This means that autofix.ci unfortunately does not have the permissions to fix this pull request. If you are the repository owner, please install the app and then restart the CI workflow! 😃 |
autofix.ci
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b994d85. Configure here.
| return | ||
| } | ||
| await deleteChatConversation(id, generation) | ||
| deletedConversationsRef.current.add(id) |
There was a problem hiding this comment.
Stale delete blocks later retries
Medium Severity
A generation mismatch makes deleteChatConversation resolve without removing the row. That path still adds the id to deletedConversationsRef, so the new early return refuses another delete for the rest of the session. History can show the conversation again, while later saves and retries stay blocked.
Reviewed by Cursor Bugbot for commit b994d85. Configure here.
2 participants
Result
Code re-review complete at
b994d8562bc6ed4ac941e620dded875d8761649cagainstmaster(157b141aed667167d96f5f479b49848fa010ecb8). All CI jobs passed, including the finalall-greengate: CI run 35263725469.Merge recommendation: ready for this contained code change. No merge or release has been performed.
Changes
Follow-up that resolved the CI failure
The old save-order test suspended every mocked write but released only one. The corrected implementation waits for both the user-half and settled-turn saves, so that fixture deadlocked and disrupted subsequent tests.
The replacement test now gates both writes independently, verifies deletion has not run after releasing only the first, then releases the second and asserts exactly one deletion. It releases both gates in
finally. No test was skipped and no existing timeout or assertion was relaxed. The entire 32-test ChatProvider suite now passes; this is no longer a result inferred only from isolated checks.Added
graph-map-canvas.test.tsxover the real browser canvas, layout and frame scheduler. It checks settled theme/search repaint, note navigation, idle empty graphs and disposal. Existing regression tests cover failed-delete recovery, queued-save guards, frame visibility/coalescing, and query-local schema caching.Verified on the current head
No merge conflicts or unresolved review threads were found. This is the implementation author's re-review, not an independent approval.
Scope and remaining release validation
No database migration, note-format/editor change, native IPC change, dependency change, signing/entitlement/iCloud change or release change. Broader invalidation, pagination, streaming and ChatSession refactors remain out of scope.
The initial audit's conservative manual-smoke-before-merge recommendation is updated by this assessment after adding real-canvas integration coverage and observing the full WebKit-on-macOS suite pass. Native packaged-app smoke testing remains a release validation step and has not been performed here. Playwright WebKit is not a claim of testing the signed Tauri app, native window occlusion/App Nap, or battery/memory performance. No measured app-wide speedup is claimed.
docs/macos-maintenance-review-2026-09-17.mdrecords the original audit and initial local checks; this PR description is the subsequent CI verification record. The earlier failed/pending CI statuses do not describe the current head.Note
Medium Risk
Chat deletion and save-queue ordering touch persistence and race-prone conversation lifecycle; graph scheduling changes animation and theme repaint timing in a user-facing canvas.
Overview
Chat deletion now runs inside the per-conversation save queue instead of marking conversations deleted up front. The DB delete must succeed before the deleted guard applies; a failure shows an error toast and leaves history, attachments, and queued saves intact for retry. Successful deletes still block later saves from resurrecting the row. New provider tests cover failed-delete recovery and save-vs-delete ordering (including waiting for both send and settle writes).
Graph map canvas replaces the always-on
requestAnimationFrameloop withcreateGraphFrameScheduler, which coalesces repaint requests, stops when the layout is settled or empty, pauses when the document is hidden, and tears down on unmount. Interaction, resize, search highlights, and root theme attribute changes wake repaints without reheating the force layout; browser tests cover theme/search repaint, idle empty graphs, and disposal.Note listing validates each distinct serialized supertag schema once per
listNotes()call via a query-local cache, preserving Inbox semantics and SQL behavior.Reviewed by Cursor Bugbot for commit b994d85. Bugbot is set up for automated code reviews on this repo. Configure here.