fix completions in slides view#9769
Open
Light2Dark wants to merge 3 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Python/Jedi autocompletions in the slides “show code” editor by ensuring the slide cell editor wrapper has the same cell-identifying DOM attributes/id convention used elsewhere in the app (so the active cell can be discovered via HTMLCellId.findElement(...)).
Changes:
- Import and reuse
cellDomPropsin the slides cell editor view. - Apply
cellDomProps(cell.id, cell.name)to the slide cell editor wrapperdivso it gets anidlikecell-<CellId>plusdata-cell-*attributes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Jedi requires cell-id props to resolve completions. This adds a fix to the slide cell editor.
Also hides the inline "Edit with AI" tooltip for slides. It's trickier to position it correctly, and I think for slides, this is a better default anyways.
📋 Pre-Review Checklist
✅ Merge Checklist