fix: resolve blank slides and broken links in server-side PDF export (#10501) - #10560
Open
Jacopos311 wants to merge 2 commits into
Open
fix: resolve blank slides and broken links in server-side PDF export (#10501)#10560Jacopos311 wants to merge 2 commits into
Jacopos311 wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Jacopos311
force-pushed
the
fix-pdf-slides-export
branch
from
August 14, 2026 23:25
0ba1c67 to
1f5958e
Compare
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
recheck |
Jacopos311
force-pushed
the
fix-pdf-slides-export
branch
from
August 14, 2026 23:34
4d30617 to
50f6930
Compare
Jacopos311
force-pushed
the
fix-pdf-slides-export
branch
from
August 15, 2026 00:10
19aa600 to
4bf2fd2
Compare
Jacopos311
force-pushed
the
fix-pdf-slides-export
branch
from
August 15, 2026 00:16
f795e84 to
d8063c6
Compare
for more information, see https://pre-commit.ci
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10501
📝 Summary
This pull request resolves an issue where exporting slide decks containing plots or interactive outputs to PDF resulted in blank slides or broken links.
Specific Changes Made:
marimo/_server/api/endpoints/export.py): Updated theexport_as_pdfhandler to collect PNG fallbacks viacollect_pdf_png_fallbacks()wheninclude_outputsis enabled and a session view is present. These fallbacks are now successfully passed down viaPDFExportRequest, bringing the server-side export flow in line with the CLI flow.marimo/_export/exporter.py): Added_inline_virtual_files_in_notebook()to resolve./@file/...virtual file references into inline data URIs inside notebook cell outputs prior to nbconvert processing. This ensures assets load correctly when rendered locally viafile://URIs.marimo/_export/exporter.py): Added an explicitDependencyManager.playwright.require()check inside_export_slides_as_pdf()to ensure a clean, user-friendly error message if Playwright/Chromium binaries are missing, instead of a rawModuleNotFoundError.tests/_export/test_exporter.py): Added dedicated unit tests covering slides PDF export with PNG fallbacks and virtual file inlining behavior.📋 Pre-Review Checklist
✅ Merge Checklist