Refactor layout tabs to prevent unnecessary re-renders#614
Open
marcodejongh wants to merge 2 commits intomainfrom
Open
Refactor layout tabs to prevent unnecessary re-renders#614marcodejongh wants to merge 2 commits intomainfrom
marcodejongh wants to merge 2 commits intomainfrom
Conversation
Extract tab contents into memoized components and use useMemo for the tabItems array to prevent the Ant Design Tabs useIndicator hook from causing infinite re-renders when queue state changes. The root cause was that tabItems array was recreated on every render, causing the Tabs component to continuously recalculate its indicator position. By memoizing the array and extracting children into stable React.memo components, each tab's content manages its own queue context subscription independently.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Claude Review✅ Ready to merge - Minor issues noted below, but nothing blocking. Issues
Notes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactored the tab layout component to improve performance by preventing unnecessary re-renders and better separating concerns. Each tab now manages its own state subscriptions rather than having a single parent component subscribe to all contexts.
Key Changes
TabsWrapperinto separate memoized components (QueueTabLabel,QueueTabContent,SearchTabContent,HoldsTabContent) to isolate state subscriptions and prevent cascading re-rendersQueueTabLabelnow directly subscribes to queue context for the badge count, whileQueueTabContenthandles queue operations independentlyuseMemofortabItemsarray anduseCallbackforhandleClearQueueto prevent unnecessary re-renders when props haven't changed@playwright/test,@types/react,bufferutil,node-gyp-build,playwright, andplaywright-corefromdev: truetodevOptional: truein package-lock.json. Removeddev: trueflag fromreact,react-dom, andschedulerto make them production dependenciesImplementation Details
React.memo()and has adisplayNamefor better debugginghandleClearQueuecallback now capturesitemsClearedbefore clearing the queue to ensure accurate trackingboardDetailsas the only dependency, reducing re-computation when queue state changes