Skip to content

feat(ui): mirror auto helpers on tab headers - #1495

Merged
marcinz606 merged 1 commit into
mainfrom
feat/tab-header-auto-mirrors
Oct 24, 2026
Merged

marcinz606 merged 1 commit into
mainfrom
feat/tab-header-auto-mirrors

Conversation

@marcinz606

Copy link
Copy Markdown
Owner

Summary

  • Exposure tab header: Auto wand beside Pick Better. It opens the Tone card's own Auto menu (same QMenu), so both stay in step.
  • Geometry tab header: Auto Crop and Square to Film mirrors.
  • Finish tab header: Optical Removal and IR Removal mirrors. IR hides when the scan has no infrared channel, same as in the card.
  • TabHeader.add_mirror(source) forwards clicks to the card button and follows its check, enabled state and explicit hide (ShowToParent/HideToParent, so it works while the card is collapsed). Shortcut tooltips on the mirrors come from apply_shortcut_tooltips.
  • IR has one icon now: mdi6.heat-wave on IR Removal, the Scan IR toggle and the IR choice. ICE keeps the broom.
  • User guide: the four mirrored controls and Auto say they are also on the tab's bar; ja/ko/zh_CN guide panels updated with new src: hashes.

Test plan

  • tests/test_tab_header.py: mirror forwards clicks, follows check/hide/enable, one-shot stays uncheckable, Auto mirror shares the menu
  • Affected suites (controls panel, retouch, scan, i18n, toggle look, shortcut tooltips), lint, type
  • Headless app drive (Xvfb): all three headers render, Auto Crop mirror toggles the card button, IR mirror hides/shows with the card's IR button

Exposure tab header gets the Auto wand beside Pick Better; it opens the
Tone card's own Auto menu, so both stay in step. Geometry header mirrors
Auto Crop and Square to Film; Finish header mirrors Optical Removal and
IR Removal (hidden when the scan has no infrared channel).

TabHeader.add_mirror forwards clicks to the card button and follows its
check, enabled state and explicit hide, also while the card is collapsed.

IR gets one icon (mdi6.heat-wave) on IR Removal, the Scan IR toggle and
the IR choice; ICE keeps the broom.
@marcinz606
marcinz606 merged commit e5d6757 into main Oct 24, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant