fix: multi-server hardening — code correctness, security fixes, and expanded test coverage - #21

Closed

marcinpsk wants to merge 49 commits into

pr/librenms-id-multi-serverfrom

pr/librems-id-multi-fixes

Commits on Mar 9, 2026

fix: use validated-cache namespace for BG job gate + unconditional VC sync delegation
marcinpsk
committed
582481a
feat: multi-server librenms_id with JSON custom field and server management
marcinpsk
committed
c716d9b
fix: strip stale derived fields in cable verify POST, preserve server_key in sync redirects
marcinpsk
committed
175bd06
fix: reviewer findings — XSS, bool guards, cache TTL, VM safety, legacy display
marcinpsk
committed
df11f56
fix: code correctness improvements from refactor/librenms_id-rebased
marcinpsk
committed
6ba4aa1
tests: expand test coverage from refactor/librenms_id-rebased
marcinpsk
committed
b16d4a2
docs: update testing.md with additional test files and conventions
marcinpsk
committed
cda4bde
fix: reviewer findings batch 2 — XSS escape, bool guards, auto_save, locked-row recheck, aria-labels, tests
marcinpsk
committed
b501203
fix: resolve server_key from api when available in validate_device_for_import
marcinpsk
committed
5db057a
fix: reviewer findings batch 4 — error surfacing, cache TODO, proxy removal, tests
marcinpsk
committed
6b440de
fix: reviewer findings batch 6 — naming prefs resolver, test assertion
marcinpsk
committed
3446747
fix: update test to match HEAD naming-source 'both empty' guard behavior

marcinpsk
and
Copilot
committed
0ba62f9
style: ruff format
marcinpsk
committed
94799cc
fix: avoid auto-discovery in VC member librenms_id check
marcinpsk
committed
428224b
fix: pass copied request to sub-view get_context_data in vms.py; warn on ambiguous DeviceTypeMapping
marcinpsk
committed
605e400
fix: propagate server_key through cable enrichment methods
marcinpsk
committed
5447cfd
fix: address valid PR #25 findings — common fixes
marcinpsk
committed
e1e81ca
fix: address two new PR #25 findings — Convert ID form target + server_key=None in sync device lookup
marcinpsk
committed
45c372a
tests: add coverage tests for 8 target files (all >95%)
marcinpsk
committed
020d0c9
PR #25 fixes: VC guard, forms cache, virtual_chassis, vm_operations, tests
marcinpsk
committed
835f96b
fix: always delegate VC lookup to get_librenms_sync_device; fix None type/os filters
marcinpsk
committed
99f135e
fix: address PR #25 review findings (threads 23-28)
marcinpsk
committed
f0e2337
fix: port PR #22 common fixes + add list.py coverage tests
marcinpsk
committed
40bcf74
fix: multiple code hardening and test improvements
marcinpsk
committed
b8a1a2b
Create pull request template for contributions

bonzo81
authored and
marcinpsk
committed
ac6b290
Remove checkbox to avoid task creation

bonzo81
authored and
marcinpsk
committed
96f379c
fix: apply reviewer fixes (Threads 34-55) to pr/librems-id-multi-fixes
marcinpsk
committed
971e0c5
Update pyproject.toml
marcinpsk
committed
b4fed7a
fix: batch 4 — ID zero guard, addresses list, hard-block collision, stale role reset
marcinpsk
committed
2d80ab6
fix: validate inventory response shape in get_device_inventory
marcinpsk
committed
b71c51b
fix: librenms_id zero guard in discovery branches
marcinpsk
committed
94764c1
fix: RQ-first cancellation in bulk_import_vms, C901 comment clarification
marcinpsk
committed
5dc50e3
fix: always pass api into validate_device_for_import, hardware lookup not gated by VC flag
marcinpsk
committed
bdf0c00
Fix payload shape guards for list_devices, get_device_vlans, get_inventory_filtered; read VM role from validation
marcinpsk
committed
8aa9e71
fix: batch-6 CodeRabbit review — isinstance guards, VC domain fingerprint, double VC refresh, stale device_role, VC master position, strip_domain threading, test improvements
marcinpsk
committed
6310439
fix: batch-7 CR — strip_domain TypeError, vlans fallback guard, device_role schema, test class dedup
marcinpsk
committed
bf7ab57
Create pull request template for contributions

bonzo81
authored and
marcinpsk
committed
99d6868
Remove checkbox to avoid task creation

bonzo81
authored and
marcinpsk
committed
9ce45bf
fix: batch-8 CR — C901 comment, test name/docstring clarity, remove orphaned section header
marcinpsk
committed
8bc0fa5
fix: batch-9 CR — None guard, device_type sync, cable ID guard, test improvements
marcinpsk
committed
b6b9ebd
fix: cache negative VC detection results; add regression tests and mock server helpers
marcinpsk
committed
719669a
fix: check dcim.add_virtualchassis permission before VC creation on import
marcinpsk
committed
b793b79
fix: restore auto_save in get_librenms_id — normalize string IDs and persist
marcinpsk
committed
a35c236
fix: batch-10 CR — serial in VC name, master serial normalization, update_fields, Q string normalization, mapping fail-closed, test assertions, docs
marcinpsk
committed
11e6795
fix: skip create-only blockers for already-matched objects; add VM perms to bulk import gate
marcinpsk
committed
f9a3dbc
fix: thread vc_detection_enabled into import, store resolved server_key in job data, harden get_object fallback, fix existing device URL derivation
marcinpsk
committed
5f72979
fix: modules tab missing + issue #27 sync_name VM guard
marcinpsk
committed
e530a3e

Commits on Mar 10, 2026