Inventory rebased

.devcontainer/README.md

@@ -98,6 +98,8 @@ Below are the dev container defaults. The field name to change these defaults is
 - Plugin loader: enabled; reads `.devcontainer/config/plugin-config.py` if present
 - If `plugin-config.py` is missing: plugin is enabled with empty config (features won’t work until configured)
 
+
+
 ## 🔧 Configuration
 
 ### NetBox Version and Environment (use .devcontainer/.env)

.devcontainer/scripts/diagnose.sh

@@ -1,4 +1,5 @@
 #!/bin/bash
+# netbox-librenms-plugin devcontainer script
 
 echo "🔍 DevContainer Startup Diagnostics"
 echo "=================================="

.devcontainer/scripts/load-aliases.sh

@@ -1,4 +1,5 @@
 #!/bin/bash
+# netbox-librenms-plugin devcontainer script
 # Quick alias loader for current session
 # Usage: source .devcontainer/scripts/load-aliases.sh
 

.devcontainer/scripts/setup.sh

@@ -1,4 +1,5 @@
 #!/bin/bash
+# netbox-librenms-plugin devcontainer script
 set -e
 
 echo "🚀 Setting up NetBox LibreNMS Plugin development environment..."

.devcontainer/scripts/start-netbox.sh

@@ -1,4 +1,5 @@
 #!/bin/bash
+# netbox-librenms-plugin devcontainer script
 
 # Check if we should run in background or foreground
 BACKGROUND=false
@@ -18,7 +19,6 @@ if [ "$CODESPACES" = "true" ] && [ -n "$CODESPACE_NAME" ]; then
   echo "🔗 GitHub Codespaces detected"
 else
   ACCESS_URL="http://localhost:8000"
-  echo "🐛 Debug: ACCESS_URL is set to: $ACCESS_URL"
 fi
 
 # Load shared process management helpers

.devcontainer/scripts/welcome.sh

@@ -1,4 +1,5 @@
 #!/bin/bash
+# netbox-librenms-plugin devcontainer script
 
 # Ensure aliases are available in the postAttach terminal session
 source "$(dirname "$0")/load-aliases.sh" 2>/dev/null
@@ -44,7 +45,7 @@ if [ -n "$CODESPACES" ]; then
   echo "   💡 Click the link in the Ports panel or look for the 'Open in Browser' button"
 else
   echo "🖥️  Local Development Environment:"
-  echo "   NetBox will be available at: http://localhost:8000 (paste into you browser)"
+  echo "   NetBox will be available at: http://localhost:8000 (paste into your browser)"
 fi
 
 echo ""

.github/dependabot.yml

@@ -8,3 +8,7 @@ updates:
       github-actions:
         patterns:
           - "*"
+  - package-ecosystem: "uv"
+    directory: "/"
+    schedule:
+      interval: "weekly"

.github/pull_request_template.md

@@ -0,0 +1,49 @@
+## Summary
+Briefly describe what this PR does in plain English, and provide as much of the following information as possible.
+
+## Motivation / Problem
+What issue does this solve?
+- Bug
+- Feature
+- Refactor
+- Maintenance / cleanup
+
+Link any related issues if applicable.
+
+## Scope of Change
+Delete items that don’t apply:
+
+- Sync/Import logic
+- NetBox models / ORM
+- LibreNMS API interaction
+- Config / settings
+- Web UI / templates
+- Database migrations
+- Tests
+- Docs only
+- Other: <describe>
+
+## How Was This Tested?
+Delete items that don’t apply and describe briefly.
+
+- Unit tests: <yes/no + what>
+- Manual testing: <yes/no + what>
+- Not tested: <explain why>
+
+### Manual Test Steps (if applicable)
+1.
+2.
+3.
+
+## Risk Assessment
+- Does this change affect existing users?
+- Could this cause unintended imports / updates?
+
+Explain briefly.
+
+## Backwards Compatibility
+- No breaking changes
+- Breaking change (explain and document)
+
+## Other Notes
+Anything the maintainer(s) should pay particular attention to?

.github/workflows/lint-format.yaml

@@ -2,13 +2,7 @@ name: Lint and Format
 
 on:
   push:
-    branches:
-      - master
-      - develop
   pull_request:
-    branches:
-      - master
-      - develop
 
 jobs:
   format-and-lint:
@@ -20,31 +14,15 @@ jobs:
       - name: Set up Python
         uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5
         with:
-          python-version: '3.9'
-          cache: 'pip'
+          python-version: '3.12'
 
       - name: Install dependencies
         run: |
           python -m pip install --upgrade pip
           pip install ruff
 
       - name: Run Ruff linting
-        run: |
-          echo "::group::Ruff Linting"
-          ruff check . --output-format=github
-          echo "::endgroup::"
+        run: ruff check .
 
       - name: Run Ruff formatting check
-        run: |
-          echo "::group::Ruff Formatting"
-          ruff format --check .
-          echo "::endgroup::"
-
-      - name: Report formatting issues
-        if: failure()
-        run: |
-          echo "::error::Formatting or linting issues detected!"
-          echo "To fix locally, run:"
-          echo "  ruff check --fix ."
-          echo "  ruff format ."
-          echo "Then commit and push the changes."
+        run: ruff format --check .

.github/workflows/test.yaml

@@ -59,7 +59,7 @@ jobs:
         working-directory: netbox-librenms-plugin
         run: |
           pip install -e .
-          pip install pytest pytest-django
+          pip install pytest pytest-django pytest-cov
 
       - name: Set up configuration
         working-directory: netbox
@@ -75,4 +75,14 @@ jobs:
         env:
           NETBOX_CONFIGURATION: netbox.configuration
         run: |
-          python -m pytest ../../netbox-librenms-plugin/netbox_librenms_plugin/tests/ -v
+          python -m pytest ../../netbox-librenms-plugin/netbox_librenms_plugin/tests/ -v \
+            --cov=netbox_librenms_plugin \
+            --cov-report=html:../../netbox-librenms-plugin/coverage_html \
+            --cov-report=term-missing
+
+      - name: Upload coverage report
+        uses: actions/upload-artifact@v4
+        if: matrix.python-version == '3.12'
+        with:
+          name: coverage-report
+          path: netbox-librenms-plugin/coverage_html/

.pre-commit-config.yaml

@@ -1,6 +1,6 @@
 repos:
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: v0.14.13  # Use the latest version from https://github.com/astral-sh/ruff-pre-commit/releases
+    rev: v0.15.4  # Use the latest version from https://github.com/astral-sh/ruff-pre-commit/releases
     hooks:
       # Run the linter
       - id: ruff-check
@@ -14,5 +14,6 @@ repos:
       - id: trailing-whitespace
       - id: end-of-file-fixer
       - id: check-yaml
+        exclude: mkdocs\.yml$
       - id: check-added-large-files
       - id: check-merge-conflict

README.md

@@ -103,7 +103,7 @@ Alternatively, share your ideas for the plugin over in [discussions](https://git
 | NetBox Version | Plugin Version |
 |----------------|----------------|
 |     4.1        | 0.2.x - 0.3.5  |
-|     4.2 - 4.4       | 0.3.6+          |
+|     4.2 - 4.5       | 0.3.6+          |
 ## Installing
 
 

contrib/README.md

@@ -0,0 +1,28 @@
+# Contrib: Example Mapping Files
+
+This directory contains example YAML mapping files for bulk import into the
+NetBox LibreNMS Plugin. Each file can be imported via the plugin's bulk import
+feature in the NetBox UI.
+
+## How to Import
+
+1. Navigate to the mapping page (e.g., **LibreNMS → Device Type Mappings**)
+2. Click the **Import** button (upload icon) in the top right
+3. Select **YAML** format
+4. Paste the contents of the relevant YAML file
+5. Click **Submit**
+
+## Available Mappings
+
+| File | Description |
+|------|-------------|
+| `interface_type_mappings.yaml` | Maps LibreNMS interface types + speeds to NetBox interface types |
+| `device_type_mappings.yaml` | Maps LibreNMS hardware strings to NetBox device types |
+| `module_type_mappings.yaml` | Maps LibreNMS inventory model names to NetBox module types (incl. transceivers) |
+| `module_bay_mappings.yaml` | Maps LibreNMS inventory container names to NetBox module bay names |
+
+## Customisation
+
+These files are **examples** — adjust values to match the device types, module
+types, and interface types defined in your NetBox instance.  The `netbox_*`
+fields must reference objects that already exist in your NetBox.

contrib/device_type_mappings.yaml

@@ -0,0 +1,73 @@
+# Device Type Mappings
+#
+# Maps LibreNMS hardware strings to NetBox device types.
+# Import via: LibreNMS Plugin > Device Type Mappings > Import
+#
+# Fields:
+#   librenms_hardware    — Hardware string exactly as shown in LibreNMS
+#   netbox_device_type   — NetBox DeviceType (matched by model name or ID)
+#   description          — Optional note
+#
+# The librenms_hardware value is matched case-insensitively.
+# These mappings are checked BEFORE the built-in part_number/model fallback.
+
+# Juniper — LibreNMS reports verbose marketing names
+- librenms_hardware: "Juniper MX480 Internet Backbone Router"
+  netbox_device_type: "MX480"
+  description: "Juniper MX480 chassis"
+
+- librenms_hardware: "Juniper MX960 Internet Backbone Router"
+  netbox_device_type: "MX960"
+  description: "Juniper MX960 chassis"
+
+- librenms_hardware: "Juniper MX304 Edge Router"
+  netbox_device_type: "MX304"
+  description: "Juniper MX304 edge router"
+
+- librenms_hardware: "JNP10008 [PTX10008]"
+  netbox_device_type: "PTX10008"
+  description: "Juniper PTX10008 core router"
+
+- librenms_hardware: "JNP7100-32C [ACX7100-32C]"
+  netbox_device_type: "ACX7100-32C"
+  description: "Juniper ACX7100-32C"
+
+- librenms_hardware: "JNP7024 [ACX7024]"
+  netbox_device_type: "ACX7024"
+  description: "Juniper ACX7024"
+
+- librenms_hardware: "Juniper JNP10008 Internet Backbone Router"
+  netbox_device_type: "PTX10008"
+  description: "Juniper PTX10008 (alternate hardware string)"
+
+- librenms_hardware: "Juniper VRR Internet Backbone Router"
+  netbox_device_type: "VRR"
+  description: "Juniper Virtual Route Reflector"
+
+# Nokia — model string matches directly in most cases
+- librenms_hardware: "7750 SR-7s"
+  netbox_device_type: "7750 SR-7s"
+  description: "Nokia 7750 SR-7s service router"
+
+# Cisco — often matches by part_number but not always
+- librenms_hardware: "WS-C4900M"
+  netbox_device_type: "WS-C4900M"
+  description: "Cisco Catalyst 4900M"
+
+# Cisco IOS XR
+- librenms_hardware: "8201-SYS"
+  netbox_device_type: "8201"
+  description: "Cisco 8201 (hardware string differs from model)"
+
+# UfiSpace — LibreNMS reports SONiC/ONIE platform names
+- librenms_hardware: "x86-64-ufispace-s9610-36d-r0"
+  netbox_device_type: "S9610-36D"
+  description: "UfiSpace S9610-36D"
+
+- librenms_hardware: "x86-64-ufispace-s9610-46dx-r0"
+  netbox_device_type: "S9610-46DX"
+  description: "UfiSpace S9610-46DX"
+
+- librenms_hardware: "x86-64-ufispace-s9700-53dx-r9"
+  netbox_device_type: "S9700-53DX"
+  description: "UfiSpace S9700-53DX"