Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
784072f
refactor: split import_utils.py into a package
marcinpsk Feb 26, 2026
c603a29
fix: update mock.patch paths for import_utils package refactor
marcinpsk Feb 26, 2026
8e65b6d
refactor: move Cluster to module-level import in device_operations
marcinpsk Feb 26, 2026
e92eef6
fix: remove stale virtualization.models.Cluster patch in VM import test
marcinpsk Feb 26, 2026
d25344b
feat: honour use_sysname and strip_domain in validation path (port fr…
marcinpsk Feb 27, 2026
e47bf19
Merge branch 'develop' into refactor/utils-package-split
marcinpsk Feb 27, 2026
d977fe3
feat: port serial-matching and conflict-resolution fixes to split imp…
marcinpsk Mar 1, 2026
46d6b08
fix: add librenms_id collision mock to force-with-mismatch tests
marcinpsk Mar 1, 2026
7408b7a
feat: librenms_id refactor from int to JSON
marcinpsk Feb 28, 2026
b9a44b1
fix: address librenms_id-related PR review comments
marcinpsk Feb 28, 2026
16dfb65
fix: update device_filter mocks to accept Q positional args
marcinpsk Feb 28, 2026
e0e9c40
feat: legacy librenms_id int→JSON migration action on import page
marcinpsk Mar 1, 2026
c439c45
fix: PR review fixes — schema, server_key, bulk_import, legacy badge,…
marcinpsk Mar 1, 2026
9068c0c
PR review: code quality, accessibility and correctness fixes
marcinpsk Mar 1, 2026
6c3425f
Fix _refresh_existing_device readiness logic for VMs
marcinpsk Mar 2, 2026
3ac5a36
fix: batch 4 PR review fixes
marcinpsk Mar 2, 2026
0b9ae51
fix: batch 5 PR review fixes
marcinpsk Mar 2, 2026
022293b
fix: batch 6 PR review fixes
marcinpsk Mar 2, 2026
a481d2c
fix: batch 7 - RQ-first cancellation, VC position off-by-one, platfor…
marcinpsk Mar 2, 2026
32caa01
port: upstream PR#227 maintainer commits to refactor/librenms_id branch
marcinpsk Mar 2, 2026
69f1e64
fix: log exceptions in LibreNMSSettings get_or_create (PR#227 comment…
marcinpsk Mar 2, 2026
0f72ceb
fix: pass naming preferences to post-import re-validation
marcinpsk Mar 2, 2026
e96d2bb
feat: port multi-server UI and improve _refresh_existing_device from …
marcinpsk Mar 2, 2026
3b5d71d
Address PR review findings: cache key naming flags, errored job termi…
marcinpsk Mar 3, 2026
4aa196e
Fix PR review findings: race conditions, vc dedup, naming keys, error…
marcinpsk Mar 3, 2026
b64c35a
style: remove misleading tick icons from Primary IP row
marcinpsk Mar 3, 2026
dbacaff
Fix PR review batch 3: logging, cache scoping, guards, precedence, locks
marcinpsk Mar 3, 2026
a72e737
Fix PR review batch 4: disabled field, truthy parsing, VC rollback, p…
marcinpsk Mar 3, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions netbox_librenms_plugin/forms.py
Original file line number Diff line number Diff line change
Expand Up @@ -581,15 +581,15 @@ def _populate_librenms_locations(self):

try:
# Use caching to avoid repeated API calls
cache_key = "librenms_locations_choices"
api = LibreNMSAPI()
cache_key = f"librenms_locations_choices:{api.server_key}"
cached_choices = cache.get(cache_key)

if cached_choices:
self.fields["librenms_location"].choices = cached_choices
return

# Fetch locations from LibreNMS
api = LibreNMSAPI()
success, locations = api.get_locations()

if success and locations:
Expand Down
Loading