Repository navigation
Replay onboarding: Show Welcome and Get Started checklist from Help - #95
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #94
What changed
Two actions replay onboarding on request, with the same labels in both apps:
hasSeenWelcomeis already true for anyone who can see this, so nothing is written.isChecklistDoneback to false. The checklist comes back at the foot of the sidebar and still ticks from real state. It needs at least one Project to show, as before.Asking for the checklist sets a flag that is kept in memory only (
isChecklistReplayed). While it is set, the checklist does not close itself when every row is ticked. Without it, a user with Projects, a Running Service and a connected agent would see the checklist close straight away. It stays until × is clicked, and the flag is gone at the next launch.Where each action lives
other:show-welcomeandother:show-checklist: they show when you type for them (e.g. "welcome", "onboarding", "get started"), like Check for Updates…Why the sidebar footer on Tauri: the Tauri window has no native menu bar. Its only help-type control was the Keyboard Shortcuts button in the sidebar footer, next to Settings. The tray is meant for quick Service controls, not a second app (see
AGENTS.md, Design). So that button is now a Help menu (a?icon), which matches the macOS Help menu entry for entry. Keyboard Shortcuts is still one click away in that menu, and also on Ctrl+/ and in the palette. To open the menu upward,Menugained anisAboveoption.Not changed
First-run rules for new users, the existing-user logic at launch (
atLaunch/onboardingAtLaunch),hasStartedService, Projects, Services and user folders. No telemetry and no version numbers. Docs: one added sentence insite/src/content/docs/quick-start.md, and "it doesn't come back" now reads "it doesn't come back by itself".How it was checked
apps/desktop:pnpm typecheckandpnpm testpass (26 files, 132 tests). New tests:Onboarding.test.tsx› Help: Show Welcome… opens the welcome with a Project present and saves nothing on Skip. Show Get Started Checklist brings back a checklist that was closed. A fully ticked one (4 of 4) stays until ×, which savesisChecklistDone: trueagain. A partly ticked one shows 2 of 4.palette.test.ts: both items are offered when typed for, and Show Welcome… opens the welcome sheet.scripts/build-core.sh debugand thexcodebuildDebug build both succeed, with no new warnings. The macOS app has no test target, so its changes mirror the tested desktop logic.Left out