Repository navigation
fix(locales): Codex texts hold in-game information only — no credit lines, the Rainbow Planet's islands float on the sea (#2182) - #2183
Merged
Conversation
…ines, the Rainbow Planet's islands float on the sea (#2182) - Drop the closing credit sentence ("Dreamed up by …", "Justus' idea.", "Justus asked …") from 9 planet descriptions, the 4 Fifi plant blocks and the monorail blueprint, in all 14 locales. The names stay in ui.credits.body, the README, the changelog and the devblog. - planet.rainbow_sea.desc: islands float on the sea, hardly any land (stale since #1768), all 14 locales. - ContentTests.Descriptions_HoldInGameInformationOnly_NoCreditLines guards en/de *.desc; ArenaNigraWorldTests now forbids the name in the description instead of demanding it. - docs/developer/MINIGAMES_AND_WIKI.md records the rule. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
marceld23
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2182
What
Marcel's rule: the in-game Codex holds in-game information only.
Credit sentences removed (all 14 locales). The closing sentence that named whose idea something was is gone from:
The names stay in
ui.credits.body, the README, the changelog and the devblog.Rainbow Planet fixed (all 14 locales). The text said the islands float in the sky, which has been stale since fix(worldgen,client): the rainbow planet's islands float on the sea, and its water is rainbow through and through (#1757, #1758) #1768. It now reads "there is hardly any land: islands float on the sea with kelp hanging from their undersides into the water".
How
ukchanges 13, because its monorail text never had a credit sentence.Tests
ContentTests.Descriptions_HoldInGameInformationOnly_NoCreditLineschecks that no en/de*.desccontains a credit phrase.ArenaNigraWorldTestsused to demand "Theo" in the description and now forbids it.-warnaserror: 0 warnings, 0 errors.scripts/locale-test-filter.py, 38 classes): 389/389 passed.dotnet format --verify-no-changes: clean.client/Assetschanged.Docs
TODO.mdhas the entry.docs/developer/MINIGAMES_AND_WIKI.md(§Content) records the rule.🤖 Generated with Claude Code