add 'getGroupLayersId' method && fix bugs#2
Open
wang1212 wants to merge 2 commits intomapbox:masterfrom
wang1212:master
Open
add 'getGroupLayersId' method && fix bugs#2wang1212 wants to merge 2 commits intomapbox:masterfrom wang1212:master
wang1212 wants to merge 2 commits intomapbox:masterfrom
wang1212:master
Conversation
- add 'getGroupLayersId' method - fix missing 'metadata' error
`addLayerToGroup(map, groupId, layer, beforeId)` The calculated `beforeId` is incorrect when `beforeId ` is not specified
Author
|
I also found that the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getGroupLayersIdmethodAlthough I can iterate over all the layers to get the
idsof all the layers of a particularidgroup, I think it's best to hide the implementation details ofmetadata.groupfor the user, so I added thegetGroupLayersIdmethod.metadatabe undefined exceptionAll layers added through the plugin have a non-empty
metadataattribute, but I don't think there is any need to add all layers through the plugin, such as a map initialization layer, in which case the layer'smetadatawill beundefined, causing the exception to occur.