Repository navigation
[Codex Security] REST configuration overrides can redirect a retained OAuth client secret during token refresh - #20
Closed
manuzhang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OAuth refresh destinations are now client-controlled by default while intentional server trust remains available.
Static Verification Checks
Default endpoint policy (Passed) — catalog_properties.h sets kTrustServerOAuth2Uri false, establishing server-selected OAuth recipients require explicit client approval.
Credential endpoint pinning (Passed) — RestCatalog::Make validates and restores the operator endpoint after configuration merging, establishing the retained secret cannot be redirected.
Refresh recipient assertion (Passed) — RefreshUsesTheClientEndpointByDefault expects client_secret only at the operator endpoint, establishing secure refresh and preserved token renewal.
Explicit trust compatibility (Passed) — TrustsServerOverridesWhenExplicitlyEnabled accepts the server endpoint after client opt-in, establishing intentional compatibility remains available.
Alternate endpoint rejection (Passed) — RequiresAbsoluteClientEndpointByDefault rejects relative and non-HTTP values before I/O, establishing alternate endpoint encodings cannot bypass validation.
Finding:
acf_f8f907964600e5519354244212161700Patch:
arp_71b2932cc803cef576b5f6b2a276c066Base commit:
cda824400a9032b72850d92df507009da80cebe5Patch SHA-256:
4a3b8b43b3f1c9295917dccd513ff14944fe7f91f6610780d793dc37b2ef5aac