Skip to content

[Codex Security] REST configuration overrides can redirect a retained OAuth client secret during token refresh - #20

Closed
manuzhang wants to merge 1 commit into
mainfrom
codex-security/arp_71b2932cc803cef576b5f6b2a276c066
Closed

manuzhang wants to merge 1 commit into
mainfrom
codex-security/arp_71b2932cc803cef576b5f6b2a276c066

Conversation

@manuzhang

Copy link
Copy Markdown
Owner

OAuth refresh destinations are now client-controlled by default while intentional server trust remains available.

  • The trust flag defaults to false and is restored after merging, so server configuration cannot enable itself.
  • Non-empty operator credentials require an explicit absolute HTTP(S) token URI, which is restored after every server override.
  • Refresh and contextual OAuth requests preserve the approved endpoint, while explicit client opt-in preserves server-selected endpoint compatibility.
  • Static source and diff evidence establish closure; runtime checks were not performed under the required static mode.

Static Verification Checks

  • Default endpoint policy (Passed) — catalog_properties.h sets kTrustServerOAuth2Uri false, establishing server-selected OAuth recipients require explicit client approval.

  • Credential endpoint pinning (Passed) — RestCatalog::Make validates and restores the operator endpoint after configuration merging, establishing the retained secret cannot be redirected.

  • Refresh recipient assertion (Passed) — RefreshUsesTheClientEndpointByDefault expects client_secret only at the operator endpoint, establishing secure refresh and preserved token renewal.

  • Explicit trust compatibility (Passed) — TrustsServerOverridesWhenExplicitlyEnabled accepts the server endpoint after client opt-in, establishing intentional compatibility remains available.

  • Alternate endpoint rejection (Passed) — RequiresAbsoluteClientEndpointByDefault rejects relative and non-HTTP values before I/O, establishing alternate endpoint encodings cannot bypass validation.

  • Finding: acf_f8f907964600e5519354244212161700

  • Patch: arp_71b2932cc803cef576b5f6b2a276c066

  • Base commit: cda824400a9032b72850d92df507009da80cebe5

  • Patch SHA-256: 4a3b8b43b3f1c9295917dccd513ff14944fe7f91f6610780d793dc37b2ef5aac

@manuzhang manuzhang closed this Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant