[Chore] 초기 세팅 오류 수정#4
Conversation
Sehi55
commented
Apr 19, 2026
- application.yaml, build.gradle 오류 수정
📝 WalkthroughSummary by CodeRabbit릴리스 노트
워크스루JWT 라이브러리(jjwt-api, jjwt-jackson)를 0.12.3에서 0.12.6으로 업그레이드하고, Spring JPA/Hibernate 설정을 변경 사항
예상 코드 리뷰 노력🎯 2 (Simple) | ⏱️ ~10 minutes 시
🚥 Pre-merge checks | ✅ 1 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
mannabom-server/src/main/resources/application-prod.yml (1)
97-97: 운영 비밀키 기본값 제거는 보안 측면에서 좋은 변경입니다.Line 97 변경으로 운영 환경에서 의도치 않은 기본키 사용 위험이 줄었습니다. 배포 파이프라인/시크릿 매니저에
MEETING_SECRET_KEY주입만 체크리스트로 고정해두면 더 안전합니다.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@mannabom-server/src/main/resources/application-prod.yml` at line 97, You removed the default production secret (the property "secret: ${MEETING_SECRET_KEY}" in application-prod.yml) which is good; now ensure the deployment and runtime validate that MEETING_SECRET_KEY is provided by (1) adding a required-secret check in your deployment pipeline/secret manager checklist and (2) adding a startup validation in the application bootstrap (check the "secret" property read from MEETING_SECRET_KEY and fail-fast with a clear error if missing) so the app never runs with a missing/empty MEETING_SECRET_KEY.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@mannabom-server/build.gradle`:
- Around line 31-33: Update the JJWT dependency versions declared
(io.jsonwebtoken:jjwt-api, io.jsonwebtoken:jjwt-impl,
io.jsonwebtoken:jjwt-jackson) from 0.12.6 to a newer release (preferably 0.13.0
or at least 0.12.7) so all three coordinates match the chosen version; modify
the three implementation entries to the new version, refresh/reload Gradle
dependencies and run the build/tests to verify no API breaks.
---
Nitpick comments:
In `@mannabom-server/src/main/resources/application-prod.yml`:
- Line 97: You removed the default production secret (the property "secret:
${MEETING_SECRET_KEY}" in application-prod.yml) which is good; now ensure the
deployment and runtime validate that MEETING_SECRET_KEY is provided by (1)
adding a required-secret check in your deployment pipeline/secret manager
checklist and (2) adding a startup validation in the application bootstrap
(check the "secret" property read from MEETING_SECRET_KEY and fail-fast with a
clear error if missing) so the app never runs with a missing/empty
MEETING_SECRET_KEY.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 821586d8-8563-431d-accb-01a484794904
📒 Files selected for processing (3)
mannabom-server/build.gradlemannabom-server/src/main/resources/application-prod.ymlmannabom-server/src/main/resources/application.yaml