Remove unnecessary cgi module import#67
Open
mina86 wants to merge 1 commit intomankyd:masterfrom
Open
Conversation
|
There is another one (used as a fallback) in https://github.com/mankyd/htmlmin/blob/master/htmlmin/escape.py#L33 |
Contributor
Author
|
I didn’t touch that one because it’s harmless on newer Pythons and it allows code to run on older Pythons. |
|
Hi, what's the status on this PR? Seems like a rather trivial fix to support 3.13. Edit: I see the package hasn't been updated/maintained in 8 years. Perhaps we could contact the owner to ask if another maintainer can be appointed? |
I have just sent sent an email to the maintainer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cgimodule has been removed in Python 3.13.Remove the unused import so that the code runs.