Conversation
plist 5 and bplist-parser 0.5 are ESM-only — their exports map has no require
condition — so require('plist') in usbmux.js, tools/device-info.js and
tools/list-apps.js throws ERR_PACKAGE_PATH_NOT_EXPORTED and the host dies before
its window opens. Verified on Windows 11 with the dependency set from #6.
CI cannot catch this: host-windows and host-macos only package the app with
electron-builder, they never start it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes / Что меняется
Dependabot больше не будет предлагать мажорные обновления
plistиbplist-parser.Why / Зачем
plist@5иbplist-parser@0.5перешли на ESM: в ихexportsнет условияrequire. Любойrequire('plist')— а он есть вusbmux.js(который тянетmain.js),tools/device-info.jsиtools/list-apps.js— падает сERR_PACKAGE_PATH_NOT_EXPORTED, и хост умирает до открытия окна.Проверено на Windows 11 с набором зависимостей из #6.
CI такое не ловит:
host-windowsиhost-macosтолько упаковывают приложение черезelectron-builder и ни разу его не запускают.
Снять ограничение можно, когда эти три места перейдут на динамический
import().How it was tested / Как проверено
npm testpassesпосле отката
plistк^3.1.1(electron при этом оставался 44.3.0)Checklist
Closes the reason #6 cannot be merged as is.
🤖 Generated with Claude Code