refactor: migrate web Collapsible to @makeplane/propel Collapsible - #9743
Open
codingwolf-at wants to merge 9 commits into
Open
refactor: migrate web Collapsible to @makeplane/propel Collapsible#9743codingwolf-at wants to merge 9 commits into
codingwolf-at wants to merge 9 commits into
Conversation
- Migrate collapsible components in issue detail widgets (attachments, links, relations, sub-issues) from @plane/ui to @makeplane/propel. - Adjust props and structure for consistency with new collapsible implementation. - Enhance title components to integrate action buttons and improve accessibility. - Refactor related components to streamline imports and improve code clarity.
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
- Update the icon rendering logic in the RelationsCollapsibleContent component to apply additional styling using the cn utility. - Ensure that icons are wrapped in a styled span for consistent presentation and alignment.
…ontent - Wrap RelationIssueList in a div to cancel the nested Collapsible's panel inset, ensuring proper alignment under the outer Relations collapsible. - Improve visual consistency by preventing stacking of insets in the UI.
- Wrap the Collapsible component for pending invitations in a div to enhance layout and spacing. - Ensure consistent visual presentation by adjusting the structure of the component.
- Update the onOpenChange prop in SubIssuesListGroup and WorkspaceMembersList to directly use the state setter function, improving code clarity and reducing unnecessary function wrapping.
- Remove optional chaining from the mapping of workItemIds to enhance code clarity and ensure consistent handling of the array.
…ents - Update padding in the attachment list item for improved spacing and alignment. - Remove unnecessary padding from the link list component to streamline layout.
…-propel-collapsible # Conflicts: # apps/web/core/components/issues/issue-detail-widgets/sub-issues/issues-list/list-group.tsx # apps/web/core/components/workspace/settings/members-list.tsx
Align the pnpm-lock.yaml file to reflect the updated version of @makeplane/propel from 0.2.0 to 0.3.0 for consistency across importers.
codingwolf-at
marked this pull request as ready for review
September 3, 2026 06:50
◈ PR LensReading ◈ Rendered by PR Lens · crafted with ❤️ by the Coldtea team · Something drawn wrong? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrates the Collapsible used across issue detail widgets (attachments, links, relations, sub-issues) and the workspace settings members panel (pending invites) from
@plane/ui'sCollapsible/CollapsibleButtonto the published@makeplane/propelCollapsible.Propel's ready-made
Collapsibleonly exposestrigger/icon/trailingprops, with no built-in "action visible only while open" slot the way the oldCollapsibleButtondid. Eachtitle.tsxwas restructured to return just the trigger content (label + count/progress badge), and the correspondingroot.tsxnow wires the trailing action button directly, gated on open/disabled state to match the previous behavior.content.tsx(per-relation nested collapsibles) andlist-group.tsx(grouped sub-issues) were converted the same way, dropping their manual chevron icons in favor of Propel's built-in rotating indicator.Type of Change
Screenshots and Media (if applicable)
Verified all 6 changed surfaces in light and dark, open and closed states
Test Scenarios