fix(plane-enterprise): bump iframely v1.2.0 -> v2.5.4 by pratapalakshmi · Pull Request #312 · makeplane/helm-charts

pratapalakshmi · 2026-09-07T09:41:26Z

Description

The chart's iframely default was still v1.2.0 (Aug 2025) while every docker-compose target in plane-ee moved to the v2.5.x line during the v3.0.0 release. That release's audit was scoped to compose only — its notes cover "cli/coolify/portainer commercial, podman compose + quadlets, and the aio Dockerfile build stage" and never mention helm — so the chart was missed rather than deliberately held back.

It matters because v1.2.0 is badly out of date. Trivy, HIGH/CRITICAL with --ignore-unfixed, on linux/amd64:

Image	Findings	CRITICAL
`makeplane/iframely:v1.2.0`	147	7
`makeplane/iframely:v2.5.4`	21	1

Bumped in all four places the version is spelled out, so helm show values, the Rancher questions form, the template fallback and the README table cannot drift apart:

values.yaml — services.iframely.image
questions.yml — services.iframely.image default
templates/workloads/iframely.deployment.yaml — the default fallback
README.md — values table

Why this is safe for the chart specifically

Worth calling out, because the chart does something the compose files don't: it sets command: [node] / args: [server.js], which overrides the image's own entrypoint (exec node cluster.js). A restructured image would break that silently rather than loudly. I checked both tags:

identical /iframely/server.js (885 bytes) present in both
same WorkingDir (/iframely) and same entrypoint script

So the override still resolves. Note this means the chart runs iframely single-process rather than clustered — that's pre-existing behaviour and unchanged here, but someone may want to revisit it separately.

Chart version 3.5.7 → 3.5.8, matching how the recent chart fixes (#298, #299, #295) each carried their own patch bump.

Type of Change

Bug fix (non-breaking change which fixes an issue)
Feature (non-breaking change which adds functionality)
Improvement (change that would cause existing functionality to not work as expected)
Code refactoring
Performance improvements
Documentation update

Test Scenarios

helm lint charts/plane-enterprise — passes.
helm template with services.iframely.enabled=true and no env.external_iframely_url renders image: makeplane/iframely:v2.5.4.
The same render with --set services.iframely.image=myrepo/iframely:custom still yields myrepo/iframely:custom, so an explicit user override is unaffected.
Scanned both image tags directly to produce the table above.

References

Part of the same INFRA-843 Trivy remediation as makeplane/plane-ee#9412 and fix(security): clear the HIGH/CRITICAL Trivy findings in the community images plane#9773; the enterprise AIO image and all six commercial compose/podman/portainer/coolify manifests are moving to v2.5.4 in plane-ee.
Not covered here: helm-charts-private's plane-cloud chart still defaults services.iframely.default_tag to v2.5.0. Separate repo, so I left it alone — happy to raise that too if wanted.

🤖 Generated with Claude Code

Summary by CodeRabbit

Updates
- Updated the Enterprise Helm chart version to 3.5.8.
- Updated the default Iframely container image to version 2.5.4 across deployment configuration and documentation.

The chart's iframely default was still v1.2.0 (Aug 2025) while every docker-compose target in plane-ee had moved to the v2.5.x line during the v3.0.0 release. That release's audit was scoped to compose only -- the docs/release-v3.0.0-audit notes cover "cli/coolify/portainer commercial, podman compose + quadlets, and the aio Dockerfile build stage" and never mention helm -- so the chart was simply missed rather than deliberately held back. It matters because v1.2.0 is heavily out of date. Trivy, HIGH/CRITICAL with --ignore-unfixed, on linux/amd64: makeplane/iframely:v1.2.0 147 findings, 7 CRITICAL makeplane/iframely:v2.5.4 21 findings, 1 CRITICAL Bumped in all four places the version is spelled out, so `helm show values`, the Rancher questions form, the template fallback and the README table cannot drift apart: - values.yaml services.iframely.image - questions.yml services.iframely.image default - templates/workloads/iframely.deployment.yaml default fallback - README.md values table Safe for the chart's invocation, which is the thing worth checking: the chart sets command=[node] args=[server.js], overriding the image's entrypoint (`exec node cluster.js`), so a restructured image would break it silently. Both tags carry an identical /iframely/server.js (885 bytes) with WorkingDir /iframely and the same entrypoint, so the override still resolves. Note the chart therefore runs iframely single-process rather than clustered -- pre-existing, unchanged here. Verified: `helm lint` passes; `helm template` with the service enabled renders `image: makeplane/iframely:v2.5.4`, and an explicit services.iframely.image override still wins. Chart version 3.5.7 -> 3.5.8, matching how the recent chart fixes (#298, #299, #295) each carried their own patch bump. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

coderabbitai · 2026-09-07T09:41:41Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: f4adac99-5c12-49f8-97f0-9d45ffd9961d

📥 Commits

Reviewing files that changed from the base of the PR and between cad0cf2 and d87c4e0.

📒 Files selected for processing (5)

charts/plane-enterprise/Chart.yaml
charts/plane-enterprise/README.md
charts/plane-enterprise/questions.yml
charts/plane-enterprise/templates/workloads/iframely.deployment.yaml
charts/plane-enterprise/values.yaml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The Plane Enterprise Helm chart version changes to 3.5.8. All default and documented Iframely image references change from v1.2.0 to v2.5.4.

Changes

Plane Enterprise chart update

Layer / File(s)	Summary
Chart and Iframely version updates `charts/plane-enterprise/Chart.yaml`, `charts/plane-enterprise/values.yaml`, `charts/plane-enterprise/questions.yml`, `charts/plane-enterprise/templates/workloads/iframely.deployment.yaml`, `charts/plane-enterprise/README.md`	The chart version changes to `3.5.8`. Default and documented Iframely image references change to `makeplane/iframely:v2.5.4`. Explicitly configured images remain unchanged.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to d87c4

This updates the Enterprise chart’s default Iframely image to v2.5.4 and increments the chart version. The image references and override behavior are aligned, with no actionable merge risk identified.

Suggested reviewers: akshat5302, sriramveeraghanta

Poem

A rabbit updates the chart with care
New Iframely tags hop everywhere
The chart now wears three-five-eight
Defaults align and document the state
Tiny changes leave the burrow bright

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: updating the Plane Enterprise Iframely image from v1.2.0 to v2.5.4.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/infra-843-iframely-v2.5.4

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

makeplane · 2026-09-07T09:41:51Z

Linked to Plane Work Item(s)

References

(INFRA-843) fix trivy scans for plane services also fix trivy-scan job to fail if there are any HIGH or CRITICAL vulnerabilities

This comment was auto-generated by Plane

pratapalakshmi closed this Sep 7, 2026

pratapalakshmi reopened this Sep 7, 2026

akshat5302 approved these changes Sep 7, 2026

View reviewed changes

pratapalakshmi merged commit a005c22 into master Sep 7, 2026
1 check passed

pratapalakshmi deleted the fix/infra-843-iframely-v2.5.4 branch September 7, 2026 10:06

Navigation Menu

Uh oh!

fix(plane-enterprise): bump iframely v1.2.0 -> v2.5.4 - #312

fix(plane-enterprise): bump iframely v1.2.0 -> v2.5.4#312
pratapalakshmi merged 1 commit into
masterfrom
fix/infra-843-iframely-v2.5.4

pratapalakshmi commented Sep 7, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Sep 7, 2026 •

edited

Loading

Uh oh!

makeplane Bot commented Sep 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

pratapalakshmi commented Sep 7, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Why this is safe for the chart specifically

Type of Change

Test Scenarios

References

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Sep 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

makeplane Bot commented Sep 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

pratapalakshmi commented Sep 7, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Sep 7, 2026 •

edited

Loading