Skip to content

Map timezones of the form GMT-0800 to corresponding Olson names#2

Open
smokris wants to merge 19 commits into
maintaina-com:FRAMEWORK_6_0from
smokris:gmt-timezone
Open

Map timezones of the form GMT-0800 to corresponding Olson names#2
smokris wants to merge 19 commits into
maintaina-com:FRAMEWORK_6_0from
smokris:gmt-timezone

Conversation

@smokris

@smokris smokris commented Dec 30, 2022

Copy link
Copy Markdown

I've encountered some calendar events that I've imported to my desktop calendar but fail to sync to Horde Kronolith, emitting errors like this:

WARN: HORDE [kronolith] Unable to parse timezone for event ID …: Horde_Timezone_Exception: Timezone GMT-0800 not found in vendor/horde/timezone/lib/Horde/Timezone.php

This PR adds support for converting those to Olson names, and adds a few test cases. (Olson only defines names for integer offsets, not for quarter-hour offsets, so the last test case ensures this change at least doesn't make the situation worse for those.)

(BTW, thanks for your work updating Horde for PHP 8!)

ralflang pushed a commit that referenced this pull request Oct 26, 2023
PHP 8.1: use 'now' rather than null for current date
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants