Repository navigation
fix: keep snap.yaml store-schema clean and release v0.4.1 - #55
Conversation
|
Warning Review limit reachedNext included review available in 25 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe changes validate Snap Store metadata, stage the icon at ChangesSnap release packaging
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to The release packaging now omits the unsupported Snap icon field, retains the packaged icon, and attaches Snap artifacts to tagged releases. No current merge-blocking risk is identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: Cursor <cursoragent@cursor.com>
05b1d74 to
61d2583
Compare
What & why
The
v0.4.0release job failed on the Snap Store upload: the store'ssnap.jsonschema rejects anicon:key insnap.yaml(Additional properties are not allowed ('icon' was unexpected)). Everything else in that release published — GitHub Release, Docker Hub/GHCR, Homebrew and NUR PRs — so this cutsv0.4.1to land the snap.snapcrafts[].icon; goreleaser writes it straight intosnap.yaml. The icon still reaches the store viameta/gui/icon.png, whichextra_filesalready stages.release.extra_filesattachesdist/*.snapto the GitHub release. Snap artifacts are store-publishable, not release-uploadable, so goreleaser skipped them and the release job's.snapasset check would have failed even after the schema fix.snapjob runsreview-toolsover both packed snaps.snap install --dangerousaccepts metadata the store refuses, which is why this only showed up on a tag;snap-reviewis what the store runs on upload, so the whole schema is covered rather than the one key we tripped over.How to test
v0.4.1tag, the release run finishes green, including the Snap Store upload and the.snapasset checksudo snap install mailtrap-localon Ubuntu once Canonical review clears; UI at http://127.0.0.1:3550, SMTP at 127.0.0.1:3535v0.4.1carriesmailtrap-local_0.4.1_linux_amd64.snapand_arm64.snapalongside the tarballsSummary by CodeRabbit